[Bug 20601] Do not put "diff generator" comments into feeds

2009-10-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20601


Bug 20601 depends on bug 21053, which changed state.

Bug 21053 Summary: Broken diff header layout for multi diffs with no changes
https://bugzilla.wikimedia.org/show_bug.cgi?id=21053

   What|Old Value   |New Value

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED



-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20601] Do not put "diff generator" comments into feeds

2009-10-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20601


RockMFR  changed:

   What|Removed |Added

 Depends on||21053




-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20601] Do not put "diff generator" comments into feeds

2009-09-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20601





--- Comment #6 from jida...@jidanni.org  2009-09-17 00:35:54 UTC ---
Thanks. Discussion logged in
http://news.gmane.org/group/gmane.org.wikimedia.mediawiki/thread=32143 .


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20601] Do not put "diff generator" comments into feeds

2009-09-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20601


Tim Starling  changed:

   What|Removed |Added

 CC||tstarl...@wikimedia.org
 Status|NEW |RESOLVED
 Resolution||FIXED




--- Comment #5 from Tim Starling   2009-09-16 03:48:53 
UTC ---
Committed similar solution in r56406.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20601] Do not put "diff generator" comments into feeds

2009-09-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20601





--- Comment #4 from jida...@jidanni.org  2009-09-14 19:00:15 UTC ---
And furthermore:
"But I'm only putting comments into an XML feed." No you are not.
Comments look like , not encoded.

"But I provide a Last-modified HTTP header." Yes, however all it takes
is for one item in the feed to change, and then we get all the items
which contain diffs change. Caching 101... the basics, don't spoil it.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20601] Do not put "diff generator" comments into feeds

2009-09-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20601


Chad H.  changed:

   What|Removed |Added

   Keywords|patch   |




--- Comment #3 from Chad H.   2009-09-14 02:13:37 UTC 
---
Removing patch keyword, not a desirable solution.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20601] Do not put "diff generator" comments into feeds

2009-09-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20601


jida...@jidanni.org changed:

   What|Removed |Added

   Keywords||patch




-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20601] Do not put "diff generator" comments into feeds

2009-09-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20601





--- Comment #2 from jida...@jidanni.org  2009-09-13 01:03:55 UTC ---
Created an attachment (id=6546)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6546)
turn off damaging debugging comments in production environment

You don't understand how serious the problem is.
For rapidly changing wikis, users won't notice the problem.
But for small wikis, you will be doubling the users RSS stored articles each
time he browses... and he will wonder why they have reappeared again as
new.

Let's see the difference in the same HTTP GET of
index.php?title=Special:RecentChanges&feed=rss
before and after doing
TRUNCATE TABLE objectcache:
>@@ -24 +24 @@
>-  Sun, 13 Sep 2009 00:09:25 GMT
>+  Sun, 13 Sep 2009 00:12:10 GMT
>@@ -87 +87 @@
>-
>+
Well, we see the lastBuildDate holds the same information, so the
attached patch to remove the superfluous diff generator comment will not
remove any information, and at the same time not confuse RSS readers
into thinking the article has changed!

The better maintained a wiki is (the more often it is updated), the more
frustrated the user becomes, as each update truncates the objectcache,
causing the comments you are putting into the bodies to change.

Keep your debugging comments off in production environments please.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20601] Do not put "diff generator" comments into feeds

2009-09-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20601


Chad H.  changed:

   What|Removed |Added

 CC||innocentkil...@gmail.com
   Severity|major   |normal




--- Comment #1 from Chad H.   2009-09-11 21:43:37 UTC 
---
Lowering severity.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20601] Do not put "diff generator" comments into feeds

2009-09-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20601


jida...@jidanni.org changed:

   What|Removed |Added

URL||http://article.gmane.org/gma
   ||ne.emacs.gnus.user/12856




-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l