[Bug 20892] Add ability to detect deleted revisions and page creation
https://bugzilla.wikimedia.org/show_bug.cgi?id=20892 --- Comment #10 from Huji huji.h...@gmail.com --- I believe the lack of index is a separate bug. Since we already have a functionality in MediaWiki itself that is using a non-indexed column to show a message to the user when trying to recreate a previously deleted page, one might say that having a similar functionality in AbuseFilter should not be prohibited just based on the lack of index. Regardless, I've created bug 66961 as a blocker, and will wait for that to be fixed before my patch for 20892 is implemented. In the meantime, I would be grateful if one could review the latest patch to see if there are any *other* problems with it. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20892] Add ability to detect deleted revisions and page creation
https://bugzilla.wikimedia.org/show_bug.cgi?id=20892 Huji huji.h...@gmail.com changed: What|Removed |Added Depends on||66961 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20892] Add ability to detect deleted revisions and page creation
https://bugzilla.wikimedia.org/show_bug.cgi?id=20892 Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com changed: What|Removed |Added CC||martinezn...@gmail.com --- Comment #9 from Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com --- Gerrit change 139103 has CR -2 now because there's no index to quickly get the number of times it has been deleted. I was going to propose a variable with the number of deleted revisions, but I'm a bit shocked because the archive table has index for ar_namespace but not for ar_title (!!!) [1], so it will have the same problem. But because of that, does it mean that the message that appears on top of pages that have deleted revisions is using a slow query to get the number of deleted revisions, because there's no index for that? I guess there should be an index for this one (namespace and title). [1] https://www.mediawiki.org/wiki/Manual:Archive_table -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20892] Add ability to detect deleted revisions and page creation
https://bugzilla.wikimedia.org/show_bug.cgi?id=20892 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 139105 abandoned by Huji: AbuseFilter: Add ability to detect deleted revisions Reason: Merged back into I4ec2c6aa1fc8aba1e6eb0563fec9ab05bb738d40 https://gerrit.wikimedia.org/r/139105 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20892] Add ability to detect deleted revisions and page creation
https://bugzilla.wikimedia.org/show_bug.cgi?id=20892 --- Comment #8 from Huji huji.h...@gmail.com --- I marked 139105 is abandoned because I finally figured out how to merge it back into https://gerrit.wikimedia.org/r/139103 (please check new patchset there) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20892] Add ability to detect deleted revisions and page creation
https://bugzilla.wikimedia.org/show_bug.cgi?id=20892 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 139103 had a related patch set uploaded by Huji: AbuseFilter: Add ability to detect deleted revisions https://gerrit.wikimedia.org/r/139103 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20892] Add ability to detect deleted revisions and page creation
https://bugzilla.wikimedia.org/show_bug.cgi?id=20892 Huji huji.h...@gmail.com changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |huji.h...@gmail.com |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20892] Add ability to detect deleted revisions and page creation
https://bugzilla.wikimedia.org/show_bug.cgi?id=20892 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20892] Add ability to detect deleted revisions and page creation
https://bugzilla.wikimedia.org/show_bug.cgi?id=20892 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 139105 had a related patch set uploaded by Huji: AbuseFilter: Add ability to detect deleted revisions https://gerrit.wikimedia.org/r/139105 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20892] Add ability to detect deleted revisions and page creation
https://bugzilla.wikimedia.org/show_bug.cgi?id=20892 Danny B. dann...@email.cz changed: What|Removed |Added Summary|Add ability to detect |Add ability to detect |deleted revisions |deleted revisions and page ||creation -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20892] Add ability to detect deleted revisions and page creation
https://bugzilla.wikimedia.org/show_bug.cgi?id=20892 Jackmcbarn jackmcbarn+w...@gmail.com changed: What|Removed |Added CC||jackmcbarn+w...@gmail.com --- Comment #3 from Jackmcbarn jackmcbarn+w...@gmail.com --- I think the best way to implement this would be variables containing the number of live and deleted revisions. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20892] Add ability to detect deleted revisions and page creation
https://bugzilla.wikimedia.org/show_bug.cgi?id=20892 --- Comment #4 from Huji huji.h...@gmail.com --- I think the number of deleted revisions is not something that should be exposed publicly (only sysops can see them outside the AbuseFilter, so only sysops can also see their count in the AbuseFilter's context). On the otherhand, the fact that the page was deleted (which is publicly available in logs) is something that can be also useful for AbuseFilter purposes. Hence my recommendation for a has_been_deleted variable in bug 66031. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
