[Bug 21119] A button on the page to toggle hidden categories
https://bugzilla.wikimedia.org/show_bug.cgi?id=21119 Antoine hashar Musso has...@free.fr changed: What|Removed |Added CC||has...@free.fr --- Comment #10 from Antoine hashar Musso has...@free.fr --- I have abandoned change 3981 for now so it does not clutter people dashboards. IF there is really an interest in such a feature and someone willing to continue this change, feel free to reopen it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21119] A button on the page to toggle hidden categories
https://bugzilla.wikimedia.org/show_bug.cgi?id=21119 --- Comment #8 from Max Semenik maxsem.w...@gmail.com 2012-03-30 06:31:47 UTC --- For the reference: https://www.mediawiki.org/wiki/Manual:Coding_conventions -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21119] A button on the page to toggle hidden categories
https://bugzilla.wikimedia.org/show_bug.cgi?id=21119 --- Comment #9 from akshay chugh chughaksha...@gmail.com 2012-03-30 12:48:16 UTC --- (In reply to comment #5) Akshay, please go ahead and submit this as a branch in Git. This patch would require a complete rewrite, no point in pushing it at the moment. * Unlocalised text. * Weird a id=mw-toggle-cat href=javascript:void(0)iShow hidden categories/i/a that will not work with JS disabled. Instead, JS should generate such links completely. * Mix of jQuery and raw JS. * Code style. * Messages must use sentence case. I have committed the changes to gerrit. changeset link - https://gerrit.wikimedia.org/r/3981 It takes care of all the issues you pointed out earlier. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21119] A button on the page to toggle hidden categories
https://bugzilla.wikimedia.org/show_bug.cgi?id=21119 Max Semenik maxsem.w...@gmail.com changed: What|Removed |Added Keywords|need-review, patch | CC||maxsem.w...@gmail.com --- Comment #5 from Max Semenik maxsem.w...@gmail.com 2012-03-29 21:22:28 UTC --- Akshay, please go ahead and submit this as a branch in Git. This patch would require a complete rewrite, no point in pushing it at the moment. * Unlocalised text. * Weird a id=mw-toggle-cat href=javascript:void(0)iShow hidden categories/i/a that will not work with JS disabled. Instead, JS should generate such links completely. * Mix of jQuery and raw JS. * Code style. * Messages must use sentence case. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21119] A button on the page to toggle hidden categories
https://bugzilla.wikimedia.org/show_bug.cgi?id=21119 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords||patch, reviewed --- Comment #6 from Sumana Harihareswara suma...@panix.com 2012-03-30 04:44:58 UTC --- Marking patch reviewed. Akshay, are you interested in rewriting to address Max's criticisms? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21119] A button on the page to toggle hidden categories
https://bugzilla.wikimedia.org/show_bug.cgi?id=21119 --- Comment #7 from akshay chugh chughaksha...@gmail.com 2012-03-30 05:19:43 UTC --- (In reply to comment #6) Marking patch reviewed. Akshay, are you interested in rewriting to address Max's criticisms? Okay , I would address the issues pointed out by Max and submit a new patch. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21119] A button on the page to toggle hidden categories
https://bugzilla.wikimedia.org/show_bug.cgi?id=21119
--- Comment #3 from akshay chugh chughaksha...@gmail.com 2012-03-28 07:51:40
UTC ---
Created attachment 10337
-- https://bugzilla.wikimedia.org/attachment.cgi?id=10337
It makes a link in the bottom of the page for the hidden category links
Two changes have been made to achieve this effect :
1. Skin.php
if ( isset( $allCats['hidden'] ) ) {
.
$s.='a id=mw-toggle-cat href=javascript:void(0)iShow hidden
categories/i/a';
}
This statement adds an anchor element just below the div(#mw-normal-catlinks)
2. Mediawiki.page.ready.js
...
var toggleCatBool = true;
$(#mw-toggle-cat).click(function(event){
$(#mw-hidden-catlinks).toggle();
var text='';
if(toggleCatBool)
text='Hide Hidden Category Links';
else
text='Show Hidden Category Links';
document.getElementById(mw-toggle-cat).innerHTML='i'+text+'/i';
toggleCatBool=!toggleCatBool;
});
This manages the toggling behavior of div(#mw-hidden-catlinks)
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21119] A button on the page to toggle hidden categories
https://bugzilla.wikimedia.org/show_bug.cgi?id=21119 akshay chugh chughaksha...@gmail.com changed: What|Removed |Added Keywords||need-review, patch CC||chughaksha...@gmail.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21119] A button on the page to toggle hidden categories
https://bugzilla.wikimedia.org/show_bug.cgi?id=21119 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added CC||suma...@panix.com --- Comment #4 from Sumana Harihareswara suma...@panix.com 2012-03-28 16:52:28 UTC --- Akshay, please go ahead and submit this as a branch in Git. https://www.mediawiki.org/wiki/Git/Workflow That way it can get reviewed faster. Thanks. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21119] A button on the page to toggle hidden categories
https://bugzilla.wikimedia.org/show_bug.cgi?id=21119 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC||krinklem...@gmail.com, ||tpars...@wikimedia.org Component|Categories |Javascript Blocks||2114 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21119] A button on the page to toggle hidden categories
https://bugzilla.wikimedia.org/show_bug.cgi?id=21119 Brion Vibber br...@pobox.com changed: What|Removed |Added CC||br...@pobox.com AssignedTo|wikibugs- |agarr...@wikimedia.org |l...@lists.wikimedia.org | --- Comment #1 from Brion Vibber br...@pobox.com 2009-10-14 17:43:28 UTC --- I, too, would welcome our new hidden-category overlords. Andrew, maybe this would fit in with the category editing widget you were experimenting with? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21119] A button on the page to toggle hidden categories
https://bugzilla.wikimedia.org/show_bug.cgi?id=21119 --- Comment #2 from Andrew Garrett agarr...@wikimedia.org 2009-10-14 17:46:20 UTC --- (In reply to comment #1) I, too, would welcome our new hidden-category overlords. Andrew, maybe this would fit in with the category editing widget you were experimenting with? Possibly, although it'd be just as easy to add this separately. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21119] A button on the page to toggle hidden categories
https://bugzilla.wikimedia.org/show_bug.cgi?id=21119 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Component|Feature_Request |Categories Product|MediaWiki Feature Request |MediaWiki -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
