[Bug 23433] Load site js before gadgets

2013-09-20 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=23433

John Mark Vandenberg jay...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||jay...@gmail.com
 Resolution|--- |WONTFIX

--- Comment #4 from John Mark Vandenberg jay...@gmail.com ---
ResourceLoader should have provided the desired functionality. Marking as
wontfix.
If you have an JS load ordering problem, please re-open and describe the
problematic scenario.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 23433] Load site js before gadgets

2012-11-09 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=23433

duplicate...@googlemail.com changed:

   What|Removed |Added

 CC||duplicate...@googlemail.com

--- Comment #3 from duplicate...@googlemail.com 2012-11-09 19:00:07 UTC ---
Fixed by the ResourceLoader?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 23433] Load site js before gadgets

2011-02-21 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=23433

Mizusumashi mizusuma...@coda.ocn.ne.jp changed:

   What|Removed |Added

 CC||mizusuma...@coda.ocn.ne.jp

--- Comment #1 from Mizusumashi mizusuma...@coda.ocn.ne.jp 2011-02-21 
10:34:52 UTC ---
I'm sorry, but I disagree with Jimmy.  I think loading site common.js after
gadgets is better.  Loading user scripts and gadets before site common.js is
best.

I want to detect witch gadgets and/or user setteings in site common.js. 
Jimmy's oder makes this detection impossible.  On the other hand,  hooking
gadget's real code by site common.js is not so difficult even in the current
order.

Gadget A:
  var gadget_a_enable = true;

Gadget B:
  function gadget_b_hook () {
  // whatever you want
  }
  if(typeof commonHook == 'undefined'){
　　　commonHook = new Array();
  }
  commonHook[commonHook.length] = gadget_b_hook;

site commn.js ([[MediaWiki:Common.js]]):
  if(typeof gadget_a_enable != 'undefined'  gadget_a_enable){
  // ... if Gadget A is enable...
  }else{
  // ... if Gadget A is disable ...
  }

  if(typeof commonHook != 'undefined'){
  for(var i = 0; i  commonHook.length; i++){
  commonHook[i]();
  }
  }

I think, anyone can say But, even in Jimmy's oder, detection gadgets in 'real'
code of common.js is not so diffcult too:

Gadget A:
  var gadget_a_enable = true;

site commn.js ([[MediaWiki:Common.js]]):
  $(document).ready(function ($){
  if(typeof gadget_a_enable != 'undefined'  gadget_a_enable){
  // ... whatevet I want ...
  }
  });

But I need to say, $(document).ready somtime makes waiting for long time.  Of
course,  if you want or need to wait that the document is ready, this is a good
way.  But this long time lag is not fine in some case.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 23433] Load site js before gadgets

2011-02-21 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=23433

--- Comment #2 from Michael Dale d...@ucsc.edu 2011-02-21 15:16:15 UTC ---
The way I address this in mwEmbed is through a series of bind and triggers
which give you both temporal loading flexibility and fine grain extendability
of components. 

Bind and triggers are a pefered way for javascript to extend and interact it
offers features like ( name spacing, binding undefined target names, and with
utility functions like triggerQueueCallback, blocking triggers. 
http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/MwEmbedSupport/MwEmbedModules/MwEmbedSupport/jquery/jquery.triggerQueueCallback.js
 

All the code that is loaded on every page is loader code. These loaders
define interface entry points and setup up global bindings. For example see how
timedText extends the embedPlayer interface :

http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/TimedMediaHandler/MwEmbedModules/TimedText/TimedText.loader.js

and the mwEmbed loader:

http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/EmbedPlayer.loader.js

Hopefully the example is not too specific to the video player context. The
basic point is we should have defined points of extending things so the order
in which things are loaded does not matter as much ( as long as all the loader
/ binding code is loaded before the page ready or SetupInterfaces event is
fired. And all the triggers happen after page ready

$(document).ready should NOT mean waiting for a long time. It is fired once the
dom is ready not all the images in the page are loaded. A SetupInterfaces
and IntefacesReady event could also be used but in practice it happens almost
the same time as DOM ready ( since you want to give every loaded javascript a
chance to bind to that event before you trigger it ) ... So if you don't need
more complicated interface state control $(document).ready works just as well.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l