[Bug 24186] Examine page is visible to users without abusefilter-log-detail right
https://bugzilla.wikimedia.org/show_bug.cgi?id=24186 Nikola Kovacs nx.devn...@gmail.com changed: What|Removed |Added CC||nx.devn...@gmail.com --- Comment #12 from Nikola Kovacs nx.devn...@gmail.com 2011-12-27 21:44:43 UTC --- The patch prevents access to the examine page completely, not just for log entries (e.g. you won't be able to examine edits from recent changes). My patch for bug 33390 prevents access to the examine page only for abuse log entries. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24186] Examine page is visible to users without abusefilter-log-detail right
https://bugzilla.wikimedia.org/show_bug.cgi?id=24186 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Status|NEW |RESOLVED CC||m...@everybody.org Resolution||FIXED --- Comment #13 from Mark A. Hershberger m...@everybody.org 2011-12-27 23:38:13 UTC --- r107451 I'm applying Nikola Kovacs' patch and closing this bug. Reopen if that is insufficient. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24186] Examine page is visible to users without abusefilter-log-detail right
https://bugzilla.wikimedia.org/show_bug.cgi?id=24186 John Mark Vandenberg jay...@gmail.com changed: What|Removed |Added Keywords||need-review CC||jay...@gmail.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24186] Examine page is visible to users without abusefilter-log-detail right
https://bugzilla.wikimedia.org/show_bug.cgi?id=24186 p858snake p858sn...@gmail.com changed: What|Removed |Added Keywords||patch CC||p858sn...@gmail.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24186] Examine page is visible to users without abusefilter-log-detail right
https://bugzilla.wikimedia.org/show_bug.cgi?id=24186 Leinad danny.lei...@gmail.com changed: What|Removed |Added CC||aokomori...@enmps.net --- Comment #10 from Leinad danny.lei...@gmail.com 2010-08-18 12:12:58 UTC --- *** Bug 24841 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24186] Examine page is visible to users without abusefilter-log-detail right
https://bugzilla.wikimedia.org/show_bug.cgi?id=24186 --- Comment #11 from aokomoriuta aokomori...@enmps.net 2010-08-18 12:26:25 UTC --- Thank you for telling duplicate. And then, how's this bug going on? We seriously need to fix this. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24186] Examine page is visible to users without abusefilter-log-detail right
https://bugzilla.wikimedia.org/show_bug.cgi?id=24186 lampak llam...@gmail.com changed: What|Removed |Added Attachment #7537|0 |1 is obsolete|| Attachment #7538|0 |1 is obsolete|| Attachment #7540|0 |1 is obsolete|| --- Comment #4 from lampak llam...@gmail.com 2010-07-01 09:33:15 UTC --- Created an attachment (id=7538) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7538) patch no. 2 Small quick fix of one line. I'm not sure it's much better but I'm hurrying a bit (because of real-life reasons). --- Comment #5 from lampak llam...@gmail.com 2010-07-01 10:55:43 UTC --- The patch doesn't work! Sorry for the mess. --- Comment #6 from lampak llam...@gmail.com 2010-07-01 11:07:07 UTC --- Created an attachment (id=7539) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7539) patch no. 3 --- Comment #7 from lampak llam...@gmail.com 2010-07-01 11:15:12 UTC --- Created an attachment (id=7540) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7540) patch no. 3 with extra modifications from previous patches Ok, this one should work. In this version it turns out I don't use that canSeeDetails so there's no need to move these functions. But I don't think it was a bad idea anyway so you here have two versions of a patch for you to decide. Sorry for the mess and confusion and everything. This is what happens when you try to do something quickly :/ --- Comment #8 from lampak llam...@gmail.com 2010-07-01 11:22:26 UTC --- Created an attachment (id=7541) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7541) patch no. 3a with extra modifications from previous patches -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24186] Examine page is visible to users without abusefilter-log-detail right
https://bugzilla.wikimedia.org/show_bug.cgi?id=24186 lampak llam...@gmail.com changed: What|Removed |Added Attachment #7537|0 |1 is obsolete|| Attachment #7538|0 |1 is obsolete|| Attachment #7540|0 |1 is obsolete|| Attachment #7539|0 |1 is obsolete|| --- Comment #4 from lampak llam...@gmail.com 2010-07-01 09:33:15 UTC --- Created an attachment (id=7538) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7538) patch no. 2 Small quick fix of one line. I'm not sure it's much better but I'm hurrying a bit (because of real-life reasons). --- Comment #5 from lampak llam...@gmail.com 2010-07-01 10:55:43 UTC --- The patch doesn't work! Sorry for the mess. --- Comment #6 from lampak llam...@gmail.com 2010-07-01 11:07:07 UTC --- Created an attachment (id=7539) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7539) patch no. 3 --- Comment #7 from lampak llam...@gmail.com 2010-07-01 11:15:12 UTC --- Created an attachment (id=7540) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7540) patch no. 3 with extra modifications from previous patches Ok, this one should work. In this version it turns out I don't use that canSeeDetails so there's no need to move these functions. But I don't think it was a bad idea anyway so you here have two versions of a patch for you to decide. Sorry for the mess and confusion and everything. This is what happens when you try to do something quickly :/ --- Comment #8 from lampak llam...@gmail.com 2010-07-01 11:22:26 UTC --- Created an attachment (id=7541) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7541) patch no. 3a with extra modifications from previous patches --- Comment #9 from lampak llam...@gmail.com 2010-07-01 11:24:05 UTC --- Created an attachment (id=7542) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7542) patch no. 3a Just a small fix of spaces/tabs issue. That's really the end, I promise. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24186] Examine page is visible to users without abusefilter-log-detail right
https://bugzilla.wikimedia.org/show_bug.cgi?id=24186 Leinad danny.lei...@gmail.com changed: What|Removed |Added CC||danny.lei...@gmail.com --- Comment #1 from Leinad danny.lei...@gmail.com 2010-06-30 21:51:28 UTC --- It looks that examine function is available with permission abusefilter-view, but the link to the examine is not visible in [[Special:AbuseLog]] when permission abusefilter-log-detail is false. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24186] Examine page is visible to users without abusefilter-log-detail right
https://bugzilla.wikimedia.org/show_bug.cgi?id=24186 --- Comment #2 from lampak llam...@gmail.com 2010-06-30 22:31:58 UTC --- So probably the most sensible solution would be to make examine pages visible to those with abusefilter-log-detail instead. As far as I know, abusefilter-view should be for accessing the *code* of public filters, like this one: [[Special:AbuseFilter/33]] -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24186] Examine page is visible to users without abusefilter-log-detail right
https://bugzilla.wikimedia.org/show_bug.cgi?id=24186 --- Comment #3 from lampak llam...@gmail.com 2010-07-01 00:57:47 UTC --- Created an attachment (id=7537) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7537) patch OK, I've written a patch. Now it should check for the abusefilter-log-detail right before displaying the examine page. Besides fixing the bug, I've moved all functions which check user's rights to AbuseFilter class to make them somewhat more global - because I needed canSeeDetails and because canViewPrivate had already been duplicated by canSeePrivate. I have some some small problems with MediaWiki configuration so I'm not quite sure how the patch is going to behave in a less messy environment... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
