[Bug 24248] Vector skin search Go button uses fulltext search button tooltip
https://bugzilla.wikimedia.org/show_bug.cgi?id=24248 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED Target Milestone|--- |1.23.0 release -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24248] Vector skin search Go button uses fulltext search button tooltip
https://bugzilla.wikimedia.org/show_bug.cgi?id=24248 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 82100 merged by jenkins-bot: Rewrite rendering of Vector simple search https://gerrit.wikimedia.org/r/82100 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24248] Vector skin search Go button uses fulltext search button tooltip
https://bugzilla.wikimedia.org/show_bug.cgi?id=24248 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Target Milestone|1.22.0 release |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24248] Vector skin search Go button uses fulltext search button tooltip
https://bugzilla.wikimedia.org/show_bug.cgi?id=24248 --- Comment #7 from Andre Klapper aklap...@wikimedia.org --- https://gerrit.wikimedia.org/r/#/c/82100/ has received one +1. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24248] Vector skin search Go button uses fulltext search button tooltip
https://bugzilla.wikimedia.org/show_bug.cgi?id=24248 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24248] Vector skin search Go button uses fulltext search button tooltip
https://bugzilla.wikimedia.org/show_bug.cgi?id=24248 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 82100 had a related patch set uploaded by Matmarex: Rewrite rendering of Vector simple search https://gerrit.wikimedia.org/r/82100 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24248] Vector skin search Go button uses fulltext search button tooltip
https://bugzilla.wikimedia.org/show_bug.cgi?id=24248 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added CC||matma@gmail.com Assignee|wikibugs-l@lists.wikimedia. |matma@gmail.com |org | Target Milestone|--- |1.22.0 release -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24248] Vector skin search Go button uses fulltext search button tooltip
https://bugzilla.wikimedia.org/show_bug.cgi?id=24248 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Blocks||44881 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24248] Vector skin search Go button uses fulltext search button tooltip
https://bugzilla.wikimedia.org/show_bug.cgi?id=24248
--- Comment #5 from Lejonel lejo...@telia.com ---
Monobook and other skins can have a single 'Go' button with the same
behaviour as the search image.
Yes. I think this is because the newer image search button is behaving as the
older 'Go' button. That is why the image search button should not use the
tooltip of the fulltext search.
If image search button is always a 'Go' search, it could use the old 'Go'
tooltip ([[Mediawiki:Tooltip-search-go]]: Go to a page with this exact name if
exists). I am not sure that this is always the case, that is why I suggest
creating a new tooltip message when an image is used as button.
Another solution is to make a difference between search modes ('go' or
'fulltext') and button modes (button with text or button with image). And
letting the tooltip depend only on the search mode, not what type of button is
used.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24248] Vector skin search Go button uses fulltext search button tooltip
https://bugzilla.wikimedia.org/show_bug.cgi?id=24248 Lejonel lejo...@telia.com changed: What|Removed |Added Keywords||easy --- Comment #3 from Lejonel lejo...@telia.com --- Now there is a fulltext option in the vector search box (I don't remember if this existed when the bug was reported, but I think not since that was part of my fourth suggested solution). This fulltext option uses its own new message [[MediaWiki:Searchsuggest-containing]]. But the vector magnifying glass still uses the incorrect fulltext search tooltip from monobook skin. Now the problem seems to be that vector skin uses 'image' as $mode for makeSearchButton(), and in includes/SkinTemplate.php that function assumes wrongly that 'image' mode is always fulltext search. I think the easiest way to fix this is to create a new message (maybe [[Mediawiki:Tooltip-search-image]]) specifically for this 'image search mode', with the text Search for this text. Without mentioning if it is searching page titles or page content, since using an image as search button does not really say anything about if the search is go, fulltext, or something else completely. (marking as easy since this should not be hard to change.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24248] Vector skin search Go button uses fulltext search button tooltip
https://bugzilla.wikimedia.org/show_bug.cgi?id=24248 Daniel Friesen mediawiki-b...@nadir-seen-fire.com changed: What|Removed |Added CC||mediawiki-bugs@nadir-seen-f ||ire.com --- Comment #4 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com --- Monobook and other skins can have a single 'Go' button with the same behaviour as the search image. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24248] Vector skin search Go button uses fulltext search button tooltip
https://bugzilla.wikimedia.org/show_bug.cgi?id=24248 Thehelpfulone thehelpfulonew...@gmail.com changed: What|Removed |Added AssignedTo|amil...@wikimedia.org |wikibugs-l@lists.wikimedia. ||org --- Comment #2 from Thehelpfulone thehelpfulonew...@gmail.com 2012-06-22 19:45:10 UTC --- Reassign to default per bug 37789 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24248] Vector skin search Go button uses fulltext search button tooltip
https://bugzilla.wikimedia.org/show_bug.cgi?id=24248 Lejonel lejo...@telia.com changed: What|Removed |Added Severity|enhancement |normal --- Comment #1 from Lejonel lejo...@telia.com 2010-09-08 19:13:31 UTC --- Changing from enhancement to normal bug. Since the tooltip says it searches for page text, even though the button only search for text if there is no page title match. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24248] Vector skin search Go button uses fulltext search button tooltip
https://bugzilla.wikimedia.org/show_bug.cgi?id=24248 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||roan.katt...@gmail.com AssignedTo|tpars...@wikimedia.org |amil...@wikimedia.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
