[Bug 25463] Export header should not be shown if no pages were requested, to reduce confusion
https://bugzilla.wikimedia.org/show_bug.cgi?id=25463 --- Comment #6 from Umherirrender umherirrender_de...@web.de 2010-10-27 13:06:48 UTC --- (In reply to comment #5) I can't get this to apply cleanly on SVN Head. Not sure if it's my computer at fault Works fine for me, when apply to trunk/phase3. Maybe remove folder from Index and apply to the parent of ApiQuery.php. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25463] Export header should not be shown if no pages were requested, to reduce confusion
https://bugzilla.wikimedia.org/show_bug.cgi?id=25463 --- Comment #7 from Reedy s...@reedyboy.net 2010-10-27 13:09:53 UTC --- re...@reedy-laptop:~/mediawiki/trunk/phase3$ patch -p0 -i bug25463.patch (Stripping trailing CRs from patch.) patching file includes/api/ApiQuery.php Hunk #1 FAILED at 457. 1 out of 1 hunk FAILED -- saving rejects to file includes/api/ApiQuery.php.rej re...@reedy-laptop:~/mediawiki/trunk/phase3$ Any chance you could just run me another copy of the patch as is? I'll also try it on Windows when I get gome in a few -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25463] Export header should not be shown if no pages were requested, to reduce confusion
https://bugzilla.wikimedia.org/show_bug.cgi?id=25463 --- Comment #5 from Reedy s...@reedyboy.net 2010-10-24 18:47:08 UTC --- I can't get this to apply cleanly on SVN Head. Not sure if it's my computer at fault -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25463] Export header should not be shown if no pages were requested, to reduce confusion
https://bugzilla.wikimedia.org/show_bug.cgi?id=25463 --- Comment #4 from Umherirrender umherirrender_de...@web.de 2010-10-23 19:34:23 UTC --- Created attachment 7752 -- https://bugzilla.wikimedia.org/attachment.cgi?id=7752 no export header, when no titles to export A condition which count the titles to export is missing, I have added a condition in the attachment Feel free to modify the patch or create a new one. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25463] Export header should not be shown if no pages were requested, to reduce confusion
https://bugzilla.wikimedia.org/show_bug.cgi?id=25463 Umherirrender umherirrender_de...@web.de changed: What|Removed |Added Keywords||patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25463] Export header should not be shown if no pages were requested, to reduce confusion
https://bugzilla.wikimedia.org/show_bug.cgi?id=25463 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | Summary|list=allpagesexport shows |Export header should not be |only export header |shown if no pages were ||requested, to reduce ||confusion --- Comment #3 from Roan Kattouw roan.katt...@gmail.com 2010-10-11 11:41:13 UTC --- (In reply to comment #2) Thanks for the explanation. But is is a good idea to add the export header in this case? I do not think so, because it assume there is something wrong, and a export is possible. You're right about that one. Reopening and repurposing bug. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
