[Bug 25610] Setting a cookie to go into a RL debug mode
https://bugzilla.wikimedia.org/show_bug.cgi?id=25610 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC||krinklem...@gmail.com Version|1.16.x |1.17 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25610] Setting a cookie to go into a RL debug mode
https://bugzilla.wikimedia.org/show_bug.cgi?id=25610 Krinkle krinklem...@gmail.com changed: What|Removed |Added Blocks||35061 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25610] Setting a cookie to go into a RL debug mode
https://bugzilla.wikimedia.org/show_bug.cgi?id=25610 --- Comment #5 from Nux e...@wp.pl 2010-11-06 21:21:29 UTC --- OK, thanks :-). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25610] Setting a cookie to go into a RL debug mode
https://bugzilla.wikimedia.org/show_bug.cgi?id=25610 Nux e...@wp.pl changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #3 from Nux e...@wp.pl 2010-11-05 07:41:16 UTC --- Are you sure this is enough? The behaviour seems to differ a bit as you also read debug state on line 2410 and 2579 and you don't read from the cookie there. The cookie state is also disregarded in the __construct of ResourceLoaderContext. Maybe not a big difference now, but it seems to be a point where things can go bad in the future (where debug might mean something more). What I'm saying is debugging with a cookie and with a param is different even now and might be worse in future. This doesn't feel like an expected or intended behaviour. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25610] Setting a cookie to go into a RL debug mode
https://bugzilla.wikimedia.org/show_bug.cgi?id=25610 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #4 from Roan Kattouw roan.katt...@gmail.com 2010-11-05 20:36:38 UTC --- (In reply to comment #3) Are you sure this is enough? The behaviour seems to differ a bit as you also read debug state on line 2410 and 2579 and you don't read from the cookie there. Good point, I missed those. Fixed in r76138. The cookie state is also disregarded in the __construct of ResourceLoaderContext. Maybe not a big difference now, but it seems to be a point where things can go bad in the future (where debug might mean something more). What I'm saying is debugging with a cookie and with a param is different even now and might be worse in future. This doesn't feel like an expected or intended behaviour. This is actually not a problem. All the debug cookie and the debug param when applied to *index.php* do is make OutputPage.php generate links to load.php with debug=true instead of debug=false. load.php itself never needs to read the cookie for this reason (and if it did, that would violate cacheability). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25610] Setting a cookie to go into a RL debug mode
https://bugzilla.wikimedia.org/show_bug.cgi?id=25610 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Roan Kattouw roan.katt...@gmail.com 2010-11-01 20:38:24 UTC --- Implemented in r75825. Cookie name is resourceLoaderDebug. Setting it to or 0 disables debug mode, any other value enables debug mode. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25610] Setting a cookie to go into a RL debug mode
https://bugzilla.wikimedia.org/show_bug.cgi?id=25610 Brion Vibber br...@pobox.com changed: What|Removed |Added CC||br...@pobox.com --- Comment #1 from Brion Vibber br...@pobox.com 2010-10-21 23:54:25 UTC --- If making a bookmarklet to turn the cookie on, be sure to have one to turn it off too! ;) Actually this'd be handy in a little 'developer goodies' gadget. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
