[Bug 25800] wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a action parameter

2012-01-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25800

Bug 25800 depends on bug 27930, which changed state.

Bug 27930 Summary: Ablity to get current action (The Right Way)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27930

   What|Old Value   |New Value

 Status|NEW |RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25800] wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a action parameter

2012-01-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25800

--- Comment #9 from Krinkle krinklem...@gmail.com 2012-01-08 00:44:36 UTC ---
Now that bug 27930 is resolved. We can fix this bug by using
MediaWiki::getAction() instead of looking at the URL directly and doing all
sorts of nasty things (e.g. action=yadadadad shouldn't result in wgAction:
yadadadad.).

See also bug 33587.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25800] wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a action parameter

2012-01-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25800

Bug 25800 depends on bug 27930, which changed state.

Bug 27930 Summary: Ablity to get current action (The Right Way)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27930

   What|Old Value   |New Value

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25800] wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a action parameter

2012-01-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25800

Bug 25800 depends on bug 27930, which changed state.

Bug 27930 Summary: Ablity to get current action (The Right Way)
https://bugzilla.wikimedia.org/show_bug.cgi?id=27930

   What|Old Value   |New Value

 Status|REOPENED|RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25800] wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a action parameter

2012-01-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25800

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED
 AssignedTo|wikibugs-l@lists.wikimedia. |krinklem...@gmail.com
   |org |
   Target Milestone|--- |1.19.0 release

--- Comment #10 from Krinkle krinklem...@gmail.com 2012-01-08 01:36:15 UTC ---
Done in r108343.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25800] wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a action parameter

2011-07-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25800

--- Comment #8 from DieBuche diebu...@gmail.com 2011-07-12 12:39:50 UTC ---
(In reply to comment #7)
 (Note that the millions of direct diff links all over the site have *never*
 included action=historysubmit, and they shouldn't.

That they included  action=historysubmit in the diff selection is actually a
sideefffect of r57415

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25800] wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a action parameter

2011-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25800

DieBuche diebu...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||diebu...@gmail.com
 Resolution||FIXED

--- Comment #2 from DieBuche diebu...@gmail.com 2011-07-11 10:54:25 UTC ---
r91870

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25800] wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a action parameter

2011-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25800

Brion Vibber br...@wikimedia.org changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #3 from Brion Vibber br...@wikimedia.org 2011-07-11 23:37:26 UTC 
---
This seems pretty wrong... you *should* generally have 'view' as the action on
a diff page, as it's a *page view* with some specialized additions (a
particular version, some diffs at the top).

By default, old revision  diff views both show a full page rendering, and have
some extra UI at top. Neither is expected to change the action away from
'view'.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25800] wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a action parameter

2011-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25800

--- Comment #4 from Brion Vibber br...@wikimedia.org 2011-07-11 23:42:37 UTC 
---
Reverted in r91927.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25800] wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a action parameter

2011-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25800

--- Comment #5 from DieBuche diebu...@gmail.com 2011-07-11 23:49:43 UTC ---
http://en.wikipedia.org/w/index.php?title=Foobaraction=historysubmitdiff=437783052oldid=437205393

and

http://en.wikipedia.org/w/index.php?title=Foobardiff=437783052oldid=437205393

both output *exactly* the same page.  Why is one action=view and the other
action=historysubmit?

(In reply to comment #3)
 This seems pretty wrong... you *should* generally have 'view' as the action on
 a diff page, as it's a *page view* 
Then why's there an action historysubmit?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25800] wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a action parameter

2011-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25800

--- Comment #6 from Brion Vibber br...@wikimedia.org 2011-07-11 23:57:27 UTC 
---
action=historysubmit is for submitting the history form.

Note that there are at least two distinct things available in that form right
now:
* diff selection (which really just points you off to a view)
* selection of revs for show/hide/revdel

I think both of these should redirect you to consistent GET  action=view URLs,
for the page w/ diff view or Special:RevisionDelete respectively.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25800] wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a action parameter

2011-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25800

--- Comment #7 from Brion Vibber br...@wikimedia.org 2011-07-11 23:58:00 UTC 
---
(Note that the millions of direct diff links all over the site have *never*
included action=historysubmit, and they shouldn't.)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25800] wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a action parameter

2011-03-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25800

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 Depends on||27930

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 25800] wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a action parameter

2010-12-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=25800

--- Comment #1 from Krinkle krinklem...@gmail.com 2011-01-01 02:05:33 UTC ---
*** Bug 26528 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l