[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

--- Comment #15 from jida...@jidanni.org 2011-02-26 10:40:07 UTC ---
Created attachment 8215
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=8215
hard to understand

I still say this is very hard to understand. Especially when done for more than
one site. Perhaps a header could be added saying what the columns mean or
something.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

Chad H.  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #14 from Chad H.  2011-02-14 17:02:02 UTC 
---
Done in r82115.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

--- Comment #13 from Chad H.  2011-02-10 18:42:22 UTC 
---
Because $wgSitemapNamespaces isn't sorted, and I put them in my list in a
semi-random order.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

--- Comment #12 from jida...@jidanni.org 2011-02-10 18:41:50 UTC ---
Why is it 0 2 14 3, and not 0 2 3 14?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

--- Comment #11 from Reedy  2011-02-10 18:26:03 UTC ---
Chad, that looks a reasonably sane way of outputting it...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

--- Comment #10 from Chad H.  2011-02-10 18:20:37 UTC 
---
What if we formatted the output like this (have local patch, looks ok to me)

maintenance chad$ php generateSitemap.php
0 ()
/www/maintenance/sitemap-wikidb-mw_-NS_0-0.xml.gz
2 (User)
/www/phase3/maintenance/sitemap-wikidb-mw_-NS_2-0.xml.gz
14 (Category)
3 (User talk)
/www/phase3/maintenance/sitemap-wikidb-mw_-NS_3-0.xml.gz
maintenance chad$

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

--- Comment #9 from jida...@jidanni.org 2011-02-10 18:13:21 UTC ---
It's ok that no path is printed. It is not OK that no newline is printed.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

--- Comment #8 from jida...@jidanni.org 2011-02-10 18:11:28 UTC ---
Fill up your $wgSitemapNamespaces=array(NS_MAIN,NS_PROJECT... with lots of
never uses namespaces, then run generateSitemap.php, and post what you get.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

Reedy  changed:

   What|Removed |Added

   Attachment #8121|0   |1
is obsolete||

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

--- Comment #7 from Reedy  2011-02-10 17:34:53 UTC ---
If you can tell me how to replicate the lack of a path being printed, i can try
and help more

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

--- Comment #6 from jida...@jidanni.org 2011-02-10 17:09:58 UTC ---
Now it's
$ php generateSitemap.php 
0 ()/home/jidanni/mediawiki/maintenance/sitemap-transgender-NS_0-0.xml.gz









4 (蝶園)01:08 maintenance$

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

--- Comment #5 from Reedy  2011-02-10 16:29:55 UTC ---
Created attachment 8121
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=8121
add newline

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

--- Comment #4 from Reedy  2011-02-10 16:29:39 UTC ---
Ok, I can see that.

I'm just trying to replicate it. If I just add a new namespace, it doesn't
generate a sitemap for it.

And just does the ones that do.

Have you done anything else to get it to appear there? Set it as a content
namespace or anything?

Seemingly, the fix is
Change
$this->output( "\t$this->fspath$filename\n" );
to
$this->output( "\t$this->fspath$filename" );


And then add

$this->output( "\n" );

after the if.

I'll attach a patch, can you confirm if this fixes your issue?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

--- Comment #3 from jida...@jidanni.org 2011-02-10 15:24:14 UTC ---
I dare not look at any more code, but instead just prove it to you again:
22:46 ~$ cd transgender-taiwan.org/maintenance/
22:46 maintenance$ php generateSitemap.php 
0 ()/home/jidanni/mediawiki/maintenance/sitemap-transgender-NS_0-0.xml.gz
4 (蝶園)22:46 maintenance$ 
Note^the neglected newline?
That's because my namespace 4 just happens to have 0 articles on my wiki.

So try again with an unpopulated namespace or two added to the list of
candidates.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

Reedy  changed:

   What|Removed |Added

 CC||s...@reedyboy.net

--- Comment #2 from Reedy  2011-02-10 02:14:25 UTC ---
reedy@ubuntu64-esxi:~/mediawiki/trunk/phase3/maintenance$ php
generateSitemap.php
0 ()   
/home/reedy/mediawiki/trunk/phase3/maintenance/sitemap-wikidb-mw_-NS_0-0.xml.gz
2 (User)   
/home/reedy/mediawiki/trunk/phase3/maintenance/sitemap-wikidb-mw_-NS_2-0.xml.gz
6 (File)   
/home/reedy/mediawiki/trunk/phase3/maintenance/sitemap-wikidb-mw_-NS_6-0.xml.gz
14 (Category)  
/home/reedy/mediawiki/trunk/phase3/maintenance/sitemap-wikidb-mw_-NS_14-0.xml.gz




I'm failing to see an issue here? Please elabourate more

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26134] generateSitemap.php neglects newlines for unpopulated namespaces

2011-02-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26134

Mark A. Hershberger  changed:

   What|Removed |Added

   Priority|Normal  |Low
 CC||m...@everybody.org

--- Comment #1 from Mark A. Hershberger  2011-02-10 
01:39:41 UTC ---
Care to provide a patch if, and I do believe your tag, this is easy?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l