[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #46 from Codicorumus bugoru...@gmail.com --- (In reply to Bartosz Dziewoński from comment #44) (In reply to Codicorumus from comment #39) Adding also $geshi-set_overall_style( ' font-family: monospace, monospace;', /** preserve defaults */ true ); will complete the fix, as I can see. Let's try this, then. Can you test the patch I just submitted? Sorry for the late reply. I hoped to set a MediaWiki instance suitable for testing and then time lapsed with nothing done. At the moment I still can't do proper testing. But -- as I can see -- the fix is already online and well working. Checked with Firefox_29 and Chrome_35, both with source tags and pages based on ContentModel, also both in MediaWiki 1.24wmf6 (it.wikipedia.org) and MediaWiki 1.24wmf7 (www.mediawiki.org). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #45 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 131406 merged by jenkins-bot: Make sure font size in GeSHi output is not too small https://gerrit.wikimedia.org/r/131406 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Krinkle krinklem...@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED Assignee|wikibugs-l@lists.wikimedia. |krinklem...@gmail.com |org | Target Milestone|MW 1.20 version |MW 1.24 version -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Bug 26204 depends on bug 35017, which changed state. Bug 35017 Summary: Port SyntaxHighlight-Geshi to ResourceLoader https://bugzilla.wikimedia.org/show_bug.cgi?id=35017 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #43 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 131406 had a related patch set uploaded by Bartosz Dziewoński: Make sure font size in GeSHi output is not too small https://gerrit.wikimedia.org/r/131406 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #44 from Bartosz Dziewoński matma@gmail.com --- (In reply to Codicorumus from comment #39) Adding also $geshi-set_overall_style( ' font-family: monospace, monospace;', /** preserve defaults */ true ); will complete the fix, as I can see. Let's try this, then. Can you test the patch I just submitted? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Erwin Dokter er...@darcoury.nl changed: What|Removed |Added CC||gsm...@solcon.nl --- Comment #42 from Erwin Dokter er...@darcoury.nl --- *** Bug 23708 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Keywords|patch-in-gerrit | Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Antoine hashar Musso has...@free.fr changed: What|Removed |Added Assignee|has...@free.fr |wikibugs-l@lists.wikimedia. ||org --- Comment #41 from Antoine hashar Musso has...@free.fr --- Unassigning self, I got too many bugs right now. Will revisit later on. Firefox indeed needs a different solution :( -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204
Codicorumus bugoru...@gmail.com changed:
What|Removed |Added
CC||bugoru...@gmail.com
--- Comment #39 from Codicorumus bugoru...@gmail.com ---
Please, consider reopening this bug.
At least in Firefox_19 and Chrome_25, https://gerrit.wikimedia.org/r/48882
seems to me not working.
As I can see, the CSS rule affected by the patch is one of those created by
$css[] = $geshi-get_stylesheet( false );
but amongst those there is also, for instance,
.javascript.source-javascript {font-family:monospace;}
which seems to need the same fix.
Adding also
$geshi-set_overall_style( ' font-family: monospace, monospace;',
/** preserve defaults */ true );
will complete the fix, as I can see.
--
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #40 from Codicorumus bugoru...@gmail.com --- To be more precise : - in Chrome, the current patch - works for lt;source%gt; tags - doesn't work for pages like [[w:MediaWiki:Common.js]], based on content-model - in Firefox, it doesn't work in both cases -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Helder mybugs.m...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED CC||matma@gmail.com Resolution|--- |FIXED --- Comment #38 from Bartosz Dziewoński matma@gmail.com --- Merged - marking as fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Antoine hashar Musso has...@free.fr changed: What|Removed |Added Priority|Normal |Low -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Antoine hashar Musso has...@free.fr changed: What|Removed |Added Keywords|patch, patch-reviewed |patch-in-gerrit Status|REOPENED|ASSIGNED CC||has...@free.fr Assignee|soxre...@gmail.com |has...@free.fr --- Comment #37 from Antoine hashar Musso has...@free.fr --- Possible fix with https://gerrit.wikimedia.org/r/48882 , this time by having our extension append a style hack to the default Geshi one. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #36 from Krinkle krinklem...@gmail.com 2012-08-28 22:36:30 UTC --- The font-size itself is not the issue. Sure one can keep incrementing it but that's a work-around. The font-size is correct. The problem is the font-family that is being overidden by Geshi with a bad font instead of Courier New. inline geshi: font-family: monospace; .mw-code: font-family: monospace,Courier; All we need to do is make geshi not output that inline style. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Marcin Cieślak marcin.cies...@gmail.com changed: What|Removed |Added CC||marcin.cies...@gmail.com --- Comment #35 from Marcin Cieślak marcin.cies...@gmail.com 2012-07-17 11:35:21 UTC --- Can you try I Gerrit change 15781 and see if it helps? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 JuanPi ajua...@gmail.com changed: What|Removed |Added CC||ajua...@gmail.com --- Comment #34 from JuanPi ajua...@gmail.com 2012-06-27 11:44:42 UTC --- I can correct the font size using syntaxhighlight style=font-size:13px doesn't that work? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Krinkle krinklem...@gmail.com changed: What|Removed |Added Target Milestone|1.20wmf deployment |1.20.0 release -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Krinkle krinklem...@gmail.com changed: What|Removed |Added Target Milestone|1.20.0 release |1.20 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Krinkle krinklem...@gmail.com changed: What|Removed |Added Depends on||35017 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #33 from Krinkle krinklem...@gmail.com 2012-03-06 23:18:43 UTC --- (In reply to comment #32) #2: Create modules for the Geshi highlighting, so they can be treated as normal citizens in RL :) Created bug 35017 for that. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Krinkle krinklem...@gmail.com changed: What|Removed |Added Target Milestone|--- |1.20wmf deployment -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #32 from Krinkle krinklem...@gmail.com 2012-01-11 16:56:39 UTC --- (In reply to comment #31) (In reply to comment #28) This loading order is simply wrong. We should let the output become a module and actually make it use ResourceLoader. That'll slim the page weight, be better cacheable, and solves the order problem. That entails a lot of work. The CSS is injected by geshi.php, and does so dynamically depending on what highlighting is required. The entire CSS collection for all languages GeSHi supports is over 100KB. I'm thinking of modules like ext.geshi.highlight.javascript, ext.geshi.highlight.php etc. I didn't mean moving Geshi.css to the top. I meant, if there is no stylesheet to put this style in, we can create a _new_ module with a new stylesheet and put that in there and load it in the top. This would also require that GeSHi write a temporary (cachable?) CSS file which is then served by RL. CSS and JS doesn't have to be read from a static file for ResourceLoader to do it's caching and loading logic. It can be dynamically generated and concatenated from anywhere. By having them as modules they'll load faster (since they'd be minified, combined and potentially cached from one page to another and reducing raw html pay load). (Re: multiple loading of Geshi.css) Just look at the source of [[MediaWiki talk:Common.css]] to see what I mean. I see nothing obvious on that wiki page, can you be more specific ? Sorry, I meant the HTML source. Each lang option creates an entire block of CSS, each with a call to mediawiki:geshi.css attached. OK Created attachment 9827 [details] Patch for extensions/SyntaxHighlight_GeSHi/geshi/geshi.php Is that one of the GeSHi files that's linked via an SVN external? That is, is it part of GeSHi core? If so we'll need to upstream it. Yup. I made this patch specifically for MediaWiki, since it's default skin uses a smaller-then-default font size. Other software using GeSHi might also benefit, but *may* end up with a too large font if they use the default font size. The sanest thing to do fo GeSHi is actually to remove the font-family declaration all together, since pre and code would already display in a monospace font. Sounds good. So I see two tasks, the latter of which I'll assign to myself to research (not execute yet): #1: Get upstream fixed #2: Create modules for the Geshi highlighting, so they can be treated as normal citizens in RL :) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Krinkle krinklem...@gmail.com changed: What|Removed |Added Summary|fontsize in source too|font-size of |small |syntaxhighlight output ||too small -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords||need-review, patch CC||suma...@panix.com --- Comment #29 from Sumana Harihareswara suma...@panix.com 2012-01-09 20:38:12 UTC --- (In reply to comment #27) Can you summarise why it has the effect that it does? Erwin, I'm marking this patch need-review but please do respond to this. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 Krinkle krinklem...@gmail.com changed: What|Removed |Added Keywords|need-review |reviewed -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #30 from Krinkle krinklem...@gmail.com 2012-01-09 20:40:32 UTC --- Patch looks good. However we'll have to get it through upstream. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26204] font-size of syntaxhighlight output too small
https://bugzilla.wikimedia.org/show_bug.cgi?id=26204 --- Comment #31 from Erwin Dokter er...@darcoury.nl 2012-01-09 21:57:08 UTC --- (In reply to comment #28) Wrong rev link ? No, that is the proper one, but a link to the bug might be more prudent: bug 33496. This loading order is simply wrong. We should let the output become a module and actually make it use ResourceLoader. That'll slim the page weight, be better cacheable, and solves the order problem. That entails a lot of work. The CSS is injected by geshi.php, and does so dynamically depending on what highlighting is required. The entire CSS collection for all languages GeSHi supports is over 100KB. I didn't mean moving Geshi.css to the top. I meant, if there is no stylesheet to put this style in, we can create a _new_ module with a new stylesheet and put that in there and load it in the top. This would also require that GeSHi write a temporary (cachable?) CSS file which is then served by RL. (Re: multiple loading of Geshi.css) Just look at the source of [[MediaWiki talk:Common.css]] to see what I mean. I see nothing obvious on that wiki page, can you be more specific ? Sorry, I meant the HTML source. Each lang option creates an entire block of CSS, each with a call to mediawiki:geshi.css attached. Created attachment 9827 [details] Patch for extensions/SyntaxHighlight_GeSHi/geshi/geshi.php Is that one of the GeSHi files that's linked via an SVN external? That is, is it part of GeSHi core? If so we'll need to upstream it. Yup. I made this patch specifically for MediaWiki, since it's default skin uses a smaller-then-default font size. Other software using GeSHi might also benefit, but *may* end up with a too large font if they use the default font size. The sanest thing to do fo GeSHi is actually to remove the font-family declaration all together, since pre and code would already display in a monospace font. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
