[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 --- Comment #19 from Sumana Harihareswara suma...@panix.com 2012-05-23 19:36:35 UTC --- Erwin, I'm sorry for the wait. Your patch will get reviewed faster if you submit it as a Git branch via Gerrit - https://www.mediawiki.org/wiki/Developer_access . Thanks. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords||need-review, patch --- Comment #18 from Sumana Harihareswara suma...@panix.com 2011-11-22 20:03:05 UTC --- Thanks for the patch, Erwin. Added the patch need-review keywords to indicate that your new patch awaits code review. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Attachment #8769|0 |1 is obsolete|| --- Comment #15 from Sumana Harihareswara suma...@panix.com 2011-11-21 10:34:47 UTC --- Comment on attachment 8769 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8769 Patch for monobook/screen.css Patch no longer applies to trunk, so marking obsolete (checked by Rusty per http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056340.html ). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords|need-review, patch | CC||suma...@panix.com --- Comment #16 from Sumana Harihareswara suma...@panix.com 2011-11-21 10:36:23 UTC --- Erwin, if you'd like to revise your patch to work with the current codebase, that would be welcome; if you'd like suggestions or discussion, please chat with other MediaWiki developers in #mediawiki on Freenode IRC. Thanks! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 --- Comment #17 from Erwin Dokter er...@darcoury.nl 2011-11-21 11:28:54 UTC --- Created attachment 9508 -- https://bugzilla.wikimedia.org/attachment.cgi?id=9508 Patch for vector/screen.css Fontsize 150%, margin 5px. The img align was already in trunk. (I also misnamed the previous patch, it was of course ment for Vector.) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 --- Comment #12 from DieBuche diebu...@gmail.com 2011-07-11 09:23:49 UTC --- (In reply to comment #10) and you left out the 5px margin, making the text stick too close to the image. The arrow leads from the article title to the redirect text. It's not an arrow standing besides unrelated text, where separation would be useful. ( at least use margin-left, since this it what you want to change) Brion also said there was nothing wrong with 150%. Comment #6: the smaller font size seems a smidge too small maybe but the larger one is a smidge too large IMO. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 --- Comment #13 from Erwin Dokter er...@darcoury.nl 2011-07-11 10:55:38 UTC --- I just followed the monobook desing; it has a 5px margin on all sides to seperate *any* text from the arrow (yes, there can be other text on a redirect page). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 DieBuche diebu...@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED CC||diebu...@gmail.com Resolution||FIXED --- Comment #9 from DieBuche diebu...@gmail.com 2011-07-10 13:20:05 UTC --- I agree with Brion that 150% is a bit over the top; I went with 140% in r91831 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 Erwin Dokter er...@darcoury.nl changed: What|Removed |Added Attachment #8552|0 |1 is obsolete|| --- Comment #10 from Erwin Dokter er...@darcoury.nl 2011-07-10 20:30:44 UTC --- Created attachment 8768 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8768 Patch for monobook/screen.css Two thing: 140% does not match with the arrow symbol, and you left out the 5px margin, making the text stick too close to the image. Brion also said there was nothing wrong with 150%. So please don't make unilateral changes to the patch. I've attached a new patch. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 Erwin Dokter er...@darcoury.nl changed: What|Removed |Added Attachment #8768|0 |1 is obsolete|| --- Comment #11 from Erwin Dokter er...@darcoury.nl 2011-07-10 20:38:55 UTC --- Created attachment 8769 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8769 Patch for monobook/screen.css Fix patch file. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 Erwin Dokter er...@darcoury.nl changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Keywords|triage | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544
--- Comment #8 from Erwin Dokter er...@darcoury.nl 2011-05-24 08:53:34 UTC ---
The 150% in Monobook is the size of H2 headers, which matches with the arrow
symbol size. I tried a H3 equevalent, which is 132% (and bolded), but I found
that a little too small and bold. I want to fix the alignment anyway by adding
the following rule to the patch:
div.redirectMsg img {
vertical-align: text-bottom;
}
So once we agree on the size, I'll update the patch.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 Brion Vibber br...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #3 from Erwin Dokter er...@darcoury.nl 2011-05-23 01:01:07 UTC --- The links are now too *small* in Vector, making them easy to overlook (IMO). I did 'fix' it in enwiki's vector.css, so they show correct there. --- Comment #4 from Brion Vibber br...@wikimedia.org 2011-05-23 23:37:20 UTC --- http://en.wikipedia.org/wiki/Foo?redirect=nouseskin=monobook http://en.wikipedia.org/wiki/Foo?redirect=nouseskin=vector They look fine to me either way. INVALID? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 Chad H. innocentkil...@gmail.com changed: What|Removed |Added CC||innocentkil...@gmail.com --- Comment #5 from Chad H. innocentkil...@gmail.com 2011-05-23 23:38:39 UTC --- (In reply to comment #4) They look fine to me either way. INVALID? Umm... (In reply to comment #3) The links are now too *small* in Vector, making them easy to overlook (IMO). I did 'fix' it in enwiki's vector.css, so they show correct there. Maybe because of this ;-) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 Brion Vibber br...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Comment #6 from Brion Vibber br...@wikimedia.org 2011-05-23 23:41:57 UTC --- G... hiding a bug and then not providing descriptions or screenshots for anybody to test doesn't help. :) Here's another site: http://fr.wikipedia.org/wiki/Foo?redirect=nouseskin=vector http://fr.wikipedia.org/wiki/Foo?redirect=nouseskin=monobook Vector is visibly smaller here -- the exact same size as body text -- whereas MonoBook bumps the font size up a bit. Still not particularly bad either way; the smaller font size seems a smidge too small maybe but the larger one is a smidge too large IMO. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 Krinkle krinklem...@gmail.com changed: What|Removed |Added Keywords||triage CC||krinklem...@gmail.com Version|1.17|1.18 --- Comment #2 from Krinkle krinklem...@gmail.com 2011-05-22 22:33:28 UTC --- Trevor: Was this a design/usability choise (having .redirectText not be small, too many font-size variations on a page, perhaps potentially unreadable) or was it forgotten and is it now too big in Vector / attracting too much attention maybe ? I can see logic in both. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 Erwin Dokter er...@darcoury.nl changed: What|Removed |Added Keywords||need-review, patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26544] Missing CSS for .redirectText
https://bugzilla.wikimedia.org/show_bug.cgi?id=26544 Erwin Dokter er...@darcoury.nl changed: What|Removed |Added Severity|enhancement |minor -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
