[Bug 26555] Styles for a skin added with $out-addStyle() are loaded after instead of before user custom styles.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26555 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC|krinklem...@gmail.com | AssignedTo|roan.katt...@gmail.com |tpars...@wikimedia.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26555] Styles for a skin added with $out-addStyle() are loaded after instead of before user custom styles.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26555 --- Comment #3 from Roan Kattouw roan.katt...@gmail.com 2011-01-06 16:35:09 UTC --- *** Bug 26570 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26555] Styles for a skin added with $out-addStyle() are loaded after instead of before user custom styles.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26555 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #4 from Roan Kattouw roan.katt...@gmail.com 2011-01-06 17:05:01 UTC --- Fixed in r79732. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26555] Styles for a skin added with $out-addStyle() are loaded after instead of before user custom styles.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26555 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|tpars...@wikimedia.org |roan.katt...@gmail.com --- Comment #2 from Roan Kattouw roan.katt...@gmail.com 2011-01-04 16:58:05 UTC --- (In reply to comment #1) Here, ResourceLoader is adding its style links in getHeadLinks(), while style links added via addStyle() are output in buildCssLinks(). To fix this issue, either a) the ResourceLoader code could be pulled out of getHeadLinks() into a separate method, b) the call to buildCssLinks() could be moved before getHeadLinks(), or c) the call to buildCssLinks() could be moved _inside_ getHeadLinks(). Not being very familiar with ResourceLoader, I have no idea which of these would be the cleanest solution, or the least likely to cause unexpected side effects. Trevor tried to move the RL stuff into buildCssLinks() but that didn't work too well. I'll poke at this later. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26555] Styles for a skin added with $out-addStyle() are loaded after instead of before user custom styles.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26555 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC||krinklem...@gmail.com Severity|enhancement |major -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26555] Styles for a skin added with $out-addStyle() are loaded after instead of before user custom styles.
https://bugzilla.wikimedia.org/show_bug.cgi?id=26555 Ilmari Karonen nos...@vyznev.net changed: What|Removed |Added CC||nos...@vyznev.net --- Comment #1 from Ilmari Karonen nos...@vyznev.net 2011-01-03 21:24:29 UTC --- I _think_ the problem is caused by OutputPage::headElement() doing $ret .= implode( \n, array( $this-getHeadLinks( $sk ), $this-buildCssLinks(), $this-getHeadItems(), ) ); Here, ResourceLoader is adding its style links in getHeadLinks(), while style links added via addStyle() are output in buildCssLinks(). To fix this issue, either a) the ResourceLoader code could be pulled out of getHeadLinks() into a separate method, b) the call to buildCssLinks() could be moved before getHeadLinks(), or c) the call to buildCssLinks() could be moved _inside_ getHeadLinks(). Not being very familiar with ResourceLoader, I have no idea which of these would be the cleanest solution, or the least likely to cause unexpected side effects. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
