[Bug 26805] ResourceLoaderStartUpModule.php extendability
https://bugzilla.wikimedia.org/show_bug.cgi?id=26805 --- Comment #7 from Roan Kattouw roan.katt...@gmail.com 2011-03-05 20:58:59 UTC --- (In reply to comment #6) Created attachment 8243 [details] updated patch with hooks documentation Added hook documentation in updated patch. Looks good now, except that module scripts in the hook documentation (last two words) should be loader scripts. Feel free to commit after changing that. Roan I still see round( max( on line 169 of ResourceLoaderStartUpModule as of version r82575 Right, I apparently forgot to take that instance out. I will remove the round() call some time after you commit. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26805] ResourceLoaderStartUpModule.php extendability
https://bugzilla.wikimedia.org/show_bug.cgi?id=26805
--- Comment #4 from Roan Kattouw roan.katt...@gmail.com 2011-03-04 10:51:31
UTC ---
(In reply to comment #1)
Created attachment 8114 [details]
small patch to add hook to startup module to extend set of modules loaded at
startup
* BEWARE: the round() call in the 'version' = setting has been removed, so
this patch won't apply cleanly. Take care to resolve the conflict in a way that
doesn't reintroduce the round() call
* foreach( $modules as $moduleName){ doesn't conform to whitespace conventions
OK otherwise
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26805] ResourceLoaderStartUpModule.php extendability
https://bugzilla.wikimedia.org/show_bug.cgi?id=26805 --- Comment #5 from Roan Kattouw roan.katt...@gmail.com 2011-03-04 10:55:14 UTC --- (In reply to comment #4) OK otherwise Two more things: * The hook should be documented in docs/hooks.txt * These docs should mention that this feature is to be used sparingly and for lightweight modules, as modules added through this hook will *always* be loaded, unconditionally (well except for people using ancient browsers) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26805] ResourceLoaderStartUpModule.php extendability
https://bugzilla.wikimedia.org/show_bug.cgi?id=26805 Michael Dale d...@ucsc.edu changed: What|Removed |Added Attachment #8114|0 |1 is obsolete|| --- Comment #6 from Michael Dale d...@ucsc.edu 2011-03-05 00:49:38 UTC --- Created attachment 8243 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8243 updated patch with hooks documentation Added hook documentation in updated patch. Roan I still see round( max( on line 169 of ResourceLoaderStartUpModule as of version r82575 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26805] ResourceLoaderStartUpModule.php extendability
https://bugzilla.wikimedia.org/show_bug.cgi?id=26805 --- Comment #2 from Roan Kattouw roan.katt...@gmail.com 2011-02-22 21:25:38 UTC --- Could you explain in more detail what this is needed for? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26805] ResourceLoaderStartUpModule.php extendability
https://bugzilla.wikimedia.org/show_bug.cgi?id=26805 --- Comment #3 from Michael Dale d...@ucsc.edu 2011-02-22 21:39:44 UTC --- This is needed for providing core functionality to module Loaders. ( There is no way to add a dependency to a loaderScripts ). When your loader Script is dependent on framework code, extending the startup modules is a way to express this dependency. You can see how its used in TimedMediaHandler extension. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26805] ResourceLoaderStartUpModule.php extendability
https://bugzilla.wikimedia.org/show_bug.cgi?id=26805 --- Comment #1 from Michael Dale d...@ucsc.edu 2011-02-09 20:20:46 UTC --- Created attachment 8114 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8114 small patch to add hook to startup module to extend set of modules loaded at startup This is needed if you want your loaderScripts to have access to any shared framework code. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
