[Bug 27265] Usage of deprecated PHP functions
https://bugzilla.wikimedia.org/show_bug.cgi?id=27265 Krinkle changed: What|Removed |Added Version|1.16|1.16.x -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27265] Usage of deprecated PHP functions
https://bugzilla.wikimedia.org/show_bug.cgi?id=27265 Krinkle changed: What|Removed |Added Version|1.16.2 |1.16 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27265] Usage of deprecated PHP functions
https://bugzilla.wikimedia.org/show_bug.cgi?id=27265 Chad H. changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #11 from Chad H. 2011-11-02 19:11:42 UTC --- And those things in includes/normal are cli scripts anyway, so they don't matter. I think we can close this FIXED. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27265] Usage of deprecated PHP functions
https://bugzilla.wikimedia.org/show_bug.cgi?id=27265 --- Comment #10 from Michiel 2011-11-02 19:05:28 UTC --- The output against svn phase3 is: // checking for 'dl()' HISTORY:418:* (bug 16902) Installer spews warnings when exec() and dl() are not available HISTORY:4023:* (bug 11013) Make sure dl() is available before attempting to use it to check includes/normal/UtfNormalMemStress.php:30:dl( 'php_utfnormal.so' ); includes/normal/UtfNormalTest.php:49:dl( 'php_utfnormal.so' ); includes/normal/UtfNormalBench.php:28:dl( 'php_utfnormal.so' ); includes/GlobalFunctions.php:2398: * Wrapper function for PHP's dl(). This doesn't work in most situations from includes/GlobalFunctions.php:2426:dl( $fileName . '.' . PHP_SHLIB_SUFFIX ); Where the GlobalFunctions.php and HISTORY hits are false positives. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27265] Usage of deprecated PHP functions
https://bugzilla.wikimedia.org/show_bug.cgi?id=27265 Max Semenik changed: What|Removed |Added CC||maxsem.w...@gmail.com --- Comment #9 from Max Semenik 2011-11-02 16:49:20 UTC --- Also: https://www.mediawiki.org/wiki/User:MaxSem/PHP_5.3_warnings -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27265] Usage of deprecated PHP functions
https://bugzilla.wikimedia.org/show_bug.cgi?id=27265 --- Comment #8 from Chad H. 2011-11-02 16:44:52 UTC --- (In reply to comment #6) > So what is it exactly that needs to be fixed to close this bug? I think the only real offender here is any code in core still calling dl() by hand, but I think we've cleaned most of that up. All the ereg's are gone too. I think if anyone finds other deprecated functions we're using they can just open a new bug. Leaving this open for any possible deprecated functions to be listed is not really necessary. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27265] Usage of deprecated PHP functions
https://bugzilla.wikimedia.org/show_bug.cgi?id=27265 Sumana Harihareswara changed: What|Removed |Added CC||suma...@panix.com --- Comment #7 from Sumana Harihareswara 2011-11-02 16:13:00 UTC --- Michiel, would you like to regenerate your list against the current codebase? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27265] Usage of deprecated PHP functions
https://bugzilla.wikimedia.org/show_bug.cgi?id=27265 Niklas Laxström changed: What|Removed |Added CC||niklas.laxst...@gmail.com --- Comment #6 from Niklas Laxström 2011-02-13 15:00:04 UTC --- So what is it exactly that needs to be fixed to close this bug? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27265] Usage of deprecated PHP functions
https://bugzilla.wikimedia.org/show_bug.cgi?id=27265 Chad H. changed: What|Removed |Added CC||innocentkil...@gmail.com --- Comment #5 from Chad H. 2011-02-09 13:23:50 UTC --- Use the wfDl() wrapper if you must use dl(). It bails if you can't use dl() (either due to deprecation or safe_mode). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27265] Usage of deprecated PHP functions
https://bugzilla.wikimedia.org/show_bug.cgi?id=27265 --- Comment #4 from Reedy 2011-02-09 10:08:18 UTC --- Though amusingly Use extension_loaded() to test whether a given extension is already available or not. This works on both built-in extensions and dynamically loaded ones (either through php.ini or dl() But never tells you how to then load them afterwards if you need to -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27265] Usage of deprecated PHP functions
https://bugzilla.wikimedia.org/show_bug.cgi?id=27265 Michiel changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #3 from Michiel 2011-02-09 07:01:19 UTC --- Please read here: http://php.net/manual/en/migration53.deprecated.php And here: http://www.php.net/manual/en/function.dl.php It says: Warning, This function has been removed from some SAPI's in PHP 5.3. The changelog for 5.3.0 states: 5.3.0 dl() is now disabled in some SAPI's due to stability issues. The only SAPI's that allow dl() are: CLI, CGI and Embed. Use the Extension Loading Directives instead. Do as you wish. I'm just the messenger. ;-) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27265] Usage of deprecated PHP functions
https://bugzilla.wikimedia.org/show_bug.cgi?id=27265 Platonides changed: What|Removed |Added Status|NEW |RESOLVED CC||platoni...@gmail.com Resolution||FIXED --- Comment #2 from Platonides 2011-02-08 22:22:29 UTC --- I disagree with dl() There is a usage for that (and note it is not marked as deprecated in www.php.net). Thanks for the list. I have added it to check-vars.php in r81784. You seem to be checking an old version. There's no longer a file includes/SpecialUpload.php It has been moved to specials folder. Other instances such as ereg or split are also fixed. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27265] Usage of deprecated PHP functions
https://bugzilla.wikimedia.org/show_bug.cgi?id=27265
--- Comment #1 from Michiel 2011-02-08 22:00:37 UTC ---
Sorry,
The real output against 1.16.2 is as follows:
// checking for 'dl()'
config/Installer.php:348: if( extension_loaded( $compname ) || (
mw_have_dl() && dl( "{$compname}." . PHP_SHLIB_SUFFIX ) ) ) {
HISTORY:2595:* (bug 11013) Make sure dl() is available before attempting to use
it to check
includes/MimeMagic.php:105: if(!extension_loaded('fileinfo'))
dl('fileinfo.' . PHP_SHLIB_SUFFIX);
includes/db/DatabaseMssql.php:71: @dl('mssql.so');
includes/db/DatabaseMysql.php:30: @dl('mysql.so');
includes/db/DatabaseIbm_db2.php:488:@dl('ibm_db2.so');
includes/diff/DifferenceInterface.php:656: dl(
'php_wikidiff.so' );
includes/diff/DifferenceInterface.php:663: dl(
'php_wikidiff2.so' );
includes/normal/UtfNormalTest.php:48: dl( 'php_utfnormal.so' );
includes/normal/UtfNormalBench.php:29: dl( 'php_utfnormal.so' );
includes/normal/CleanUpTest.php:27: dl( 'php_utfnormal.so' );
// checking for 'ereg()'
includes/db/DatabaseMssql.php:568:# if
(ereg('_id$',$keys[0])) {
includes/db/DatabaseMssql.php:577:# if
(ereg('_id$',$keys[0]) && empty($a[$keys[0]])) unset($a[$keys[0]]); # remove
primary-key column from insert list if empty value
includes/db/DatabaseMssql.php:879: return
ereg("^(.+[0-9]+\\.[0-9]+\\.[0-9]+) ",$row[0],$m) ? $m[1] : $row[0];
maintenance/fuzz-tester.php:2623:if (!ereg("(.*)" . str_replace(".",
"\.", DATA_FILE) . "$", $file, $matches)) continue;
// checking for 'ereg_replace()'
includes/db/DatabaseMssql.php:836: $sql =
ereg_replace("^SELECT", "SELECT TOP $limit", $sql);
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
