[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-19 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

Roan Kattouw  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #26 from Roan Kattouw  2011-02-19 14:58:39 
UTC ---
(In reply to comment #25)
> Right, these URLs need to be expanded to http://blah/w/index.php rather than
> just skipped. I'll fix this soon.
Fixed in r82457.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-18 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

--- Comment #25 from Roan Kattouw  2011-02-18 17:28:13 
UTC ---
(In reply to comment #24)
> (In reply to comment #23)
> > This bug is fixed now with r82000, r82156 and r82218
> 
> Unfortunately, r82218 breaks it again. All urls beginning with '/' are treated
> as absolute urls and skipped, which means the original suggestion to use
> url('/w/index.php?title=MediaWiki:Page.css') doesn't work.
Right, these URLs need to be expanded to http://blah/w/index.php rather than
just skipped. I'll fix this soon.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-16 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

Mark A. Hershberger  changed:

   What|Removed |Added

 Blocks||27339

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-16 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

Mark A. Hershberger  changed:

   What|Removed |Added

 Blocks|26611   |

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-16 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

darklama  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #24 from darklama  2011-02-16 14:26:18 UTC ---
(In reply to comment #23)
> This bug is fixed now with r82000, r82156 and r82218

Unfortunately, r82218 breaks it again. All urls beginning with '/' are treated
as absolute urls and skipped, which means the original suggestion to use
url('/w/index.php?title=MediaWiki:Page.css') doesn't work.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-15 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

Roan Kattouw  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #23 from Roan Kattouw  2011-02-16 06:31:07 
UTC ---
This bug is fixed now with r82000, r82156 and r82218

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-14 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

--- Comment #22 from darklama  2011-02-15 00:38:17 UTC ---
(In reply to comment #21)
> Let's keep the bug (fix relative paths) and the feature request (make
> url(MediaWiki:Foo) or @import MediaWiki:Foo or something similar work) 
> separate
> here. This bug is for the former, please open a new bug for the latter.

url("MediaWiki:Foo") is a relative path too, but if a separate bug is wanted I
can do that.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-14 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

--- Comment #21 from Roan Kattouw  2011-02-14 22:47:45 
UTC ---
Let's keep the bug (fix relative paths) and the feature request (make
url(MediaWiki:Foo) or @import MediaWiki:Foo or something similar work) separate
here. This bug is for the former, please open a new bug for the latter.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-14 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

--- Comment #20 from Krinkle  2011-02-14 21:55:47 UTC ---
(In reply to comment #18)
> Page names can also begin with "http://"; or "https://";.
> 
> In JavaScript loading there are importScript("MediaWiki:Page.js"); and
> importScriptURI("http://example.com/script.js";); in legacy JS libs, and in new
> JS libs loading by page name without constructing URLs manually is not
> supported (bug 27281).
> 
> For CSS loading with JavaScript there are
> importStylesheet("MediaWiki:Page.js"); and
> importStylesheetURI("http://example.com/style.css";); but it may be unfriendly
> to people with CSS support but without JavaScript support.

Importing CSS via a shorthand method without JavaScript is indeed not possible,
but please note that hit has never been possible. That's not a regression but a
feature request.

People using relative paths in import with query strings (which is fairly
rare), can simply complete the url.

ie. 


@import
url("?title=MediaWiki:Common.css/Autocount.css&action=raw&ctype=text/css")
screen;

-->

@import
url("/w/index.php?title=MediaWiki:Common.css/Autocount.css&action=raw&ctype=text/css")
screen;

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-13 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

--- Comment #19 from darklama  2011-02-13 09:56:55 UTC ---
Another option. Invent a new protocol and remap it:

url("mw://Page.css") ->
url("/w/index.php?title=Page.css&action=raw&ctype=text/css")

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

--- Comment #18 from Liangent  2011-02-12 13:31:40 UTC ---
Page names can also begin with "http://"; or "https://";.

In JavaScript loading there are importScript("MediaWiki:Page.js"); and
importScriptURI("http://example.com/script.js";); in legacy JS libs, and in new
JS libs loading by page name without constructing URLs manually is not
supported (bug 27281).

For CSS loading with JavaScript there are
importStylesheet("MediaWiki:Page.js"); and
importStylesheetURI("http://example.com/style.css";); but it may be unfriendly
to people with CSS support but without JavaScript support.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

--- Comment #17 from darklama  2011-02-12 13:04:29 UTC ---
(In reply to comment #16)
> There may be conflicts between page names and urls then I guess...

I guess you are right. Same problem likely exists with javascript loading too
though. Pages beginning with "http://"; or "https://"; would look like absolute
urls and not page/module names.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

--- Comment #16 from Liangent  2011-02-12 09:39:03 UTC ---
There may be conflicts between page names and urls then I guess...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

darklama  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #15 from darklama  2011-02-12 01:38:44 UTC ---
r82000 seems to demonstrate a problem with not doing any sanity checks. How
about enforcing some consistency with javascript loading instead by assuming
when a relative url is passed it always refers to a page name on the wiki?

E.g remap:

@import url("MediaWiki:Page 1.css");

to:

@import
url("/w/index.php?title=MediaWiki:Page_1.css&action=raw&ctype=text/css");

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

--- Comment #14 from Krinkle  2011-02-11 23:03:50 UTC ---
With this fix applied the following:

@import
url("index.php?title=MediaWiki:Common.css/WikiTable.css&action=raw&ctype=text/css")
screen;


Which first tried to access:

*
http://bits.wikimedia.org/w/index.php?title=MediaWiki:Common.css/WikiTable.css&action=raw&ctype=text/css

Willl now access:

*
/windex.php?title=MediaWiki:Common.css/WikiTable.css&action=raw&ctype=text/css

Still a 404 error.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

--- Comment #13 from Krinkle  2011-02-11 23:03:17 UTC ---
With this fix applied the following:

@import
url("?title=MediaWiki:Common.css/WikiTable.css&action=raw&ctype=text/css")
screen;


Which first tried to access:

*
http://bits.wikimedia.org/w/index.php?title=MediaWiki:Common.css/WikiTable.css&action=raw&ctype=text/css

Willl now access:

* /windex?title=MediaWiki:Common.css/WikiTable.css&action=raw&ctype=text/css

Still a 404 error.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

Trevor Parscal  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #12 from Trevor Parscal  2011-02-11 
22:57:59 UTC ---
This should be resolved in r82000.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

Mark A. Hershberger  changed:

   What|Removed |Added

 CC||m...@everybody.org
 Blocks||26611

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

--- Comment #11 from Trevor Parscal  2011-02-11 
19:32:05 UTC ---
Not that thing... The one in our codebase that I wrote.

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/libs/CSSMin.php?view=markup

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

--- Comment #10 from darklama  2011-02-11 19:24:53 UTC ---
(In reply to comment #9)
> The reason this happens if because CSSMin, the library that ResrouceLoader 
> uses
> to perform a variety of operations on CSS data does not yet support remapping
> import statements. But it should be very easy to add that since there's 
> already
> code for remapping url statements.

What version of CSSMin?
http://code.google.com/p/cssmin/source/browse/trunk/cssmin.php suggests this
may already exist as an undocumented feature that can be enabled by configuring
import-base-path.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

Trevor Parscal  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |

--- Comment #9 from Trevor Parscal  2011-02-11 18:02:54 
UTC ---
The reason this happens if because CSSMin, the library that ResrouceLoader uses
to perform a variety of operations on CSS data does not yet support remapping
import statements. But it should be very easy to add that since there's already
code for remapping url statements.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27328] using relative paths in CSS imports in MediaWiki:Common.css broken in 1.17

2011-02-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27328

Krinkle  changed:

   What|Removed |Added

 CC||krinklem...@gmail.com,
   ||roan.katt...@gmail.com
  Component|General/Unknown |Resource Loader
 AssignedTo|wikibugs-l@lists.wikimedia. |tpars...@wikimedia.org
   |org |
Summary|CSS imports in  |using relative paths in CSS
   |MediaWiki:Common.css broken |imports in
   |in 1.17 |MediaWiki:Common.css broken
   ||in 1.17

--- Comment #8 from Krinkle  2011-02-11 17:56:56 UTC ---
Adjusting summary so it can be found easier.

The bug is only happening with relative URLs. Imports in general work just
fine.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l