[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 Ryan Kaldari changed: What|Removed |Added CC||rkald...@wikimedia.org --- Comment #15 from Ryan Kaldari 2011-07-04 21:36:43 UTC --- The patch has two problems. First you can't rely on the line-height being 17px, since it's actually 1.5em. Secondly, rounding the margin gives you different div heights for even and odd pixel thumbnails. I've attempted to fix the first problem with r91427 and the second problem with r91426. Could others test and verify that this works for all cases. Thanks! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 Mark A. Hershberger changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #14 from Mark A. Hershberger 2011-02-16 23:22:24 UTC --- see r82309 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 Mark A. Hershberger changed: What|Removed |Added Blocks||27339 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 Mark A. Hershberger changed: What|Removed |Added Blocks|26611 | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 DieBuche changed: What|Removed |Added Attachment #8135|0 |1 is obsolete|| --- Comment #13 from DieBuche 2011-02-16 15:53:03 UTC --- Created attachment 8154 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8154 screenshot of rendering with patch2 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 DieBuche changed: What|Removed |Added Attachment #8152|0 |1 is obsolete|| --- Comment #12 from DieBuche 2011-02-16 15:48:34 UTC --- Created attachment 8153 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8153 Better combined patch, fixes 27458 as well -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 --- Comment #11 from DieBuche 2011-02-16 10:46:49 UTC --- Created attachment 8152 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8152 better patch Nope, this leads to the first screenshot again. Here's a better patch: Remove the css rule again, don't set a fixed height at all, but fix the margin calculation for small images -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 DieBuche changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #10 from DieBuche 2011-02-16 10:44:26 UTC --- reop -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 --- Comment #9 from Mark A. Hershberger 2011-02-16 03:41:27 UTC --- Trevor said this didn't work on older browsers, that we have to support. Could you test r82215 and see if it works for you? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 Mark A. Hershberger changed: What|Removed |Added Status|NEW |RESOLVED CC||m...@everybody.org Resolution||FIXED --- Comment #8 from Mark A. Hershberger 2011-02-15 19:41:41 UTC --- Applied in r82181 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 --- Comment #7 from DieBuche 2011-02-12 17:00:08 UTC --- If the image height is lower than the line-height, the margin-top is applied to the top of the line. a very short image will not follow for 3-4px laters, thus leading to a bigger distance from the top than it should be. vertical-align:text-top moves the picture up, so this problem doesn't happen -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 --- Comment #6 from Derk-Jan Hartman 2011-02-12 16:55:57 UTC --- Created attachment 8135 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8135 screenshot of rendering with patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 --- Comment #5 from Derk-Jan Hartman 2011-02-12 16:54:54 UTC --- ehm, mind explaining the css rule ? perhaps even with a comment ? Might be helpful if one done someone figure "what the f is this for". -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 --- Comment #4 from DieBuche 2011-02-12 16:07:04 UTC --- Created attachment 8134 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8134 Patch No, the error messages are generated seperately, see ImageGallery,php L257-L272. Here's the patch (had to create a new css rule to avoid regressing to a previous bug) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 --- Comment #3 from Derk-Jan Hartman 2011-02-12 12:47:17 UTC --- Min-height might cause the inline error messages to stretch a very larger area We should probably verify that. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 --- Comment #2 from DieBuche 2011-02-12 01:57:22 UTC --- min-heigth sounds good. I'll make a patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 Derk-Jan Hartman changed: What|Removed |Added Blocks||26611 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 27338] Gallery in 1.17 breaks for audio/video + ogghandler
https://bugzilla.wikimedia.org/show_bug.cgi?id=27338 --- Comment #1 from Derk-Jan Hartman 2011-02-11 20:45:51 UTC --- Created attachment 8128 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8128 screenshot of broken layout -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
