[Bug 27470] Upload blacklist for target names not being applied

2011-03-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

--- Comment #11 from Bryan Tong Minh bryan.tongm...@gmail.com 2011-03-22 
08:39:02 UTC ---
UploadBase::verifyPermissions() ?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied

2011-03-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

Bug 27470 depends on bug 28166, which changed state.

Bug 28166 Summary: UploadBase assumes that 'edit' and 'upload' rights are not 
per page restrictions
https://bugzilla.wikimedia.org/show_bug.cgi?id=28166

   What|Old Value   |New Value

 Status|NEW |RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied

2011-03-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

--- Comment #12 from Reedy s...@reedyboy.net 2011-03-22 22:37:09 UTC ---
Fixed with r84573 and r84575

However, seems I broke some error handling in r83979, will investigate

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied

2011-03-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

--- Comment #13 from Reedy s...@reedyboy.net 2011-03-22 23:07:44 UTC ---
Actually properly fixed in r84581

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied ?

2011-03-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

--- Comment #10 from Reedy s...@reedyboy.net 2011-03-21 20:56:38 UTC ---
vvv Reedy: probably someone removed check for page creation permission from
upload module
vvv Was it rewritten in 1.17?
Reedy I think so
snip
vvv Reedy: it looks like UploadBase assumes that 'edit', 'upload', etc are
not per-page restrictions
vvv Reedy: oh, and it also allows to upload images even when they are
create-protected

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied

2011-03-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

Reedy s...@reedyboy.net changed:

   What|Removed |Added

Summary|Upload blacklist for target |Upload blacklist for target
   |names not being applied ?   |names not being applied

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied

2011-03-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 Depends on||28166

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied ?

2011-03-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

--- Comment #8 from Reedy s...@reedyboy.net 2011-03-17 22:16:43 UTC ---
No idea about how it's supposed to work

$wgHooks['EditFilter'][] = 'TitleBlacklistHooks::validateBlacklist';

It would seem, that creating a file page doesn't hit this hook call, at all.

Blocking redirects to non existent blacklisted titles seems to work fine, as
does The title Meh on wheels has been banned from creation. It matches the
following blacklist entry: .*? on wheels

Just no hits for image uploads for whatever reason..

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied ?

2011-03-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

--- Comment #9 from Reedy s...@reedyboy.net 2011-03-17 22:23:29 UTC ---
That and there seems to be no code actually preventing any sort of new titles
from being created.

Almost seems like we're barking up the wrong tree...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied ?

2011-03-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

Rob Lanphier ro...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ro...@wikimedia.org
 AssignedTo|vasi...@gmail.com   |s...@reedyboy.net

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied ?

2011-03-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #6 from Krinkle krinklem...@gmail.com 2011-03-14 20:48:36 UTC ---
I just reproduced it here from both a sysop and non-sysop account:
http://commons.wikimedia.org/wiki/File:DSC902458.jpg

Did not get blocked by title blacklist.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied ?

2011-03-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 CC||s...@reedyboy.net

--- Comment #7 from Reedy s...@reedyboy.net 2011-03-14 22:20:10 UTC ---
Can seemingly reproduce locally. But not too familiar with code. Will poke it
when I've got a bit more time

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied ?

2011-02-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

Derk-Jan Hartman hart...@videolan.org changed:

   What|Removed |Added

 CC||s...@reedyboy.net

--- Comment #4 from Derk-Jan Hartman hart...@videolan.org 2011-02-25 09:09:11 
UTC ---
*** Bug 27339 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied ?

2011-02-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

Derk-Jan Hartman hart...@videolan.org changed:

   What|Removed |Added

 CC||raimond.spekk...@gmail.com

--- Comment #5 from Derk-Jan Hartman hart...@videolan.org 2011-02-25 09:14:54 
UTC ---
*** Bug 27700 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied ?

2011-02-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

--- Comment #1 from Bryan Tong Minh bryan.tongm...@gmail.com 2011-02-16 
20:49:08 UTC ---
I am not aware of a list that blocks such uploads, only a list that warns when
such files are uploaded. That list is working, I entered as filename
DSC01.jpg and I get a warning: 

The name of the file you are uploading begins with IMG, which is a
non-descriptive name typically assigned automatically by digital cameras.
Please choose a more descriptive name for your file.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied ?

2011-02-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

DieBuche diebu...@gmail.com changed:

   What|Removed |Added

 CC||diebu...@gmail.com

--- Comment #2 from DieBuche diebu...@gmail.com 2011-02-16 21:11:37 UTC ---
It's done via MediaWiki:Titleblacklist and
MediaWiki:Titleblacklist-custom-filename

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27470] Upload blacklist for target names not being applied ?

2011-02-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27470

Bryan Tong Minh bryan.tongm...@gmail.com changed:

   What|Removed |Added

  Component|Images and files|TitleBlacklist
Version|1.17|any
 AssignedTo|wikibugs-l@lists.wikimedia. |vasi...@gmail.com
   |org |
Product|MediaWiki   |MediaWiki extensions

--- Comment #3 from Bryan Tong Minh bryan.tongm...@gmail.com 2011-02-16 
21:27:20 UTC ---
That's an extension, changing category.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l