[Bug 28172] wfGetDB called when it shouldn't be

2011-11-20 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=28172

OverlordQ overlo...@gmail.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #13 from OverlordQ overlo...@gmail.com 2011-11-20 23:30:51 UTC ---
Remarking as RESOLVED FIX

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 28172] wfGetDB called when it shouldn't be

2011-11-03 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=28172

--- Comment #12 from OverlordQ overlo...@gmail.com 2011-11-03 21:00:42 UTC ---
The way I caught it was because when the _sha1 fields were re-added Pg wasn't
included in the schema change so when the installer got to adding the first
revision of the main page it died because rev_sha1 didn't exist. So I added it
to tables.sql. Fuzzy on the next steps but pretty sure I did the following, but
I'm pretty sure I hit the back button below the error, fixed the tables.sql,
then clicked continue button.


1) comment out rev_sha1 in maintenance/postgres/tables.sql
2) Continue through install process
3) Receive error
4) Click back button on bottom of page
5) Correct SQL issues
6) Click continue on bottom of page
8) Click continue on confirmation page
9) Receive error.

--
Setting up database... done
Checking for language PL/pgSQL... done
Creating schema... done
Creating tables... done
Information

Warning: MediaWiki tables seem to already exist. Skipping creation.
Populating default interwiki table... done
Information

Warning: The interwiki table seems to already have entries. Skipping
default list.
Committing changes... done
Initializing statistics... done
Generating secret keys... done
Creating administrator user account...

Mediawiki tried to access the database via wfGetDB(). This is not allowed.

Backtrace:
--


Hypothesis, if the tables exist we're forgetting to re-enable the lb?

So comparing DatabaseInstaller and PostgresInstaller, lets try r101880

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 28172] wfGetDB called when it shouldn't be

2011-11-02 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=28172

Sumana Harihareswara suma...@panix.com changed:

   What|Removed |Added

 CC||suma...@panix.com

--- Comment #10 from Sumana Harihareswara suma...@panix.com 2011-11-02 
22:07:33 UTC ---
Tim, can you offer some wisdom or guidance here?  This bug is hard to reproduce
-- Greg Sabino Mullane and OverlordQ can repro it, but Chad can't reproduce it
on MySQL or on SQLite -- and it shouldn't differ by dbms, since that code is
shared.

DJ Bauch offered, I see this  (Bug 28172)  happen when an install fails to
complete for some reason (on SQL Server in my case) and then tries to resume.
Restarting the install from scratch after fixing whatever caused the failure
works around the problem that the load balancer has been turned off and never
turned back on.

Selected IRC conversation:

G_SabinoMullane I think the key is here: #2
/var/www/thedarkcitadel.com/w/includes/User.php(2858): wfGetDB(-1)
^demon After the db has been initialized the LB is re-enabled.
^demon And then User can do its thing.
G_SabinoMullane ^demon: Why is the LB being disabled there?
MaxSem e.g. to prevent you from creating a user when you shouldn't :)
^demon The LB code automatically does things like connect to the database
and such.
MaxSem =when DB is not ready yet
^demon Right, it's to keep you from breaking things accidentally.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 28172] wfGetDB called when it shouldn't be

2011-11-02 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=28172

--- Comment #11 from Tim Starling tstarl...@wikimedia.org 2011-11-02 22:25:31 
UTC ---
If someone can provide a reliable reproduction procedure on PostgreSQL or
SQLite, then we can take it from there.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 28172] wfGetDB called when it shouldn't be

2011-10-31 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=28172

OverlordQ overlo...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||overlo...@gmail.com
 Resolution|FIXED   |

--- Comment #8 from OverlordQ overlo...@gmail.com 2011-10-31 19:59:25 UTC ---
Still happens on HEAD

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 28172] wfGetDB called when it shouldn't be

2011-10-31 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=28172

OverlordQ overlo...@gmail.com changed:

   What|Removed |Added

Version|1.18|1.19-svn

--- Comment #9 from OverlordQ overlo...@gmail.com 2011-10-31 20:00:20 UTC ---
#0 /var/www/thedarkcitadel.com/w/includes/GlobalFunctions.php(3178):
LBFactory_Fake-getMainLB(false)
#1 /var/www/thedarkcitadel.com/w/includes/GlobalFunctions.php(3168):
wfGetLB(false)
#2 /var/www/thedarkcitadel.com/w/includes/User.php(2858): wfGetDB(-1)
#3 /var/www/thedarkcitadel.com/w/includes/installer/Installer.php(1441):
User-idForName()
#4 [internal function]: Installer-createSysop(Object(PostgresInstaller))
#5 /var/www/thedarkcitadel.com/w/includes/installer/Installer.php(1355):
call_user_func(Array, Object(PostgresInstaller))
#6 /var/www/thedarkcitadel.com/w/includes/installer/WebInstallerPage.php(1133):
Installer-performInstallation(Array, Array)
#7 /var/www/thedarkcitadel.com/w/includes/installer/WebInstaller.php(254):
WebInstaller_Install-execute()
#8 /var/www/thedarkcitadel.com/w/mw-config/index.php(50):
WebInstaller-execute(Array)
#9 /var/www/thedarkcitadel.com/w/mw-config/index.php(18): wfInstallerMain()
#10 {main}

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 28172] wfGetDB called when it shouldn't be

2011-06-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=28172

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #7 from Mark A. Hershberger m...@everybody.org 2011-06-12 
18:58:16 UTC ---
Likewise, I didn't see it.  Closing.

Greg, if you see still see this, let us know ASAP.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 28172] wfGetDB called when it shouldn't be

2011-06-10 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=28172

--- Comment #6 from Tim Starling tstarl...@wikimedia.org 2011-06-10 13:00:11 
UTC ---
I never saw it while I was testing r89821, so it's probably fixed. Please test
the version in Subversion REL1_17.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 28172] wfGetDB called when it shouldn't be

2011-06-08 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=28172

Tim Starling tstarl...@wikimedia.org changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||tstarl...@wikimedia.org
 Resolution|FIXED   |

--- Comment #5 from Tim Starling tstarl...@wikimedia.org 2011-06-09 05:51:29 
UTC ---
Reopening since the proposed fix was reverted.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 28172] wfGetDB called when it shouldn't be

2011-05-26 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=28172

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

Summary|Error on Postgres install - |wfGetDB called when it
   |wfGetDB called when it  |shouldn't be
   |shouldn't   |

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 28172] wfGetDB called when it shouldn't be

2011-05-26 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=28172

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #4 from Mark A. Hershberger m...@everybody.org 2011-05-26 
21:49:54 UTC ---
r88936

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l