[Bug 29025] Magic links are inconsistent with common parser rules
https://bugzilla.wikimedia.org/show_bug.cgi?id=29025 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords|reviewed|need-review CC||suma...@panix.com --- Comment #8 from Sumana Harihareswara suma...@panix.com 2012-01-29 14:17:32 UTC --- Changed reviewed keyword to need-review to indicate that new patch awaits code review. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29025] Magic links are inconsistent with common parser rules
https://bugzilla.wikimedia.org/show_bug.cgi?id=29025 --- Comment #6 from vlak...@gmail.com 2012-01-23 13:28:39 UTC --- Created attachment 9895 -- https://bugzilla.wikimedia.org/attachment.cgi?id=9895 patch proposal for Bug 28950 and Bug 29025 First patch proposal for Bug 28950 and Bug 29025. Seems to be working great, nevertheless any suggestion would be very welcome. The benefits of this patch are: - (Bug 28950) non-breaking spaces (both literal char and HTML entities) support - (Bug 29025) no surprising link creation if several \n's (like ISBN\n\n1234567890) The only limitation I am aware of is that \n isn't implemented (yet), so for example ISBN\n1234567890 doesn't produce a link. But don't forget cases like ISBN \n123..., ISBN\n 123... (pre insertion!), ISBN\nnbsp;123..., and so on. \n support is feasible, I don't know if it would be that useful, however I'd like to be as close as possible to normal wikicode parsing. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29025] Magic links are inconsistent with common parser rules
https://bugzilla.wikimedia.org/show_bug.cgi?id=29025 --- Comment #7 from vlak...@gmail.com 2012-01-23 21:00:00 UTC --- Please see Bug 28950 for an updated patch of mine (and future ones if any). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29025] Magic links are inconsistent with common parser rules
https://bugzilla.wikimedia.org/show_bug.cgi?id=29025 Dan Collins en.wp.s...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED CC||en.wp.s...@gmail.com Resolution||FIXED --- Comment #4 from Dan Collins en.wp.s...@gmail.com 2011-07-09 21:52:28 UTC --- Looks to me like the magic links on the test.wikipedia.org page are all now behaving correctly, and only those with spaces and not newlines are linked. Closing this fixed. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29025] Magic links are inconsistent with common parser rules
https://bugzilla.wikimedia.org/show_bug.cgi?id=29025 Dan Collins en.wp.s...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #5 from Dan Collins en.wp.s...@gmail.com 2011-07-09 21:54:14 UTC --- Never mind, I completely misinterpreted that test page... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29025] Magic links are inconsistent with common parser rules
https://bugzilla.wikimedia.org/show_bug.cgi?id=29025 p858snake p858sn...@gmail.com changed: What|Removed |Added Blocks||29473 Blocks|26207 | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29025] Magic links are inconsistent with common parser rules
https://bugzilla.wikimedia.org/show_bug.cgi?id=29025
--- Comment #3 from Platonides platoni...@gmail.com 2011-05-27 22:11:05 UTC
---
Created attachment 8595
-- https://bugzilla.wikimedia.org/attachment.cgi?id=8595
Failing pages from enwiki-20110405
I have tested the 11120931 revisions of enwiki-20110405-pages-articles against
the regex
'!(?: # Start cases
(?:RFC|PMID)[\t\n\f\r]+([0-9]+) | # m[4]: RFC or PMID, capture number
ISBN[\t\n\f\r]+(\b # m[5]: ISBN, capture number
(?: 97[89] [\ \-]? )? # optional 13-digit ISBN prefix
(?: [0-9] [\ \-]? ){9} # 9 digits with opt. delimiters
[0-9Xx] # check digit
\b)
)!x'
748 pages would lose a magic linking.
If only 3645484 pages are articles, 748/3645484 = 0.2 per 1000.
I'd like to take a look into these articles, though.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29025] Magic links are inconsistent with common parser rules
https://bugzilla.wikimedia.org/show_bug.cgi?id=29025 The Evil IP address theevilipaddr...@hotmail.de changed: What|Removed |Added Blocks||26207 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29025] Magic links are inconsistent with common parser rules
https://bugzilla.wikimedia.org/show_bug.cgi?id=29025 Platonides platoni...@gmail.com changed: What|Removed |Added Blocks||28950 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29025] Magic links are inconsistent with common parser rules
https://bugzilla.wikimedia.org/show_bug.cgi?id=29025 p858snake p858sn...@gmail.com changed: What|Removed |Added Keywords||need-review, patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29025] Magic links are inconsistent with common parser rules
https://bugzilla.wikimedia.org/show_bug.cgi?id=29025 Ilmari Karonen nos...@vyznev.net changed: What|Removed |Added Keywords|need-review |reviewed CC||nos...@vyznev.net --- Comment #2 from Ilmari Karonen nos...@vyznev.net 2011-05-20 10:33:32 UTC --- Looks good to me. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29025] Magic links are inconsistent with common parser rules
https://bugzilla.wikimedia.org/show_bug.cgi?id=29025 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Unprioritized |Normal CC||m...@everybody.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29025] Magic links are inconsistent with common parser rules
https://bugzilla.wikimedia.org/show_bug.cgi?id=29025 --- Comment #1 from Platonides platoni...@gmail.com 2011-05-17 20:56:45 UTC --- Created attachment 8546 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8546 Accept only spaces separating magic links to RFC/PMID/ISBN You are right. The magic links reges use \s which is equivalent to [\t\n\f\r ]. Just using spaces would have been enough. The other characters were added in r15976, and I don't think they were intended to be supported. The above patch limits magic links to the space character. I would like checking its actual usage before applying, since they had been accepted the last 5 years. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
