[Bug 29123] Section edit links shown to anon users even if they can't edit

2011-08-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29123

f.trott f.tr...@gmx.net changed:

   What|Removed |Added

 CC||f.tr...@gmx.net

--- Comment #10 from f.trott f.tr...@gmx.net 2011-08-11 12:30:51 UTC ---
I see this bug on a freshly installed MW 1.17.0.

Both anonymous and logged-in users are affected, i.e. I have tried

 $wgDefaultUserOptions['editsection'] = false;

and I turned off the respective user preference, too. The edit links are shown
regardless.

Does not seem to have to do anything with caching either, purged after every
change of the settings.

(And for what it's worth, I do not consider this a minor bug.)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29123] Section edit links shown to anon users even if they can't edit

2011-08-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29123

--- Comment #11 from f.trott f.tr...@gmx.net 2011-08-11 12:39:06 UTC ---
Hmm, on second thought this might be a new bug, it does not have anything to do
with edit rights. These seem to work well, i.e. no edit rights no edit links.

It's just that setting $wgDefaultUserOptions['editsection'] to whatever value
has no effect at all.

New bug?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29123] Section edit links shown to anon users even if they can't edit

2011-06-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29123

--- Comment #9 from Platonides platoni...@gmail.com 2011-06-19 16:52:57 UTC 
---
I can't reproduce it at r89705. And yes, I seem to have now a working
htmlcache, and bypassed the 512 bytes limit of saveToFileCache()

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29123] Section edit links shown to anon users even if they can't edit

2011-06-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29123

--- Comment #8 from Platonides platoni...@gmail.com 2011-06-07 22:30:06 UTC 
---
I have readded the fix for bug 14404 in r89706. I think it should have also
fixed this. Can you verify?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29123] Section edit links shown to anon users even if they can't edit

2011-06-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29123

Ashar Voultoiz has...@free.fr changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||has...@free.fr
 Resolution|FIXED   |

--- Comment #5 from Ashar Voultoiz has...@free.fr 2011-06-02 13:23:34 UTC ---
The proposed change in r88988 does not fix anything since the modified code is
not deployed in 1.17 or on the live site.
See code review comment on r88988

Reopening bug

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29123] Section edit links shown to anon users even if they can't edit

2011-06-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29123

Platonides platoni...@gmail.com changed:

   What|Removed |Added

 CC||platoni...@gmail.com

--- Comment #6 from Platonides platoni...@gmail.com 2011-06-02 19:44:41 UTC 
---
Works for me, too (both trunk and REL1_17).
Maybe he could give us a link to his wiki?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29123] Section edit links shown to anon users even if they can't edit

2011-05-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29123

Ilmari Karonen nos...@vyznev.net changed:

   What|Removed |Added

 Resolution|WORKSFORME  |FIXED

--- Comment #4 from Ilmari Karonen nos...@vyznev.net 2011-05-27 18:54:38 UTC 
---
Actually, there seems to have been at least one genuine bug in the new parser
cache code, which (I think) I fixed in r88988.  This bug caused users with and
without section editing enabled to share the same parser cache keys, leading to
section edit links being mysteriously shown or not shown to user who shouldn't
or should see them.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29123] Section edit links shown to anon users even if they can't edit

2011-05-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29123

--- Comment #2 from Ilmari Karonen nos...@vyznev.net 2011-05-25 07:45:50 UTC 
---
$wgDefaultUserOptions is really a red herring -- the section edit links
shouldn't be shown to users who can't edit the page anyway.  Still, you may be
right that aurimai's report might have been caused by stale cached pages.  In
my case, though, I doubt that, as I've had anon editing disabled since pretty
much forever.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29123] Section edit links shown to anon users even if they can't edit

2011-05-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29123

Rob Lanphier ro...@wikimedia.org changed:

   What|Removed |Added

   Priority|High|Normal
 Status|NEW |RESOLVED
 CC||ro...@wikimedia.org
 Blocks|26676   |
 Resolution||WORKSFORME

--- Comment #3 from Rob Lanphier ro...@wikimedia.org 2011-05-25 21:50:14 UTC 
---
I can't reproduce this using the release from branches/REL1_17, r88842 (which
is unchanged since r88444).  I've tried all of these combinations:
1.  $wgGroupPermissions['*']['edit'] = false;
2.  $wgDefaultUserOptions['editsection'] = false;
3.  $wgGroupPermissions['*']['edit'] = false;
$wgDefaultUserOptions['editsection'] = false;

In all cases, the [edit] links go away for anonymous users.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29123] Section edit links shown to anon users even if they can't edit

2011-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29123

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |High
 CC||m...@everybody.org
 Blocks||26676

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29123] Section edit links shown to anon users even if they can't edit

2011-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29123

Subfader subfa...@gmail.com changed:

   What|Removed |Added

 CC||subfa...@gmail.com

--- Comment #1 from Subfader subfa...@gmail.com 2011-05-24 22:07:16 UTC ---
Are you sure you didn't add $wgDefaultUserOptions['editsection'] = false; AFTER
those affected page were cached last time?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l