[Bug 29223] Querying Wikipedia APIs (any language) for rvdiffto=prev fails for many revids: notcached
https://bugzilla.wikimedia.org/show_bug.cgi?id=29223 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Unprioritized |Normal CC||m...@everybody.org AssignedTo|roan.katt...@gmail.com |s...@reedyboy.net -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29223] Querying Wikipedia APIs (any language) for rvdiffto=prev fails for many revids: notcached
https://bugzilla.wikimedia.org/show_bug.cgi?id=29223 Reedy s...@reedyboy.net changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Comment #1 from Reedy s...@reedyboy.net 2011-05-31 21:05:51 UTC --- Works for me On the first one, I get the diffs for all 3 On the second one, I get diffs for 2, and notcached for the last Both for logged in and anonymous And the most it will give you is one uncached diff, per the site config reedy@fenari:/home/wikipedia/common/php-1.17/maintenance$ php eval.php echo $wgAPIMaxUncachedDiffs; 1 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29223] Querying Wikipedia APIs (any language) for rvdiffto=prev fails for many revids: notcached
https://bugzilla.wikimedia.org/show_bug.cgi?id=29223 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED CC||roan.katt...@gmail.com Resolution|WORKSFORME | --- Comment #2 from Roan Kattouw roan.katt...@gmail.com 2011-05-31 21:08:05 UTC --- (In reply to comment #1) Works for me On the first one, I get the diffs for all 3 On the second one, I get diffs for 2, and notcached for the last Both for logged in and anonymous And the most it will give you is one uncached diff, per the site config Sure. But if you keep refreshing, it should eventually give you all of them, because the uncached ones it generates should be saved to cache, right? Except that's not what happens, and that's what this bug is about. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29223] Querying Wikipedia APIs (any language) for rvdiffto=prev fails for many revids: notcached
https://bugzilla.wikimedia.org/show_bug.cgi?id=29223 --- Comment #3 from Reedy s...@reedyboy.net 2011-05-31 21:10:21 UTC --- (In reply to comment #2) (In reply to comment #1) Works for me On the first one, I get the diffs for all 3 On the second one, I get diffs for 2, and notcached for the last Both for logged in and anonymous And the most it will give you is one uncached diff, per the site config Sure. But if you keep refreshing, it should eventually give you all of them, because the uncached ones it generates should be saved to cache, right? Except that's not what happens, and that's what this bug is about. Nice when people explain things ;) Cause is simple, the diffs are not even attempted to be cached afterwards by the API -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29223] Querying Wikipedia APIs (any language) for rvdiffto=prev fails for many revids: notcached
https://bugzilla.wikimedia.org/show_bug.cgi?id=29223 --- Comment #4 from Reedy s...@reedyboy.net 2011-05-31 21:12:05 UTC --- (In reply to comment #3) (In reply to comment #2) (In reply to comment #1) Works for me On the first one, I get the diffs for all 3 On the second one, I get diffs for 2, and notcached for the last Both for logged in and anonymous And the most it will give you is one uncached diff, per the site config Sure. But if you keep refreshing, it should eventually give you all of them, because the uncached ones it generates should be saved to cache, right? Except that's not what happens, and that's what this bug is about. Nice when people explain things ;) Cause is simple, the diffs are not even attempted to be cached afterwards by the API Bleh, the DifferenceEngine doesn't believe it should be cached for whatever reason -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29223] Querying Wikipedia APIs (any language) for rvdiffto=prev fails for many revids: notcached
https://bugzilla.wikimedia.org/show_bug.cgi?id=29223 --- Comment #5 from Reedy s...@reedyboy.net 2011-05-31 21:14:49 UTC --- WHI probably means it's not technically an API bug -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29223] Querying Wikipedia APIs (any language) for rvdiffto=prev fails for many revids: notcached
https://bugzilla.wikimedia.org/show_bug.cgi?id=29223 --- Comment #6 from Roan Kattouw roan.katt...@gmail.com 2011-05-31 21:20:56 UTC --- (In reply to comment #5) WHI probably means it's not technically an API bug Well presumably diffs viewed through the UI get cached... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29223] Querying Wikipedia APIs (any language) for rvdiffto=prev fails for many revids: notcached
https://bugzilla.wikimedia.org/show_bug.cgi?id=29223
--- Comment #7 from Reedy s...@reedyboy.net 2011-05-31 21:24:35 UTC ---
if ( !is_null( $this-difftotext ) ) {
$engine = new DifferenceEngine( $title );
$engine-setText( $text, $this-difftotext );
} else {
$engine = new DifferenceEngine( $title, $revision-getID(),
$this-diffto );
$vals['diff']['from'] = $engine-getOldid();
$vals['diff']['to'] = $engine-getNewid();
}
$difftext = $engine-getDiffBody();
function __construct( $titleObj = null, $old = 0, $new = 0, $rcid = 0,
$refreshCache = false, $unhide = false )
And then it'll only do it if...
if ( $this-mOldid $this-mNewid ) {
So in some cases.
I'll look at looking into it properly later
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
