[Bug 30330] geoiplookup returns bad data over HTTPS

2011-09-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30330

Roan Kattouw  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #8 from Roan Kattouw  2011-09-06 19:31:41 
UTC ---
Ryan fixed this.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30330] geoiplookup returns bad data over HTTPS

2011-09-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30330

Roan Kattouw  changed:

   What|Removed |Added

 Status|VERIFIED|REOPENED
 Resolution|FIXED   |

--- Comment #7 from Roan Kattouw  2011-09-04 14:24:00 
UTC ---
This is still broken for traffic going through esams:

http://geoiplookup.wikimedia.org/ :
Geo =
{"city":"Assen","country":"NL","lat":"53.00","lon":"6.55","IP":"CENSORED","netmask":"CENSORED"}

https://geoiplookup.wikimedia.org/ :
Geo =
{"city":"(null)","country":"NL","lat":"52.50","lon":"5.75","IP":"91.198.174.122","netmask":"24"}

IP resolves to maerlant.esams.wikimedia.org , which is not documented on
wikitech but according to the server admin log seems to be the IPv6-v4 proxy in
esams.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30330] geoiplookup returns bad data over HTTPS

2011-08-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30330

Casey Brown  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #6 from Casey Brown  2011-08-15 18:30:22 UTC 
---
Working for me. Thanks, Ryan!

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30330] geoiplookup returns bad data over HTTPS

2011-08-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30330

Ryan Lane  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

--- Comment #5 from Ryan Lane  2011-08-15 18:22:12 UTC ---
This should now be fixed. Try it out and let me know.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30330] geoiplookup returns bad data over HTTPS

2011-08-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30330

Mark A. Hershberger  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 CC||m...@everybody.org

--- Comment #4 from Mark A. Hershberger  2011-08-12 
20:32:57 UTC ---
bump for Ryan to deploy now that he is back.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30330] geoiplookup returns bad data over HTTPS

2011-08-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30330

Kudu  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|wikibugs-l@lists.wikimedia. |rlan...@gmail.com
   |org |

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30330] geoiplookup returns bad data over HTTPS

2011-08-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30330

--- Comment #3 from Roan Kattouw  2011-08-12 09:40:49 
UTC ---
(In reply to comment #2)
> Yes. This is known. Since HTTPS is set up as an SSL termination cluster the
> varnish servers for geoiplookup see the IP address of the SSL cluster, and not
> that of the client.
208.80.152.21 reverse-DNSes to yvon.wikimedia.org, which is a box in Tampa,
right? Then it's a bit strange to me that geoip returns "San Francisco, CA" and
a set of coordinates in Mission Bay (an area in SF). Is the geoip database (and
possibly other DBs as well) misinformed as to the location of our datacenter
and do they think that because we own the IP range, and we're in SF, the IP
range is in SF?

(Not that this matters terribly, of course, it just jumped out at me.)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30330] geoiplookup returns bad data over HTTPS

2011-08-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30330

--- Comment #2 from Ryan Lane  2011-08-11 20:04:32 UTC ---
Yes. This is known. Since HTTPS is set up as an SSL termination cluster the
varnish servers for geoiplookup see the IP address of the SSL cluster, and not
that of the client. To fix this I've patched the geoiplookup code to use the
X-Forwarded-For header if the request is coming from one of the SSL cluster
nodes.

One of the four varnish nodes in pmtpa is running this code, and therefore
returns the correct data. I plan on pushing the change out to other nodes when
I get back from Israel.

For more information about how things work, see:

http://wikitech.wikimedia.org/view/Https

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30330] geoiplookup returns bad data over HTTPS

2011-08-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30330

Casey Brown  changed:

   What|Removed |Added

 CC||b...@caseybrown.org,
   ||rlan...@gmail.com,
   ||roan.katt...@gmail.com

--- Comment #1 from Casey Brown  2011-08-11 19:49:19 UTC 
---
I can reproduce this issue. It looks like the HTTPS one is pulling something
related to the office, and not the person viewing it.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l