[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 Roan Kattouw changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #11 from Roan Kattouw 2012-04-24 01:09:27 UTC --- (In reply to comment #10) > applied in https://gerrit.wikimedia.org/r/#change,4339 Was broken, reverted in https://gerrit.wikimedia.org/r/#change,5135 . -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 Nischay Nahata changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 Nischay Nahata changed: What|Removed |Added Keywords|easy, need-review | --- Comment #10 from Nischay Nahata 2012-04-05 17:35:42 UTC --- applied in https://gerrit.wikimedia.org/r/#change,4339 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 Nischay Nahata changed: What|Removed |Added Keywords|patch |need-review -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 --- Comment #9 from Nischay Nahata 2012-03-07 15:26:15 UTC --- Created attachment 10189 --> https://bugzilla.wikimedia.org/attachment.cgi?id=10189 removes messages from i18n file -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 Amir E. Aharoni changed: What|Removed |Added Keywords|need-review | --- Comment #8 from Amir E. Aharoni 2012-03-07 11:12:12 UTC --- * The corresponding messages in the i18n file must be removed. * As earlier, the showing of the dialogs and the buttons is not supposed to be conditional at all - they should just always be shown. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 Sumana Harihareswara changed: What|Removed |Added Keywords|reviewed|need-review -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 --- Comment #7 from Nischay Nahata 2012-03-03 08:18:00 UTC --- Created attachment 10164 --> https://bugzilla.wikimedia.org/attachment.cgi?id=10164 2nd patch This patch does the following 1. removes the preferences from the dialogs and toolbar in file WikiEditor.hooks.php 2. set global=true for dialogs and toolbar and user=false so that it is not user preference based anymore -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 Sumana Harihareswara changed: What|Removed |Added Keywords||reviewed -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 Amir E. Aharoni changed: What|Removed |Added Keywords|need-review | --- Comment #6 from Amir E. Aharoni 2012-03-02 19:49:04 UTC --- 1. The patch should be created using svn diff, according to instructions here: https://www.mediawiki.org/wiki/Patch 2. The preference should be removed completely and not just hidden and made true. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 Sumana Harihareswara changed: What|Removed |Added Keywords||need-review, patch CC||suma...@panix.com --- Comment #5 from Sumana Harihareswara 2012-02-26 03:58:58 UTC --- Added keywords to indicate that patch awaits review. Thanks, Nischay. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 --- Comment #4 from Nischay Nahata 2012-02-25 18:07:59 UTC --- Created attachment 10099 --> https://bugzilla.wikimedia.org/attachment.cgi?id=10099 removes the preferences for dialogs and sets it to global set $wgWikiEditorFeatures[dialogs][global]=true in wikiEditor.php and removed dialogs preferences in wikiEditor.hooks.php -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 --- Comment #3 from Nischay Nahata 2012-02-25 13:15:35 UTC --- Can you tell which PHP file controls the preferences settings?? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 Mark A. Hershberger changed: What|Removed |Added Keywords||easy Priority|Highest |Normal -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 Mark A. Hershberger changed: What|Removed |Added Priority|Unprioritized |Highest CC||m...@everybody.org Severity|normal |enhancement --- Comment #2 from Mark A. Hershberger 2011-11-14 20:51:24 UTC --- Seems like it'd be a simple patch -- not that I know anything about it. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 30796] "Enable dialogs for inserting links, tables and more" preference is confusing
https://bugzilla.wikimedia.org/show_bug.cgi?id=30796 --- Comment #1 from Brion Vibber 2011-09-07 19:07:11 UTC --- I'd strongly recommend dropping the preference as well. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
