[Bug 30909] URL parameters for checkboxes in Special:Block no longer work

2011-11-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30909

--- Comment #9 from Antoine hashar Musso has...@free.fr 2011-11-09 17:37:10 
UTC ---
merged in 1.18 by r102533

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30909] URL parameters for checkboxes in Special:Block no longer work

2011-11-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30909

Antoine hashar Musso has...@free.fr changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED
   Target Milestone|--- |1.18 tarball release

--- Comment #8 from Antoine hashar Musso has...@free.fr 2011-11-08 15:59:35 
UTC ---
Marking this one as resolved. Pending merge to 1.18 for tarball release.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30909] URL parameters for checkboxes in Special:Block no longer work

2011-11-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30909

Antoine hashar Musso has...@free.fr changed:

   What|Removed |Added

Version|1.18|1.19-svn

--- Comment #6 from Antoine hashar Musso has...@free.fr 2011-11-01 09:29:35 
UTC ---
Patched with r101464 pending code review.
Will need to be merged back to REL1_18.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30909] URL parameters for checkboxes in Special:Block no longer work

2011-11-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30909

Antoine hashar Musso has...@free.fr changed:

   What|Removed |Added

 CC||b...@mzmcbride.com

--- Comment #7 from Antoine hashar Musso has...@free.fr 2011-11-01 10:16:35 
UTC ---
*** Bug 31851 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30909] URL parameters for checkboxes in Special:Block no longer work

2011-10-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30909

Antoine hashar Musso has...@free.fr changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||has...@free.fr
 AssignedTo|wikibugs-l@lists.wikimedia. |has...@free.fr
   |org |

--- Comment #5 from Antoine hashar Musso has...@free.fr 2011-10-31 22:59:37 
UTC ---
bug 31770 most probably has the same root cause.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30909] URL parameters for checkboxes in Special:Block no longer work

2011-10-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30909

Antoine hashar Musso has...@free.fr changed:

   What|Removed |Added

Version|1.19-svn|1.18

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30909] URL parameters for checkboxes in Special:Block no longer work

2011-10-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30909

--- Comment #4 from Brad Jorsch b-jor...@alum.northwestern.edu 2011-10-10 
18:52:36 UTC ---
Created attachment 9210
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=9210
Patch to use the request-supplied value for checkbox variables

Right now, HTMLCheckField guesses if the form is being submitted (i.e. it's a
method=GET form or it supplies wpEditToken). If not, it completely ignores
the request-supplied value in favor of the form's default.

Perhaps the thing to do is to always use the request-supplied value any time
there is one, as well as when it thinks the form is being submitted. This
should result in the appropriate logic for forms such as Special:Block:
?wpWatch=1 forces the checkbox on, ?wpWatch=0 forces it off, and not specifying
wpWatch at all gives the form default.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30909] URL parameters for checkboxes in Special:Block no longer work

2011-10-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30909

Brad Jorsch b-jor...@alum.northwestern.edu changed:

   What|Removed |Added

   Keywords||need-review, patch
 CC||b-jorsch@alum.northwestern.
   ||edu

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30909] URL parameters for checkboxes in Special:Block no longer work

2011-09-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30909

duplicate...@googlemail.com changed:

   What|Removed |Added

 CC||mrblue...@wikipedia.be

--- Comment #3 from duplicate...@googlemail.com 2011-09-30 19:15:02 UTC ---
*** Bug 31273 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30909] URL parameters for checkboxes in Special:Block no longer work

2011-09-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30909

Happy-melon happy.melon.w...@gmail.com changed:

   What|Removed |Added

 CC||happy.melon.w...@gmail.com

--- Comment #2 from Happy-melon happy.melon.w...@gmail.com 2011-09-18 
20:38:52 UTC ---
(In reply to comment #1)
 Setting $form-setMethod( 'get' ); in SpecialBlock.php fixed this, but than
 also a validation of the input fields is done on 'get' and the special page
 shows a error at the first visit.

And more importantly would submit the form via a GET request, which has a
variety of negative security implications.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30909] URL parameters for checkboxes in Special:Block no longer work

2011-09-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30909

duplicate...@googlemail.com changed:

   What|Removed |Added

 CC||duplicate...@googlemail.com

--- Comment #1 from duplicate...@googlemail.com 2011-09-17 17:44:52 UTC ---
HTMLTextField has no own loadDataFromRequest

HTMLCheckField has a own loadDataFromRequest and is checking there against the
method of the form (r84814), but that is always 'post' and so the values from
the request are not used.

Setting $form-setMethod( 'get' ); in SpecialBlock.php fixed this, but than
also a validation of the input fields is done on 'get' and the special page
shows a error at the first visit.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30909] URL parameters for checkboxes in Special:Block no longer work

2011-09-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30909

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |High
 CC||m...@everybody.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l