[Bug 3158] Parser inserts invalid nbsp; in the middle of style attribute
https://bugzilla.wikimedia.org/show_bug.cgi?id=3158 Krinkle krinklem...@gmail.com changed: What|Removed |Added Summary|Automatic nbsp is inserted |Parser inserts invalid |even into XHTML attributes, |nbsp; in the middle of |including style |style attribute --- Comment #6 from Krinkle krinklem...@gmail.com --- (Cite Krinkle from 67092 comment #0) When the parser strips a /* comment */ from a style attribute it inserts a nbsp; in its place. This causes the stylesheet to be invalidated by the browser and the relevant styles are not applied when the page is renders. Wikitext input: blockquote style=border: 1px solid #aaa /* foo */;/blockquote Expected output: blockquote style=border: 1px solid #aaa ;/blockquote or blockquote style=border: 1px solid #aaa;/blockquote Actual output: blockquote style=border: 1px solid #aaa #160;;/blockquote A nbsp; is illegal in css in that position and results in a parse error by the browser, causing the 'border' rule in this case to not be applied. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 3158] Parser inserts invalid nbsp; in the middle of style attribute
https://bugzilla.wikimedia.org/show_bug.cgi?id=3158 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 3158] Parser inserts invalid nbsp; in the middle of style attribute
https://bugzilla.wikimedia.org/show_bug.cgi?id=3158 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 142042 had a related patch set uploaded by Krinkle: [WIP] Parser: Don't insert nbsp; inside style attributes https://gerrit.wikimedia.org/r/142042 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 3158] Parser inserts invalid nbsp; in the middle of style attribute
https://bugzilla.wikimedia.org/show_bug.cgi?id=3158 Jackmcbarn jackmcbarn+w...@gmail.com changed: What|Removed |Added CC||jackmcbarn+w...@gmail.com --- Comment #8 from Jackmcbarn jackmcbarn+w...@gmail.com --- It looks like CSS is just what makes this bug visible, rather than anything to do with its cause. At includes/parser/Parser.php:410-419: # Clean up special characters, only run once, next-to-last before doBlockLevels $fixtags = array( # french spaces, last one Guillemet-left # only if there is something before the space '/(.) (?=\\?|:|;|!|%|\\302\\273)/' = '\\1#160;', # french spaces, Guillemet-right '/(\\302\\253) /' = '\\1#160;', '/#160;(!\s*important)/' = ' \\1', # Beware of CSS magic word !important, bug #11874. ); $text = preg_replace( array_keys( $fixtags ), array_values( $fixtags ), $text ); This is doing a very aggressive replacement of spaces with #160; throughout the entire content of the page, and it's apparently already caused at least one other bug. I'm not sure why this is doing this, but our CSS handling is totally innocent and is just a red herring. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 3158] Parser inserts invalid nbsp; in the middle of style attribute
https://bugzilla.wikimedia.org/show_bug.cgi?id=3158 Jackmcbarn jackmcbarn+w...@gmail.com changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=11874 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
