[Bug 33445] margin-right:0 for table.wikitable

2012-09-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED
 AssignedTo|wikibugs-l@lists.wikimedia. |hartman.w...@gmail.com
   |org |
   Target Milestone|--- |1.20.0 release

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33445] margin-right:0 for table.wikitable

2012-09-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

Fomafix foma...@googlemail.com changed:

   What|Removed |Added

   Keywords||design
  Component|General/Unknown |User interface

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33445] margin-right:0 for table.wikitable

2012-09-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

   Keywords|design  |

--- Comment #10 from Krinkle krinklem...@gmail.com 2012-09-06 08:41:28 UTC ---
-design; the amount of spacing and visual appearance is not in question here.
That has already been decided for MediaWiki and even if that would be in need
of change, such is not subject of this bug.

This is purely a technicality.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33445] margin-right:0 for table.wikitable

2012-09-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

--- Comment #11 from Derk-Jan Hartman hartman.w...@gmail.com 2012-09-06 
19:41:54 UTC ---
Removed right margin in https://gerrit.wikimedia.org/r/22949

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33445] margin-right:0 for table.wikitable

2012-09-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

Derk-Jan Hartman hartman.w...@gmail.com changed:

   What|Removed |Added

   Keywords||patch-in-gerrit

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33445] margin-right:0 for table.wikitable

2012-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

foma...@googlemail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |

--- Comment #9 from foma...@googlemail.com 2012-01-18 07:20:13 UTC ---
REOPENED. The problem is not floatleft or floatright. floatleft and floatright
overwrites the margins of wikitable to get the margin on the correct side. The
problem is the right margin of wikitable alone as normal non-floating table.
This margin is not necessary to keep distance between any right floating object
because right floating objects already have a left margin to keep distance to
the normal text. The right margin of 1em for wikitable is annoying because it
prevents getting the table full width when there is no floating object.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33445] margin-right:0 for table.wikitable

2012-01-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

--- Comment #5 from foma...@googlemail.com 2012-01-17 12:48:08 UTC ---
table.float-left in Common.css is ok.


But when you want to have a left or right floating table then you should care
about the margins:

{| class=wikitable style=float:left; margin: 0 1em 1em 0;
{| class=wikitable style=float:right; margin: 0 0 1em 1em;


It would be possible to redefine the deprecated HTML alignments
http://www.w3.org/TR/html4/struct/tables.html#h-11.2.1 align=left and
align=right with automatic margin:
table[align=left] {
float: left;
clear: left;
margin: 0 1em 1em 0;
}
table[align=right] {
float: right;
clear: right;
margin: 0 0 1em 1em;
}
But I think this is not necessary and doesn't make sense.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33445] margin-right:0 for table.wikitable

2012-01-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

--- Comment #6 from Erwin Dokter er...@darcoury.nl 2012-01-17 14:26:35 UTC ---
When HTML5 will be enabled, MediaWiki will automatically replace the old HTML
tags with inline CSS. That means the attribute selector will not work.

Here's some universal code to put in Common.css:

div.floatleft,
table.floatleft {
float: left;
clear: left;
margin: 1em 1em 1em 0;
}
div.floatright,
table.floatright {
float: right;
clear: right;
margin: 1em 0 1em 1em;
}

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33445] margin-right:0 for table.wikitable

2012-01-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

--- Comment #7 from foma...@googlemail.com 2012-01-17 21:24:39 UTC ---
I just recognize that the CSS classes floatleft and floatright (without dash)
already exists in skins/common/shared.css and skins/common/commonContent.css.
But they have the definition border: 0. This is not adequate for wikitable. I
think thats the reason because dewiki defined the CSS classes float-left and
float-right (with dash) in Common.css many years ago.

Back to my original suggestion. wikitable should not have a right margin to
allow a width of 100%. When a wikitable is used as a left oder right floating
object the margin should be defined by inline CSS or adequate CSS class.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33445] margin-right:0 for table.wikitable

2012-01-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

Erwin Dokter er...@darcoury.nl changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX

--- Comment #8 from Erwin Dokter er...@darcoury.nl 2012-01-17 22:38:53 UTC ---
Problem solved then. Both .floatleft and .floatright even provide the necessary
margins. Don't worry about the border:0; this is overridden by wikitable
itself.

But while the default wikitable margin might seem unnecessary, it does serve a
purpose: to keep distance between the non-floating table and any right floating
objects (such as infoboxes) nearby. So it cannot be removed. Closing as
WONTFIX.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33445] margin-right:0 for table.wikitable

2012-01-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

Erwin Dokter er...@darcoury.nl changed:

   What|Removed |Added

 CC||er...@darcoury.nl

--- Comment #2 from Erwin Dokter er...@darcoury.nl 2012-01-16 11:56:19 UTC ---
This just came up on enwiki. Tables are normally used as block elements, or
floating on the left, in which case the margin is needed. Any other positioning
requires a manual override.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33445] margin-right:0 for table.wikitable

2012-01-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

--- Comment #3 from foma...@googlemail.com 2012-01-16 21:26:45 UTC ---
When you add float:left then you can also add margin:0 1em 1em 0.

dewiki has as shortcut for this situation

table.float-left {
clear: left;
float: left;
margin: 1em 1em 1em 0;
}

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33445] margin-right:0 for table.wikitable

2012-01-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

--- Comment #4 from Erwin Dokter er...@darcoury.nl 2012-01-16 21:59:40 UTC ---
That would be a good candidate to put in Common.css, but not in Shared.css.
That should be reserved the most basic element styling.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33445] margin-right:0 for table.wikitable

2012-01-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

--- Comment #1 from foma...@googlemail.com 2012-01-04 09:29:01 UTC ---
table.wikitable  caption, {
padding-bottom: 0.2em;
padding-top: 0.2em;
}

would be useful because td and th has already padding: 0.2em.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33445] margin-right:0 for table.wikitable

2011-12-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33445

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 CC||m...@everybody.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l