[Bug 33878] HTML dump is missing all images due to new FileBackend code
https://bugzilla.wikimedia.org/show_bug.cgi?id=33878 --- Comment #4 from Mark A. Hershberger m...@everybody.org 2012-03-02 21:51:51 UTC --- (In reply to comment #3) That looks OK to commit. Did you commit this? Could you tag the revision 1.19? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33878] HTML dump is missing all images due to new FileBackend code
https://bugzilla.wikimedia.org/show_bug.cgi?id=33878 Antoine hashar Musso has...@free.fr changed: What|Removed |Added CC||has...@free.fr --- Comment #5 from Antoine hashar Musso has...@free.fr 2012-03-02 21:52:49 UTC --- To fix this bug, we need: - backport r110703 in REL1_19 - apply the fix from comment 2 in trunk and REL1_19 - test dumpHTML in REL1_19 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33878] HTML dump is missing all images due to new FileBackend code
https://bugzilla.wikimedia.org/show_bug.cgi?id=33878
--- Comment #2 from Thomas Bleher thomasble...@gmx.de 2012-02-05 09:48:32 UTC
---
Thanks a lot, it's working fine now!
I needed just one additional patch:
--- a/dumpHTML.inc
+++ b/dumpHTML.inc
@@ -1354,6 +1354,7 @@ class DumpHTML_ProxyFile {
if ( isset( $thumb-url ) ) {
$thumb-url = $this-fixURL( $thumb-url );
}
+ $thumb-file = $this;
return $thumb;
}
Without this, the links on image pages to the original image had an absolute
path.
I think this is the correct fix, but it would be nice if you could check and
then commit it.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33878] HTML dump is missing all images due to new FileBackend code
https://bugzilla.wikimedia.org/show_bug.cgi?id=33878 --- Comment #3 from Aaron Schulz aschulz4...@gmail.com 2012-02-05 20:22:13 UTC --- That looks OK to commit. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33878] HTML dump is missing all images due to new FileBackend code
https://bugzilla.wikimedia.org/show_bug.cgi?id=33878 Aaron Schulz aschulz4...@gmail.com changed: What|Removed |Added CC||aschulz4...@gmail.com --- Comment #1 from Aaron Schulz aschulz4...@gmail.com 2012-02-04 21:11:38 UTC --- Try testing it after r110703. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33878] HTML dump is missing all images due to new FileBackend code
https://bugzilla.wikimedia.org/show_bug.cgi?id=33878 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Unprioritized |High -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33878] HTML dump is missing all images due to new FileBackend code
https://bugzilla.wikimedia.org/show_bug.cgi?id=33878 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added CC||m...@everybody.org Target Milestone|--- |1.19.0 release -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
