[Bug 34385] $wgProxyList blocking broken since 1.18

2012-11-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=34385

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||aklap...@wikimedia.org
 Resolution||DUPLICATE

--- Comment #2 from Andre Klapper aklap...@wikimedia.org 2012-11-04 17:38:54 
UTC ---
This was fixed in bug 35303 /
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=commitdiff;h=eb5e031f310ddd8ba871219dd7fa939a904ea638

*** This bug has been marked as a duplicate of bug 35303 ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 34385] $wgProxyList blocking broken since 1.18

2012-09-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=34385

Chris Davis c_b_...@yahoo.com changed:

   What|Removed |Added

 CC||c_b_...@yahoo.com

--- Comment #1 from Chris Davis c_b_...@yahoo.com 2012-09-12 08:45:11 UTC ---
This may not be the best way to fix it, but I've found that modifying
./includes/specials/SpecialUserlogin.php to include a check for
$wgUser-blockedBy() is able to get things working again.  

The specific problem I was running into was that $wgProxyList seems to allow
banned IPs to create accounts, but prevents them from editing.  By setting up a
bannedips.php file as specified on
http://www.mediawiki.org/wiki/Manual:Combating_spam, I was able to prevent spam
edits, but my Recent Changes were becoming bloated with a lot of bogus
accounts.

Old:
if ( !$wgUser-isAllowed( 'createaccount' ) ) {
$wgOut-permissionRequired( 'createaccount' );
return false;
} elseif ( $wgUser-isBlockedFromCreateAccount() ) {
$this-userBlockedMessage();
return false;
}


New:
if ( $wgUser-blockedBy()){
$this-userBlockedMessage();
return false;
} elseif ( !$wgUser-isAllowed( 'createaccount' ) ) {
$wgOut-permissionRequired( 'createaccount' );
return false;
} elseif ( $wgUser-isBlockedFromCreateAccount() ) {
$this-userBlockedMessage();
return false;
}

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 34385] $wgProxyList blocking broken since 1.18

2012-02-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=34385

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 CC||m...@everybody.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l