[Bug 34744] Create mediawiki.api.edit module to abstract API action=edit
https://bugzilla.wikimedia.org/show_bug.cgi?id=34744 Helder mybugs.m...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #5 from Helder mybugs.m...@gmail.com --- That is missing here is the part about having a simple name such as edit instead of the obscure postWithEditToken: api.edit( params ).done( fn ).fail( err ) Compare with the simplicity of watch and unwatch. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34744] Create mediawiki.api.edit module to abstract API action=edit
https://bugzilla.wikimedia.org/show_bug.cgi?id=34744 Krinkle krinklem...@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Krinkle krinklem...@gmail.com --- I'm not sure what the request is here. There is both a way to use action=edit (mediawiki.api.edit), which already existed since 1.18.1. And an abstract interface to post with tokens exists as well (and edit token is even available already through mw.user.tokens now). This bug seems obsolete. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34744] Create mediawiki.api.edit module to abstract API action=edit
https://bugzilla.wikimedia.org/show_bug.cgi?id=34744 db duplicate...@googlemail.com changed: What|Removed |Added Status|NEW |RESOLVED CC||duplicate...@googlemail.com Resolution|--- |FIXED --- Comment #2 from db duplicate...@googlemail.com --- Was added with r105646 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34744] Create mediawiki.api.edit module to abstract API action=edit
https://bugzilla.wikimedia.org/show_bug.cgi?id=34744 Helder mybugs.m...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #3 from Helder mybugs.m...@gmail.com --- (In reply to comment #2) Was added with r105646 Not really. The module mediawiki.api.edit introduced on r105646 is the one I was talking about on bug 34733 comment 3: do the function name postWithEditToken need to contain the word Token? Wouldn't be more intuitive if the user didn't have to write that when using the API to edit a page? E.g. api.edit( params, ok, err )? One more question: is this module new in MW 1.19? If so, and in the case the function name will change, could this change be backported to MW 1.19? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34744] Create mediawiki.api.edit module to abstract API action=edit
https://bugzilla.wikimedia.org/show_bug.cgi?id=34744
Krinkle krinklem...@gmail.com changed:
What|Removed |Added
Priority|Low |Lowest
Summary|Add a mw.Api.prototype.edit |Create mediawiki.api.edit
|function to some|module to abstract API
|mediawiki.api* module |action=edit
|(mediawiki.api.edit?) |
--- Comment #1 from Krinkle krinklem...@gmail.com ---
Yes, though it doens't make sense to create a separate resourceloader module
for every possible value of the action parameter.
Certain actions have dedicated modules to abstract certain logic. It isn't just
for the purpose of specifying the action.
mw.Api#post is not an internal method in anyway, so there's nothing wrong with:
mw.Api#post({
action: foo,
param: example
});
Creating a module for it only changes it to:
mw.Api#foo({
param: example
});
At the cost of having to specify a dependency on mediawiki.api.foo and the
extra code being downloaded, executed and increasing the function call stack
(user foo post ajax jquery.ajax ...).
Unless this proposed module would do something useful beyond just passing
through the parameters and tacking .action = foo on it, recommending closing as
WONTFIX.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
