[Bug 35167] span dir=ltr in headings is ignored when the heading is shown in table of contents
https://bugzilla.wikimedia.org/show_bug.cgi?id=35167 Amir E. Aharoni amir.ahar...@mail.huji.ac.il changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #5 from Amir E. Aharoni amir.ahar...@mail.huji.ac.il 2012-10-21 19:11:25 UTC --- Deployed :) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35167] span dir=ltr in headings is ignored when the heading is shown in table of contents
https://bugzilla.wikimedia.org/show_bug.cgi?id=35167 Amir E. Aharoni amir.ahar...@mail.huji.ac.il changed: What|Removed |Added Keywords|patch-in-gerrit | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35167] span dir=ltr in headings is ignored when the heading is shown in table of contents
https://bugzilla.wikimedia.org/show_bug.cgi?id=35167 Amir E. Aharoni amir.ahar...@mail.huji.ac.il changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35167] span dir=ltr in headings is ignored when the heading is shown in table of contents
https://bugzilla.wikimedia.org/show_bug.cgi?id=35167 Amir E. Aharoni amir.ahar...@mail.huji.ac.il changed: What|Removed |Added Keywords||patch-in-gerrit --- Comment #4 from Amir E. Aharoni amir.ahar...@mail.huji.ac.il 2012-09-04 13:40:21 UTC --- Patch improved and tests added. Thank to anybody who can review it. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35167] span dir=ltr in headings is ignored when the heading is shown in table of contents
https://bugzilla.wikimedia.org/show_bug.cgi?id=35167 Amir E. Aharoni amir.ahar...@mail.huji.ac.il changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|wikibugs-l@lists.wikimedia. |amir.ahar...@mail.huji.ac.i |org |l --- Comment #3 from Amir E. Aharoni amir.ahar...@mail.huji.ac.il 2012-09-03 09:14:43 UTC --- Thank you for the tip, Dan. Proposed fix submitted in https://gerrit.wikimedia.org/r/#/c/22435/ . I'm working on tests for it. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35167] span dir=ltr in headings is ignored when the heading is shown in table of contents
https://bugzilla.wikimedia.org/show_bug.cgi?id=35167 matanya matanya.mo...@gmail.com changed: What|Removed |Added CC||matanya.mo...@gmail.com --- Comment #2 from matanya matanya.mo...@gmail.com 2012-07-25 13:32:06 UTC --- This is still an issue. not critical, but annoying. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35167] span dir=ltr in headings is ignored when the heading is shown in table of contents
https://bugzilla.wikimedia.org/show_bug.cgi?id=35167 Dan Collins en.wp.s...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||en.wp.s...@gmail.com Version|unspecified |(wikimedia-deployment) Ever Confirmed|0 |1 --- Comment #1 from Dan Collins en.wp.s...@gmail.com 2012-03-14 19:19:44 UTC --- Confirmed on 1.19wmf1. From the parser: $tocline = preg_replace( array( '#(?!/?(sup|sub|i|b)(?: [^]*)?).*?'.'#', '#(/?(sup|sub|i|b))(?: .*?)?'.'#' ), array( '', '$1' ), $safeHeadline ); Those regexen are rather ugly, but let's see if we can't add a very limited allowance for span: $tocline = preg_replace( array( '#(?!/?(sup|sub|i|b|span dir=ltr)(?: [^]*)?).*?'.'#', '#(/?(sup|sub|i|b|span dir=ltr))(?: .*?)?'.'#' ), array( '', '$1' ), $safeHeadline ); But I have to ask - someone went through the effort of not having a ? in that regex in two different places, and then left a ? in another place, and I notice that the world hasn't exploded. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35167] span dir=ltr in headings is ignored when the heading is shown in table of contents
https://bugzilla.wikimedia.org/show_bug.cgi?id=35167 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Unprioritized |Normal CC||m...@everybody.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
