[Bug 35593] On Gerrit's Review screen, change text Cover Message to Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=35593 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Low |Lowest Status|RESOLVED|REOPENED Resolution|LATER |--- --- Comment #8 from Andre Klapper aklap...@wikimedia.org --- [Removing RESOLVED LATER as discussed in http://lists.wikimedia.org/pipermail/wikitech-l/2012-November/064240.html . Reopening and setting priority to Lowest. For future reference, please use either RESOLVED WONTFIX (for issues that will not be fixed), or simply set lowest priority. Thanks a lot!] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35593] On Gerrit's Review screen, change text Cover Message to Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=35593 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |WONTFIX --- Comment #9 from Chad H. innocentkil...@gmail.com --- Unless upstream moves on this (which I doubt they will), this isn't going to happen. Marking WONTFIX. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35593] On Gerrit's Review screen, change text Cover Message to Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=35593 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Keywords||upstream Status|NEW |RESOLVED URL||http://code.google.com/p/ge ||rrit/issues/detail?id=1431 Resolution||LATER --- Comment #7 from Chad H. innocentkil...@gmail.com 2012-06-08 12:30:15 UTC --- Reported and tagged +upstream. Marking LATER pending some movement there. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35593] On Gerrit's Review screen, change text Cover Message to Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=35593 Chad H. innocentkil...@gmail.com changed: What|Removed |Added AssignedTo|innocentkil...@gmail.com|wikibugs-l@lists.wikimedia. ||org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35593] On Gerrit's Review screen, change text Cover Message to Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=35593 Antoine hashar Musso has...@free.fr changed: What|Removed |Added CC||has...@free.fr --- Comment #4 from Antoine hashar Musso has...@free.fr 2012-04-04 09:15:45 UTC --- That is actually a cover message, not a place for people to randomly comment about the patch set. Comments should be about the code, and thus done inline in the diff. Gerrit is build using Google Web Toolkit, I.E the application is technically a Java application. To change the text, we would have to change a Java property in : gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties Then recompile Gerrit and install the resulting .war. So any customization requires us to actually fork and maintain our own copy of Gerrit. I am not sure it is worth it just to tweak a text message. The issue should be reported upstream for discussion and this bug report closed. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35593] On Gerrit's Review screen, change text Cover Message to Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=35593 --- Comment #5 from Antoine hashar Musso has...@free.fr 2012-04-04 09:17:10 UTC --- The ChangeConstants.properties file I talked about has content such as: buttonReview = Review buttonPublishCommentsSend = Publish Comments buttonPublishSubmitSend = Publish and Submit buttonPublishCommentsCancel = Cancel headingCoverMessage = Cover Message: headingPatchComments = Patch Comments: On second thought, maybe that property file can be configured / provided along the .war without requiring a fork / custom build. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35593] On Gerrit's Review screen, change text Cover Message to Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=35593 --- Comment #6 from Chad H. innocentkil...@gmail.com 2012-04-04 12:11:26 UTC --- (In reply to comment #5) The ChangeConstants.properties file I talked about has content such as: buttonReview = Review buttonPublishCommentsSend = Publish Comments buttonPublishSubmitSend = Publish and Submit buttonPublishCommentsCancel = Cancel headingCoverMessage = Cover Message: headingPatchComments = Patch Comments: On second thought, maybe that property file can be configured / provided along the .war without requiring a fork / custom build. Making this customizable without forking the .war is worth reporting upstream. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35593] On Gerrit's Review screen, change text Cover Message to Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=35593 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Priority|Unprioritized |Low Severity|normal |enhancement -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35593] On Gerrit's Review screen, change text Cover Message to Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=35593 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added CC||suma...@panix.com AssignedTo|wikibugs-l@lists.wikimedia. |innocentkil...@gmail.com |org | Summary|On Review page change test |On Gerrit's Review screen, |Cover Message to |change text Cover Message |Comment |to Comment --- Comment #2 from Sumana Harihareswara suma...@panix.com 2012-03-29 17:36:29 UTC --- For reference: https://www.mediawiki.org/wiki/Git/Workflow#How_to_comment_on.2C_review.2C_and_merge_code_in_Gerrit The phrase Cover message is foreign and strange; comment would be better and would fit in with our usual usage of comment. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35593] On Gerrit's Review screen, change text Cover Message to Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=35593 --- Comment #3 from Chad H. innocentkil...@gmail.com 2012-03-29 17:38:03 UTC --- (In reply to comment #2) For reference: https://www.mediawiki.org/wiki/Git/Workflow#How_to_comment_on.2C_review.2C_and_merge_code_in_Gerrit The phrase Cover message is foreign and strange; comment would be better and would fit in with our usual usage of comment. It's meant to be a Cover message on top of the individual inline comments you left...so I at least *see* where they're coming from here. Haven't looked at how trivial/possible it is to tweak UI wording yet. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
