[Bug 35640] Article::delete() calls
https://bugzilla.wikimedia.org/show_bug.cgi?id=35640 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Version|1.19.0rc1 |1.19 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35640] Article::delete() calls
https://bugzilla.wikimedia.org/show_bug.cgi?id=35640 Quim Gil q...@wikimedia.org changed: What|Removed |Added CC||q...@wikimedia.org Assignee|wikibugs-l@lists.wikimedia. |platoni...@gmail.com |org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35640] Article::delete() calls
https://bugzilla.wikimedia.org/show_bug.cgi?id=35640 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Version|1.19.0beta2 |1.19.0rc1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35640] Article::delete() calls
https://bugzilla.wikimedia.org/show_bug.cgi?id=35640 --- Comment #10 from Platonides platoni...@gmail.com 2012-08-07 11:37:34 UTC --- That's funny, I fixed it without remembering about this bug. Thanks Tyler. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35640] Article::delete() calls
https://bugzilla.wikimedia.org/show_bug.cgi?id=35640 Tyler Romeo tylerro...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED CC||tylerro...@gmail.com Resolution||FIXED --- Comment #9 from Tyler Romeo tylerro...@gmail.com 2012-08-06 15:46:02 UTC --- This has since been fixed: https://gerrit.wikimedia.org/r/9968 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35640] Article::delete() calls
https://bugzilla.wikimedia.org/show_bug.cgi?id=35640 --- Comment #6 from Jeroen De Dauw jeroen_ded...@yahoo.com 2012-04-03 16:14:22 UTC --- From what I recall, wfDeprecated() should only be added once all usages are removed in both core and extensions. A lot of people are saying this, but use your brain and think about it. What I said. Either you deprecate it or not, you do not go mark it as deprecated in the docs and then don't provide the warning. This is extremely evil towards extension devs. So either remove both the doc and warning, or keep both. Don't just remove the warning... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35640] Article::delete() calls
https://bugzilla.wikimedia.org/show_bug.cgi?id=35640 --- Comment #7 from Alexandre Emsenhuber [IAlex] ialex.w...@gmail.com 2012-04-03 16:17:14 UTC --- And if we what you say, we make extensions dev crazy because we did not offer them time to updater their code and now they gets warnings ;) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35640] Article::delete() calls
https://bugzilla.wikimedia.org/show_bug.cgi?id=35640 --- Comment #8 from Jeroen De Dauw jeroen_ded...@yahoo.com 2012-04-03 16:21:18 UTC --- (In reply to comment #7) And if we what you say, we make extensions dev crazy because we did not offer them time to updater their code and now they gets warnings ;) I don't think you understand the purpose of wfDeprecated. It is there so extension developers can get warnings and notice they are using deprecated code. If they do not want warnings, then they will not turn on developer warnings and not get then. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35640] Article::delete() calls
https://bugzilla.wikimedia.org/show_bug.cgi?id=35640 --- Comment #1 from Jeroen De Dauw jeroen_ded...@yahoo.com 2012-04-02 12:17:25 UTC --- which is wrong while core still calls them. Either a function is deprecated or it's not. If you mark it as deprecated in the docs, then you also put in a call to wfDeprecated, that's what it's for. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35640] Article::delete() calls
https://bugzilla.wikimedia.org/show_bug.cgi?id=35640 --- Comment #2 from Platonides platoni...@gmail.com 2012-04-02 12:18:39 UTC --- Then it shouldn't be deprecated if it's still used. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35640] Article::delete() calls
https://bugzilla.wikimedia.org/show_bug.cgi?id=35640 --- Comment #3 from Jeroen De Dauw jeroen_ded...@yahoo.com 2012-04-02 12:20:38 UTC --- If you mean still used in core, sure. If you mean used anywhere, then it does not make much sense anymore to bother with it at all right :) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35640] Article::delete() calls
https://bugzilla.wikimedia.org/show_bug.cgi?id=35640 --- Comment #4 from Platonides platoni...@gmail.com 2012-04-02 12:23:25 UTC --- Functions Article::doWatch and Article::doUnwatch are marked as deprecated, with both @deprecated and wfDeprecated(). Core still calls them in the non-deprecated function Article::delete(). Thus this is a bug. QED -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35640] Article::delete() calls
https://bugzilla.wikimedia.org/show_bug.cgi?id=35640 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Unprioritized |High CC||m...@everybody.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35640] Article::delete() calls
https://bugzilla.wikimedia.org/show_bug.cgi?id=35640 Alexandre Emsenhuber [IAlex] ialex.w...@gmail.com changed: What|Removed |Added CC||ialex.w...@gmail.com --- Comment #5 from Alexandre Emsenhuber [IAlex] ialex.w...@gmail.com 2012-04-02 17:54:51 UTC --- (In reply to comment #1) Either a function is deprecated or it's not. If you mark it as deprecated in the docs, then you also put in a call to wfDeprecated, that's what it's for. From what I recall, wfDeprecated() should only be added once all usages are removed in both core and extensions. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
