[Bug 36914] Special:UploadCampaigns and Special:UploadCampaign contents are hidden from people without editing rights

2013-07-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36914

--- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 70027 abandoned by Yuvipanda:
Show a disabled form for users without permissions.

Reason:
Campaign: namespace has been merged now, and users can see the campaigns
without restriction now.

https://gerrit.wikimedia.org/r/70027

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36914] Special:UploadCampaigns and Special:UploadCampaign contents are hidden from people without editing rights

2013-07-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36914

Yuvi Panda yuvipa...@gmail.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 CC||yuvipa...@gmail.com
 Resolution|--- |FIXED

--- Comment #14 from Yuvi Panda yuvipa...@gmail.com ---
With the new 'Campaign:' namespace, anyone can view them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36914] Special:UploadCampaigns and Special:UploadCampaign contents are hidden from people without editing rights

2013-06-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36914

--- Comment #11 from Nischay Nahata nischay...@gmail.com ---
I never saw You are modifying an Upload Wizard campaign. It should definitely
be outside the fieldset and also bold. Bad design

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36914] Special:UploadCampaigns and Special:UploadCampaign contents are hidden from people without editing rights

2013-06-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36914

--- Comment #12 from Nischay Nahata nischay...@gmail.com ---
Using preText() now, looks much more sane

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36914] Special:UploadCampaigns and Special:UploadCampaign contents are hidden from people without editing rights

2013-06-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36914

Alex Monk (Krenair) kren...@gmail.com changed:

   What|Removed |Added

 CC||kren...@gmail.com
Summary|Special:UploadCampaigns |Special:UploadCampaigns and
   |contents are hidden from|Special:UploadCampaign
   |people without editing  |contents are hidden from
   |rights  |people without editing
   ||rights

--- Comment #6 from Alex Monk (Krenair) kren...@gmail.com ---
To be fair the summary did say Special:UploadCampaigns, but it should include
Special:UploadCampaign as well...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36914] Special:UploadCampaigns and Special:UploadCampaign contents are hidden from people without editing rights

2013-06-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36914

--- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Related URL: https://gerrit.wikimedia.org/r/70027 (Gerrit Change
I1f65a4bb6eadc0696b8aa8c3b4e8972b299b8db8)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36914] Special:UploadCampaigns and Special:UploadCampaign contents are hidden from people without editing rights

2013-06-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36914

--- Comment #8 from Nischay Nahata nischay...@gmail.com ---
I have submitted a change but there are problems to resolve.

The change causes the form to be displayed to all users with all attributes
disabled and no submit/cancel button (I guess that was expected?)

However, this could lead into confusion for some users if we don't display the
'You don't have permissions' warning, which we can't display simultaneously by
use of Exceptions. So maybe try another way to display this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36914] Special:UploadCampaigns and Special:UploadCampaign contents are hidden from people without editing rights

2013-06-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36914

--- Comment #9 from Alex Monk (Krenair) kren...@gmail.com ---
I would like to change the You are modifying an Upload Wizard campaign. text
to You are viewing an Upload Wizard campaign but you cannot modify it.,
however the message key is enforced by FormSpecialPage::getForm to effectively
be:
strlower( $this-getName() ) . '-text'.

I think we'll have to do this:

$wgHooks['SpecialUploadCampaignBeforeFormDisplay'][] = function ( $form ) {
$form-setHeaderText( wfMessage( 'uploadcampaign-text-readonly'
)-parseAsBlock() );
return true;
};

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 36914] Special:UploadCampaigns and Special:UploadCampaign contents are hidden from people without editing rights

2013-06-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=36914

--- Comment #10 from Alex Monk (Krenair) kren...@gmail.com ---
Um, with a permissions check in there as well of course.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l