[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Keywords|patch-in-gerrit | -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 Lupo lupo.bugzi...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 Lupo lupo.bugzi...@gmail.com changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |lupo.bugzi...@gmail.com |org | --- Comment #12 from Lupo lupo.bugzi...@gmail.com --- New patch in Gerrit (basically attachment 11272): https://gerrit.wikimedia.org/r/#/c/37654/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 --- Comment #9 from Derk-Jan Hartman hartman.w...@gmail.com 2012-11-04 15:00:30 UTC --- Interestingly: http://www.awaresystems.be/imaging/tiff/tifftags/pagenumber.html The first page is numbered 0 (zero). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 --- Comment #10 from Derk-Jan Hartman hartman.w...@gmail.com 2012-11-04 16:13:43 UTC --- I'd like to figure out the exact imagemagick version where this is switched, if anyone has any clues, I'd welcome it. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 --- Comment #11 from Lupo lupo.bugzi...@gmail.com 2012-11-04 23:44:38 UTC --- I think it was this change: http://trac.imagemagick.org/changeset/4014/ImageMagick/trunk/magick/property.c It should have a +1 in line 2815. (Unless the change from 1-based to zero-based indexing was intentional, of course). That would place the change betweeen IM 6.6.8-8 (1-based) and 6.6.8-10 (zero-based) according to http://www.imagemagick.org/script/changelog.php. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 Nemo_bis federicol...@tiscali.it changed: What|Removed |Added Status|ASSIGNED|NEW -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 --- Comment #8 from Lupo lupo.bugzi...@gmail.com 2012-10-31 22:10:35 UTC --- Created attachment 11272 -- https://bugzilla.wikimedia.org/attachment.cgi?id=11272 Patch showing my quick hack mentioned in comment 2 Hi DJ, I've left you some comments on that patch in Gerrit. Since apparently there are quite a few other places that assume 1-based indexing (and no gaps), I have now attached here my quick hack to map 0-based IM output to 1-based internal page numbers. Maybe that's easier than doing it your way, which did look cleaner at first sight, but which might require adapting several other parts. Maybe you can use it, and maybe not. I'm not sure what would be the best way to handle this page numbering cleanly. And perhaps you see a simple way to fix the problems I mentioned in Gerrit. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 --- Comment #6 from Derk-Jan Hartman hartman.w...@gmail.com 2012-10-29 16:36:04 UTC --- Confirmed, i see the same problem. The issue is in PagedTiffInfoParserState, which has prevPage, which starts at 0, which only works if the first page starts with 1. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 Derk-Jan Hartman hartman.w...@gmail.com changed: What|Removed |Added Keywords||patch-in-gerrit --- Comment #7 from Derk-Jan Hartman hartman.w...@gmail.com 2012-10-29 17:26:41 UTC --- Path in https://gerrit.wikimedia.org/r/30621 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 Derk-Jan Hartman hart...@videolan.org changed: What|Removed |Added CC||hart...@videolan.org --- Comment #4 from Derk-Jan Hartman hart...@videolan.org 2012-06-19 06:38:51 UTC --- Lupo, can you add your 'convert -version' info ? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 --- Comment #5 from Lupo lupo.bugzi...@gmail.com 2012-06-19 10:52:24 UTC --- Sure, though I don't see what convert has got to do with it, as the extension uses identify to get the info it wants. Anyway, it's identical to the version of identify: $ convert -version Version: ImageMagick 6.7.7-2 2012-05-28 Q16 http://www.imagemagick.org Copyright: Copyright (C) 1999-2012 ImageMagick Studio LLC Features: OpenCL $ -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 Lupo lupo.bugzi...@gmail.com changed: What|Removed |Added Summary|Assumes one-based page |PagedTiffHandler assumes |numbers; doesn't work with |one-based page numbers; |ImageMagick 6.7.7-2 which |doesn't work with |returns zero-based page |ImageMagick 6.7.7-2 which |numbers |returns zero-based page ||numbers -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 Markus Glaser gla...@hallowelt.biz changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Markus Glaser gla...@hallowelt.biz 2012-06-18 22:48:09 UTC --- Hi Lupo, need to investigate this. In our tests, it worked with page number one. Maybe it is a ImageMagic version issue, but that does not sound right ;) Can you post your workaround here? I would then incorporate this into the code. I think we need to normalize the starting page number according to MediaWiki needs, either to 0 or 1. That should not be a major issue. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 --- Comment #2 from Lupo lupo.bugzi...@gmail.com 2012-06-19 05:49:13 UTC --- Created attachment 10769 -- https://bugzilla.wikimedia.org/attachment.cgi?id=10769 ImageMagick identify output on two test files I'd rather not; I really just hacked it in, and I don't really have the time to do this right. I didn't analyze whether this could be fixed simply by initializing $prevPage to -1 instead of zero. I don't know if it's some ImageMagick version thing. I got my ImageMagick through MacPorts; maybe their version does something wrong (or at least differently from other distributions). In any case, I've attached the output of my ImageMagick on two test files from the Commons: http://commons.wikimedia.org/wiki/File:Lehndorf_(Saara)_-_Zentrum.tif http://commons.wikimedia.org/wiki/File:Tochon_d%27Annecy.tiff The first is a single page, the second has two pages. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 37692] PagedTiffHandler assumes one-based page numbers; doesn't work with ImageMagick 6.7.7-2 which returns zero-based page numbers
https://bugzilla.wikimedia.org/show_bug.cgi?id=37692 --- Comment #3 from Lupo lupo.bugzi...@gmail.com 2012-06-19 05:50:37 UTC --- BTW, note the that the alpha2 values also do not correspond to what the extension tests for. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
