[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

Matthias Mullie mmul...@wikimedia.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

--- Comment #13 from Matthias Mullie mmul...@wikimedia.org 2012-07-12 
13:31:15 UTC ---
Pushed to Gerrit (https://gerrit.wikimedia.org/r/#/c/15537/)  prototype

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

--- Comment #12 from Matthias Mullie mmul...@wikimedia.org 2012-07-10 
19:13:10 UTC ---
On permalink, when feedback has only been marked (un)helpful, the status says:
There has been no activity on this post.

Marking something as helpful/unhelpful doesn't seem to update
af_last_status/af_last_status_timestamp

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

--- Comment #7 from Matthias Mullie mmul...@wikimedia.org 2012-07-05 14:05:09 
UTC ---
Pushed to Gerrit (https://gerrit.wikimedia.org/r/#/c/14302/)  prototype

Voting helpful will show up green
Voting unhelpful will show up red
Undoing your helpful/unhelpful vote will show up black (since your opinion
seems to go back to neutral)

Meanwhile, refactored some code that looked like it could generate an incorrect
count on the number of actions.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

--- Comment #8 from Matthias Mullie mmul...@wikimedia.org 2012-07-05 14:07:24 
UTC ---
Created attachment 10824
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=10824
Colors for helpful/unhelpful in activity log

See screenshot of the colors for helpful/unhelpful in activity log.
(Pay no attention to the incorrect count of actions taken on the item, this is
now fixed)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

--- Comment #9 from Fabrice Florin fflo...@wikimedia.org 2012-07-05 16:12:54 
UTC ---
Thanks, looks good. 

Did this require any db schema change? will it affect performance in any
significant way?

Thanks for the screenshot, which makes it easy to visualize. 

Much appreciated!

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

--- Comment #10 from Matthias Mullie mmul...@wikimedia.org 2012-07-05 
16:20:39 UTC ---
Negative on both questions; impact is negligible

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

--- Comment #11 from Fabrice Florin fflo...@wikimedia.org 2012-07-05 16:39:24 
UTC ---
Cool, thanks!

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

Matthias Mullie mmul...@wikimedia.org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

Matthias Mullie mmul...@wikimedia.org changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

Matthias Mullie mmul...@wikimedia.org changed:

   What|Removed |Added

   Priority|Highest |High

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

--- Comment #5 from Matthias Mullie mmul...@wikimedia.org 2012-07-03 12:54:47 
UTC ---
Updated  fixed an issue with unflagging as abuse (it would add an extra flag
entry along with the unflag entry)

I noticed that marking an entry as helpful/unhelpful _does_ increase the
counter (XX actions on this post), but is _not_ added to the log (and thus also
prints no line in the activity pane) - is this intended, and if not, should it
add a line to the activity log, or shouldn't it count towards the activity
total.

Fix is on Gerrit (https://gerrit.wikimedia.org/r/#/c/14035/)  prototype.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

--- Comment #6 from Fabrice Florin fflo...@wikimedia.org 2012-07-03 16:25:08 
UTC ---
Thanks, Matthias!

I can confirm that these issues were fixed in prototype. Makes a big
difference!

Thanks as well for fixing the bug related to unflagging, which works as
expected now.

Regarding your question about helpful/unhelpful, we had initially intended to
increase the counter, but not print any lines to the Activity log, back when we
were trying to push this through quickly.

Now that we are caught up, I would be prepared to show the Helpful/Unhelpful
actions in the Activity log, but only if it doesn't introduce issues that would
slow down performance, or require a DB schema change.

And any change like this would be for the next deployment, not this one ;o)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

--- Comment #2 from Fabrice Florin fflo...@wikimedia.org 2012-07-02 16:27:16 
UTC ---
Created attachment 10811
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=10811
Feedback page screenshot of editor's view.

Thanks for adding the 'View activity' back to the editor's view on the feedback
page!

However, the editor's view still has problems that need to be fixed on
prototype:

There are two horizontal dividers in the toolbox on the right, above 'View
activity'. One of these dividers should be hidden, otherwise it makes it look
like something's broken.

This is an important bug to fix today, if possible, prior to tomorrow's
deployment. It is confusing for our primary target user -- and I cannot do the
video screencasts without that fix.

Thanks!

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

--- Comment #3 from Fabrice Florin fflo...@wikimedia.org 2012-07-02 16:53:44 
UTC ---
Created attachment 10812
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=10812
Screenshot of empty activity panel in Editor view

When I click on 'View Activity' in editor view on the feedback page, I cannot
see any activity for posts that have received at least 3 flags for abuse. 

Editors should be able to see all activity in this box, except
oversight-related actions.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-07-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

--- Comment #4 from Fabrice Florin fflo...@wikimedia.org 2012-07-02 16:55:54 
UTC ---
Created attachment 10813
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=10813
Screenshot of Permalink page in Editor view, with no Info or Activity sections

When I click on 'Details' in editor view on the feedback page, I cannot see any
 Info or Activity sections at the bottom of the permalink page. 

Editors should be able to see all info and activity in these sections, except
oversight-related actions.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-06-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

Chris McMahon cmcma...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||cmcma...@wikimedia.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-06-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

Fabrice Florin fflo...@wikimedia.org changed:

   What|Removed |Added

   Keywords||aftv5-1.5
   Priority|Unprioritized   |Highest
URL||http://en.wikipedia.org/wik
   ||i/Golden-crowned_Sparrow
 AssignedTo|wikibugs-l@lists.wikimedia. |mmul...@wikimedia.org
   |org |

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37950] Article Feedback - 'View Activity' does not appear in Editor's view

2012-06-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37950

--- Comment #1 from Matthias Mullie mmul...@wikimedia.org 2012-06-26 16:01:25 
UTC ---
Pushed to Gerrit (https://gerrit.wikimedia.org/r/#/c/13002/)  prototype

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l