[Bug 38222] UploadBase::checkWarnings could throw exception on null object access

2014-11-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38222

--- Comment #9 from Andre Klapper aklap...@wikimedia.org ---
Would anybody be willing to be a mentor for fixing the existing patch as part
of Google Code-in 2014?  If yes, could you add it to
https://www.mediawiki.org/wiki/Google_Code-in_2014#Proposed_tasks until
Sunday (we can still improve the description until December 1st)?
If time is spare I can also do that - I just need a statement who
would mentor it.

See https://lists.wikimedia.org/pipermail/wikitech-l/2014-October/079264.html
for more information. Don't hesitate to ask if you have questions!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38222] UploadBase::checkWarnings could throw exception on null object access

2014-10-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38222

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

URL|http://www.google-melange.c |
   |om/gci/task/view/google/gci |
   |2013/5817413010456576   |
 Whiteboard|gci2013 |gci2014

--- Comment #8 from Andre Klapper aklap...@wikimedia.org ---
Patch by Mayank in https://gerrit.wikimedia.org/r/#/c/105111/ needs rework. 
Newcomers: See https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38222] UploadBase::checkWarnings could throw exception on null object access

2014-01-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38222

--- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 104012 abandoned by Mayankmadan:
verifyUpload should be called before checkWarnings

Reason:
Added a new patch for this bug
https://gerrit.wikimedia.org/r/#/c/105111/

https://gerrit.wikimedia.org/r/104012

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38222] UploadBase::checkWarnings could throw exception on null object access

2014-01-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38222

--- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 105111 had a related patch set uploaded by Mayankmadan:
getApiWarnings() throws an exception if upload is invalid

https://gerrit.wikimedia.org/r/105111

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38222] UploadBase::checkWarnings could throw exception on null object access

2013-12-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38222

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38222] UploadBase::checkWarnings could throw exception on null object access

2013-12-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38222

--- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 104012 had a related patch set uploaded by Mayankmadan:
verifyUpload should be called before checkWarnings

https://gerrit.wikimedia.org/r/104012

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38222] UploadBase::checkWarnings could throw exception on null object access

2013-12-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38222

Quim Gil q...@wikimedia.org changed:

   What|Removed |Added

URL||http://www.google-melange.c
   ||om/gci/task/view/google/gci
   ||2013/5817413010456576
 CC||bawolff...@gmail.com,
   ||legoktm.wikipe...@gmail.com
   ||, matma@gmail.com
 Whiteboard||gci2013

--- Comment #4 from Quim Gil q...@wikimedia.org ---
Thank you very much! Google Code-in task created. We hope to get code reviewers
when a patch arrives.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38222] UploadBase::checkWarnings could throw exception on null object access

2013-12-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38222

Bryan Tong Minh bryan.tongm...@gmail.com changed:

   What|Removed |Added

 CC||s...@reedyboy.net

--- Comment #1 from Bryan Tong Minh bryan.tongm...@gmail.com ---
*** Bug 43832 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38222] UploadBase::checkWarnings could throw exception on null object access

2013-12-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38222

--- Comment #2 from Bryan Tong Minh bryan.tongm...@gmail.com ---
This should never happen because you should always call verifyUpload() before
checkWarnings() (should be documented). 

ApiUpload allows you to call checkWarnings() if you use async=true, which is I
think the reason for the exceptions we see in production.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38222] UploadBase::checkWarnings could throw exception on null object access

2013-12-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38222

--- Comment #3 from Christian Neubauer seventow...@gmail.com ---
cc'd Andre and Quim. Seems like this would be an easy task for the code-in...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38222] UploadBase::checkWarnings could throw exception on null object access

2012-12-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38222

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

   Keywords||easy
   Priority|Unprioritized   |Low
 Blocks||700

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l