[Bug 39592] Version the API

2014-09-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

--- Comment #14 from Brad Jorsch bjor...@wikimedia.org ---
(In reply to Sam Reed (reedy) from comment #1)
 If you've got a way to have all the changes without either a load of
 duplicate classes, or classes with tonnes of version related
 hacks/conditionals...

This is one big problem with the proposal, IMO.

And it can easily lead to code rot unless we first add unit tests for
everything (which we *should* do, and probably will someday in our copious free
time).

Another issue with versioning is that it promises that the old code using the
old versions will continue to work, but a fair number of our breaking changes
actually come from changes deeper in MediaWiki where we can't easily keep the
old way working (or else we would have).

(In reply to Krinkle from comment #2)
 Proposing:
 https://localhost/w/api.phpversion=1action=..;
 
 That is the most future-compatible and easiest to implement.

A single version parameter doesn't work well at all when you remember that we
have API modules coming in from extensions all over the place.

Even a version per module can sometimes be problematic: if two unrelated
breaking changes are made to the module, one arbitrarily gets v3 and one gets
v4, but a client needing BC behavior for v3 but new behavior for v4 is stuck.


I think feature flags to select new behavior and a good deprecation process
will take care of most things that actually need improvement, to the point
where we can do per-module versioning on an ad hoc basis rather than trying to
force it everywhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the API

2014-06-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

   Assignee|yu...@wikimedia.org |wikibugs-l@lists.wikimedia.
   ||org

--- Comment #12 from Andre Klapper aklap...@wikimedia.org ---
Yuri Astrakhan: I am resetting the assignee of this issue to default because
there has been no progress in the last months. Feel free to take it again when
you are actually planning to fix this. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the API

2014-06-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

--- Comment #13 from Yuri Astrakhan yu...@wikimedia.org ---
Yes, thanks, not working on it ATM.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the API

2014-06-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

 CC||aklap...@wikimedia.org

--- Comment #11 from Andre Klapper aklap...@wikimedia.org ---
Yuri Astrakhan: You assigned this ticket to yourself in 2012. 
Could you please provide a status update and inform us whether you are still
working (or still plan to work) on this issue? 
Only in case you do not plan to work on this issue anymore, should the assignee
be set back to default and the bug status changed from ASSIGNED to
NEW/UNCONFIRMED? Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the API

2014-05-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

Quim Gil q...@wikimedia.org changed:

   What|Removed |Added

 CC||ms...@wikimedia.org,
   ||suma...@wikimedia.org

--- Comment #10 from Quim Gil q...@wikimedia.org ---
A year later... 

Yuri, this report is assigned to you. Are you working or planning to work on
this?

CCing Moyz and Sumana, since this might be related to
https://www.mediawiki.org/wiki/Data_%26_Developer_Hub

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the API

2013-05-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

Quim Gil q...@wikimedia.org changed:

   What|Removed |Added

 CC||aayushsharma...@gmail.com,
   ||q...@wikimedia.org

--- Comment #9 from Quim Gil q...@wikimedia.org ---
Just a note to say that Aayush Sharma has submitted a GSoC proposal related to
this report: https://www.mediawiki.org/wiki/User:Aayush251/gsoc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the API

2013-03-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

Yuri Astrakhan yuriastrak...@gmail.com changed:

   What|Removed |Added

 Blocks||38891

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the API

2013-01-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

db duplicate...@googlemail.com changed:

   What|Removed |Added

 CC||duplicate...@googlemail.com

--- Comment #7 from db duplicate...@googlemail.com ---
Another idea for versioning is

image vs. file

The renaming of modules and output parameter was not done for backward
compatibility, but with a new version this is may possible.

Other things like spelling issues can also be find in api.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the API

2013-01-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

--- Comment #8 from Yuri Astrakhan yuriastrak...@gmail.com ---
db, please post your proposal in details at the
http://www.mediawiki.org/wiki/Requests_for_comment/API_Future

Renaming image to file sounds good, could you list all spelling mistakes you
found on that page too?

thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the API

2013-01-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

--- Comment #6 from Yuri Astrakhan yuriastrak...@gmail.com ---
Update: The currently proposed API changes are at
http://www.mediawiki.org/wiki/Requests_for_comment/API_Future

Feel free to add ideas or discuss on the talk page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the API

2012-12-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

MZMcBride b...@mzmcbride.com changed:

   What|Removed |Added

 CC||b...@mzmcbride.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the API

2012-12-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

--- Comment #5 from Yuri Astrakhan yuriastrak...@gmail.com ---
The first alpha version of the api versioning has been implemented. Grab it
while it's hot.  All details in the email at
http://lists.wikimedia.org/pipermail/mediawiki-api/2012-December/002811.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the api

2012-12-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

Dereckson dereck...@espace-win.org changed:

   What|Removed |Added

 CC||dereck...@espace-win.org,
   ||yuriastrak...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the api

2012-12-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

Yuri Astrakhan yuriastrak...@gmail.com changed:

   What|Removed |Added

   Assignee|wikibugs-l@lists.wikimedia. |yuriastrak...@gmail.com
   |org |

--- Comment #4 from Yuri Astrakhan yuriastrak...@gmail.com ---
I have began experimenting with the API versioning (sorry for my 6+ year
absence). There is now a mediawiki-api labs at
https://labsconsole.wikimedia.org/wiki/Nova_Resource:Mediawiki-api - I will
post all API versioning development there for everyone to test their client
code and extensions. Contact me if you want to join the project.


Current goal is to have a per module versioning scheme (this is required due to
the modular api nature).

/w/api.php?action=query2...

action=query will default to action=query1 - the original implementation, but
will give a warning.

api.php help will show the latest version info

action=paraminfo will handle all versions

among things that will also be added is a structured warning system, e.g.

'warnings': {
  'main': {
'usertext': 'Unrecognized parameters: param1,param2. Obsolete params:
param3. The latest module version is 3.'
'unknownparams': ['param1','param2'],
'obsoleteparams': ['param3'],
'newestversion': 3,
  }
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the API

2012-12-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

Dereckson dereck...@espace-win.org changed:

   What|Removed |Added

Summary|Version the api |Version the API

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the api

2012-12-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Low
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the api

2012-08-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #2 from Krinkle krinklem...@gmail.com 2012-08-24 15:30:33 UTC ---
Proposing:
https://localhost/w/api.phpversion=1action=..;

That is the most future-compatible and easiest to implement.

In the future (perhaps a future rewritten API 2.0) it could be more like this
(inspired by BrowserStack's JSON API)

https://localhost/w/api/1/[action][/primary parameter | query string]

more about that at bug 38891.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the api

2012-08-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

--- Comment #3 from Jon jrob...@wikimedia.org 2012-08-24 16:10:15 UTC ---
+1 to Krinkle's suggestion.
It does seem like the simplest solution to moving the api forward.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39592] Version the api

2012-08-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39592

--- Comment #1 from Sam Reed (reedy) s...@reedyboy.net 2012-08-23 21:19:04 
UTC ---
If you've got a way to have all the changes without either a load of duplicate
classes, or classes with tonnes of version related hacks/conditionals...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l