[Bug 39773] You cannot post a blank message error on every summary edit and more

2013-02-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

--- Comment #18 from Alex Monk (Krenair) kren...@gmail.com ---
I'm trying to review this but when trying to save the summaries I actually get
this in /var/log/apache2/error.log:
[Sun Feb 17 13:43:40 2013] [notice] child pid 7278 exit signal Segmentation
fault (11)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit and more

2013-02-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

--- Comment #19 from Alex Monk (Krenair) kren...@gmail.com ---
Not sure what I did but it seems to be working now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit and more

2013-02-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Alex Monk (Krenair) kren...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #20 from Alex Monk (Krenair) kren...@gmail.com ---
Merged.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit and more

2013-02-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

--- Comment #21 from Alex Monk (Krenair) kren...@gmail.com ---
(I should probably add that the segfault issue I was having was both with and
without the patch, and I can't reproduce it anymore.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit and more

2013-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com changed:

   What|Removed |Added

   Keywords||patch-in-gerrit
 Status|REOPENED|ASSIGNED
 CC||martinezn...@gmail.com
   Assignee|wikibugs-l@lists.wikimedia. |ro...@wikimedia.org
   |org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit and more

2013-01-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

   Target Milestone|MW 1.20 version |MW 1.21 version

--- Comment #17 from Nemo federicol...@tiscali.it ---
Milestone missed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit and more

2012-11-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

 CC||aklap...@wikimedia.org

--- Comment #16 from Andre Klapper aklap...@wikimedia.org 2012-11-30 12:08:23 
UTC ---
There is a not-too-huge patch (+18, -5) waiting for two weeks now in
https://gerrit.wikimedia.org/r/#/c/27844/ - could somebody review it?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit and more

2012-11-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

URL|https://translatewiki.net   |https://translatewiki.net/w
   ||/i.php?title=User_talk:Nemo
   ||_bislqt_method=replylqt_o
   ||perand=28760#[[User:Nemo_bi
   ||s/monobook.js]]_28760
 Blocks||39480
Summary|You cannot post a blank|You cannot post a blank
   |message error on every |message error on every
   |summary edit|summary edit and more

--- Comment #15 from Nemo federicol...@tiscali.it 2012-11-25 19:07:40 UTC ---
This bug also happens if you reply to a message by opening the reply link in a
new tab, e.g.
https://translatewiki.net/w/i.php?title=User_talk:Nemo_bislqt_method=replylqt_operand=28760#[[User:Nemo_bis/monobook.js]]_28760
(I had to do so because often the text area for the reply or new thread doesn't
open inline even after many reloads).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-10-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

--- Comment #14 from Nemo_bis federicol...@tiscali.it 2012-10-13 06:49:09 UTC 
---
(In reply to comment #13)
 Note: taking issues off the blocker list don't diminish their priority.  It
 just means we're not going to hold a particular version deployment hostage 
 over
 it.

The difference is subtle: given the nature of LQT, this means that any and all
bugs affecting it will rot forever and get worse at each update.
Also, no need for hostages: is it really impossible to revert changes which are
known to break stuff and deploy them only *after* they've been fixed? 

rantFrom a user perspective it's really impossible to understand what the
purpose of continuous integration is, if nothing can stop known bugs from
getting deployed. Erik asked people to file major bugs against LQT a year ago
http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/56008 ,
but it's obviously useless; I do it only for masochism and
tracking-addiction./rant

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-10-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Sumana Harihareswara suma...@wikimedia.org changed:

   What|Removed |Added

 CC||suma...@wikimedia.org

--- Comment #8 from Sumana Harihareswara suma...@wikimedia.org 2012-10-12 
15:22:52 UTC ---
I confirmed that this is still reproducible today per instructions on comment
#5 .

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-10-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Rob Lanphier ro...@wikimedia.org changed:

   What|Removed |Added

 CC||ro...@wikimedia.org
 Blocks|38865   |

--- Comment #9 from Rob Lanphier ro...@wikimedia.org 2012-10-12 16:22:37 UTC 
---
Removing as a blocker since blocking the 1.21wmf2 deployment won't help
matters.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-10-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

--- Comment #10 from Nemo_bis federicol...@tiscali.it 2012-10-12 18:40:23 UTC 
---
(In reply to comment #9)
 Removing as a blocker since blocking the 1.21wmf2 deployment won't help
 matters.

Sigh, didn't the WMF once say that the Wikimedia projects which chose LQT were
going to get life support for it? I think you should notify them that you don't
guarantee LQT won't be broken by updates, ie that LQT is completely
unsupported.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-10-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Krenair kren...@gmail.com changed:

   What|Removed |Added

 CC||kren...@gmail.com

--- Comment #11 from Krenair kren...@gmail.com 2012-10-12 18:44:22 UTC ---
(In reply to comment #10)
 I think you should notify them that you don't
 guarantee LQT won't be broken by updates, ie that LQT is completely
 unsupported.

How on earth do you get from not being able to guarantee that it won't get
broken to it being completely unsupported?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-10-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

--- Comment #12 from Nemo_bis federicol...@tiscali.it 2012-10-12 18:48:21 UTC 
---
(In reply to comment #11)
 How on earth do you get from not being able to guarantee that it won't get
 broken to it being completely unsupported?

Well, if it gets intentionally broken and upgrades are performed however broken
LQT can get, I call that being unsupported. Reversing the question, what kind
of support does WMF offer to Wikimedia projects using LQT?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-10-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

--- Comment #13 from Rob Lanphier ro...@wikimedia.org 2012-10-12 23:53:03 UTC 
---
This may be fixed with https://gerrit.wikimedia.org/r/#/c/27844/

Note: taking issues off the blocker list don't diminish their priority.  It
just means we're not going to hold a particular version deployment hostage over
it.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-10-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

   Platform|PC  |All
 OS/Version|Linux   |All

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-09-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

--- Comment #6 from mybugs.m...@gmail.com 2012-09-07 13:33:47 UTC ---
The message is shown because when the code from
window.liquidThreads.handleAJAXSave is executed the text in the test
 $j.trim( text ).length == 0
is actually undefined. But this was already the case on Gerrit change #17940,
which came before Gerrit change #17683 on
https://gerrit.wikimedia.org/r/#/q/status:merged+project:mediawiki/extensions/LiquidThreads+-owner:L10n-bot,n,z

Indeed, if I do
 cd extensions/LiquidThreads/
 git review -d 17940
and follow the steps from comment 5, I get the error
Uncaught TypeError: Cannot call method 'trim' of undefined

In both cases the fact that the text is undefined do not prevent the code from
another function from saving and reloading the page (even if the
[[translatewiki:MediaWiki:Lqt-empty-text]] is displayed), because none of lines
which contains
 e.preventDefault();
is ever executed.

The reason for text being undefined is the line
 text = editform.find('#wpTextbox1').val();
which depends on the existence of some editform. But it is defined as
 var editform = $j(this).closest('.lqt-edit-form');
and while summarizing a thread there is no element with class lqt-edit-form.

It seems this specific bug could be fixed by replacing the line which defines
the text by
 text = $j('#wpTextbox1').val();
(because there should be at most one element with this id on the page). But
there will be the problem of editform being empty...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-09-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

--- Comment #7 from Nemo_bis federicol...@tiscali.it 2012-09-07 14:41:15 UTC 
---
Is bug 40083 related? It's been recently reported by a casual user and I'm
reproducing it consistently.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-09-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Nemo_bis federicol...@tiscali.it changed:

   What|Removed |Added

   Target Milestone|--- |MW 1.20 version

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-09-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Nemo_bis federicol...@tiscali.it changed:

   What|Removed |Added

 Blocks||39841

--- Comment #3 from Nemo_bis federicol...@tiscali.it 2012-09-04 10:14:55 UTC 
---
Same on Chromium and over HTTP, just verified on mediawiki.org too which is at
1.20wmf11 (6108192).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-09-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Siebrand s.mazel...@xs4all.nl changed:

   What|Removed |Added

 CC||helder.w...@gmail.com,
   ||s.mazel...@xs4all.nl

--- Comment #4 from Siebrand s.mazel...@xs4all.nl 2012-09-04 11:14:03 UTC ---
Most probably caused by gerrit 17683, as this is the only merge on that day in
the affected area. Adding Helder to CC.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-09-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

--- Comment #5 from Siebrand s.mazel...@xs4all.nl 2012-09-04 11:20:32 UTC ---
Steps to reproduce:
1. Ensure logged in at https://translatewiki.net.
2. Go to https://translatewiki.net/wiki/User_talk:SiebrandLqtTest
3. Click Start new discussion
4. Subject: Test
5. Contents: Test
6. Click Save Page
7. Click Summarize
8. Contents: Test
9. Click Save page

Observed:
a. Pop up appears stating You cannot post a blank message
b. Once clicks OK on the pop up, the page is saved anyway.
c. No JS errors observed in Firebug.
d. Adding an edit summary does not change observed behaviour.

Expected:
* Page is saved without warning You cannot post a blank message

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-08-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Nemo_bis federicol...@tiscali.it changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #2 from Nemo_bis federicol...@tiscali.it 2012-08-31 10:13:19 UTC 
---
And now I'm getting it consistently again (last night and this morning), I
spoke too early.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-08-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Nemo_bis federicol...@tiscali.it changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39773] You cannot post a blank message error on every summary edit

2012-08-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39773

Nemo_bis federicol...@tiscali.it changed:

   What|Removed |Added

   Priority|Normal  |High
 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #1 from Nemo_bis federicol...@tiscali.it 2012-08-29 20:50:15 UTC 
---
Looks like it's mysteriously been fixed this afternoon, after an update on TWN
a couple mins ago I'm no longer able to reproduce.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l