[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

--- Comment #16 from Krinkle krinklem...@gmail.com 2012-09-12 10:02:00 UTC ---
(In reply to comment #15)
 Which 3 commits are the blockers?

(Cited from comment #10)
 * Narayam's :text live binding (bug 39969, fixed)
 * mediawiki.action.view.rightClickEdit (bug 39959, fixed)
 

(Cited from bug 39969 comment #8)
 Fixed in I86cef90be993cef2470fe9a4892bbe55fcce191e.

(Cited from bug 39959 comment #7)
 Fixed in I2fefb5376d0de40f4997a3a1763eee23fcd3e7fa

jQuery update is I32ae312308f6d4167e95e06a09973fb1ecd7bb02.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

--- Comment #17 from Oliver Keyes oke...@wikimedia.org 2012-09-12 10:58:33 
UTC ---
Just to butt in; my team has some patches that are dependent on this release
(and that require us to modify some pages in the MediaWiki namespace if we
don't want the edit window to look terrible). If someone could let know when we
have a confirmed deployment day/time (assuming it isn't posted here) I would be
most grateful :).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

Roan Kattouw roan.katt...@gmail.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #18 from Roan Kattouw roan.katt...@gmail.com 2012-09-12 23:42:46 
UTC ---
The fixes listed in comment 16 have been approved and backported into wmf10 and
wmf11. They are live now, and the watchlist star is now working for me.

(In reply to comment #17)
 Just to butt in; my team has some patches that are dependent on this release
 (and that require us to modify some pages in the MediaWiki namespace if we
 don't want the edit window to look terrible). If someone could let know when 
 we
 have a confirmed deployment day/time (assuming it isn't posted here) I would 
 be
 most grateful :).
If nothing else pops up, the wmf11 and wmf12 deployments will proceed as
scheduled.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

Rob Lanphier (RobLa) ro...@robla.net changed:

   What|Removed |Added

 CC||ro...@robla.net

--- Comment #13 from Rob Lanphier (RobLa) ro...@robla.net 2012-09-11 16:09:25 
UTC ---
Things are not ok.  Commons is still broken, and going back to wmf10 is going
to be difficult because I'm pretty sure we have some wmf11 work that is needed
for the Swift migration.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

--- Comment #14 from Krinkle krinklem...@gmail.com 2012-09-11 17:34:58 UTC ---
Right, wmf10+ (incl. master right now) is broken because jquery was reverted,
so affects commons as well. Either way, merge the 3 commits and we're done.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-11 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

--- Comment #15 from Rob Lanphier ro...@wikimedia.org 2012-09-11 20:33:43 UTC 
---
Which 3 commits are the blockers?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-10 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

--- Comment #9 from Krinkle krinklem...@gmail.com 2012-09-10 22:13:47 UTC ---
Yes, but as complained about before, someone reverted jQuery to 1.7.2 because
of a speed regression without testing anything.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-10 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 Depends on||39972

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-10 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Depends on|39972   |
 Resolution||DUPLICATE

--- Comment #10 from Krinkle krinklem...@gmail.com 2012-09-10 22:19:11 UTC ---
Marking as dupe instead of depending on bug 39972. There is nothing to be done
here, just go back to jQuery 1.8.1.

See bug 39972 for tracking the speed regressions. There were only 2 speed
issues. Overal jQuery 1.8 introduces many speed improvements and refactorings
of Sizzle and the Animation engines. But 2 edge cases were slown down for us:

* Narayam's :text live binding (bug 39969, fixed)
* mediawiki.action.view.rightClickEdit (bug 39959, fixed)

*** This bug has been marked as a duplicate of bug 39972 ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-10 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

Rob Lanphier ro...@wikimedia.org changed:

   What|Removed |Added

   Priority|High|Highest
 Status|RESOLVED|REOPENED
 CC||roan.katt...@gmail.com,
   ||ro...@wikimedia.org,
   ||tc...@wikimedia.org
 Resolution|DUPLICATE   |
 AssignedTo|wikibugs-l@lists.wikimedia. |krinklem...@gmail.com
   |org |

--- Comment #11 from Rob Lanphier ro...@wikimedia.org 2012-09-11 01:38:53 UTC 
---
Krinkle, I'm reopening this one and assigning to you.  We've reverted 1.20wmf11
from en.wikipedia.org, and we may revert all wikis to 1.20wmf10 tomorrow if we
can't figure out a speedy resolution to this.

Please fix this so that the watchlist code is compatible with jQuery 1.7. 
Thanks.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-10 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

--- Comment #12 from Krinkle krinklem...@gmail.com 2012-09-11 02:17:37 UTC ---
We're running on the old code now which has old module versions (for jq 1.7)
with old jquery. All fine.

In master we've got the latest module versions which are all developed on jq
1.8 and may or may not work with 1.7 (we know from at least a few that they
break on 1.7). Currently breaking because we reverted to 1.7.2 all of a sudden
without running tests (in that the revert would've been marked -2 by Jenkins
had we had TestSwarm integration ready).

The two speed issues that were reported on 1.7 have both already been solved
and are awaiting merge (I spent time on that last week already).

If for some unreported reason jq 1.7 needs to be kept longer, no problem. But
at this point I believe it is more productive to merge those 2 changes asap,
and then revert back forward to 1.8 and be done with it.

The alternative is basically the same: There is no easy/static way to spot
things that break between 1.7/1.8 other than observation, which we then patch
as we go, and that's exactly what I've been doing for the last week. So
basically we went through this already and now we can go back up to 1.8.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-08 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

rai...@rillke.eu rainerril...@hotmail.com changed:

   What|Removed |Added

   Platform|All |PC
 OS/Version|All |Windows XP

--- Comment #1 from rai...@rillke.eu rainerril...@hotmail.com 2012-09-08 
13:31:34 UTC ---
Forgot to say: It's on Wikimedia Commons, e.g.
http://commons.wikimedia.org/w/index.php?title=User_talk:Havang%28nl%29action=historydebug=trueuselang=en

using the latest Firefox

It also happens with other languages or if debug mode is disabled.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-08 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

Krenair kren...@gmail.com changed:

   What|Removed |Added

 CC||kren...@gmail.com
   Platform|PC  |All
 OS/Version|Windows XP  |All

--- Comment #2 from Krenair kren...@gmail.com 2012-09-08 13:32:56 UTC ---
Reproduced on Ubuntu with Chrome, so this is not Windows XP/Firefox specific.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-08 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

--- Comment #3 from Krenair kren...@gmail.com 2012-09-08 13:35:39 UTC ---
According to
http://blog.jquery.com/2012/06/22/jquery-1-8-beta-1-see-whats-coming-and-going/
this method was introduced in jQuery 1.8. On Tuesday we reverted to 1.7.2, so
now we get this error...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-08 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

--- Comment #4 from Krenair kren...@gmail.com 2012-09-08 14:13:26 UTC ---
$.parseHTML started being used in Gerrit change 19199 which means this affects
1.20wmf11 but not 1.20wmf10 (currently not wikipedias). Raising importance and
priority, CCing Dantman and Reedy.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-08 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

Krenair kren...@gmail.com changed:

   What|Removed |Added

   Priority|Unprioritized   |High
 CC||mediawiki-bugs@nadir-seen-f
   ||ire.com, s...@reedyboy.net
 Blocks||39841
   Severity|normal  |major

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-08 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

Bartosz Dziewoński matma@gmail.com changed:

   What|Removed |Added

 CC||mybugs.m...@gmail.com

--- Comment #5 from Bartosz Dziewoński matma@gmail.com 2012-09-08 
16:20:41 UTC ---
*** Bug 40106 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-08 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

--- Comment #6 from mybugs.m...@gmail.com 2012-09-08 21:17:42 UTC ---
As far as I can see, the notification system is plainly broken right now.
Neither of the following code works:
jsMsg('test')
mw.util.jsMessage('test')

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-08 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

Bartosz Dziewoński matma@gmail.com changed:

   What|Removed |Added

 CC||matma@gmail.com

--- Comment #7 from Bartosz Dziewoński matma@gmail.com 2012-09-08 
21:19:56 UTC ---
Couldn't we just temporarily replace all occurences of $.parseHTML() with $()
for now, just to make it mostly work, until jQuery 1.8 issues are properly
fixed? There seem to be only two in core right now.

Or maybe backport the method to jQuery 1.7? (I didn't check if it depends on
any other new features.)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40103] clicking the watch list star throws an error and no feedback is shown (star does not stop rotating)

2012-09-08 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40103

--- Comment #8 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com 
2012-09-08 22:09:34 UTC ---
The mw.notification code should already have the reintrodction of 1.8 as a
dependency.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l