[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 --- Comment #26 from Bartosz Dziewoński matma@gmail.com --- Final cleanup in https://gerrit.wikimedia.org/r/#/c/84196/ . -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 --- Comment #25 from Gerrit Notification Bot gerritad...@wikimedia.org --- Related URL: https://gerrit.wikimedia.org/r/61621 (Gerrit Change I73fed7551e6ded38a24eb936ad015fe1e57d036d) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Keywords|patch-in-gerrit | --- Comment #24 from Bartosz Dziewoński matma@gmail.com --- (In reply to comment #22) Okay, the relevant patch has been merged. Do we want to announce on relevant mailing lists and Village Pumps (...) (I can help do this, but I'm deferring to Bartosz here, since it's his patch.) Please feel free to announce it wherever appropriate, I'm not sure what's the usual process. I suppose wikitech, -ambassadors and EdwardsBot? Anyway, thank you :). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Steven Walling swall...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #22 from Steven Walling swall...@wikimedia.org --- Okay, the relevant patch has been merged. Do we want to announce on relevant mailing lists and Village Pumps with a link to http://meta.wikimedia.org/wiki/Change_to_section_edit_links ? (I can help do this, but I'm deferring to Bartosz here, since it's his patch.) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 --- Comment #23 from Gerrit Notification Bot gerritad...@wikimedia.org --- https://gerrit.wikimedia.org/r/49364 (Gerrit Change I6a6c12a90de3604012420b20c1f520e0ece170ab) | change APPROVED and MERGED [by jenkins-bot] -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 --- Comment #21 from Bartosz Dziewoński matma@gmail.com --- (This has been worked around in the changeset, FWIW.) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 --- Comment #18 from Matthew Flaschen mflasc...@wikimedia.org --- Created attachment 12184 -- https://bugzilla.wikimedia.org/attachment.cgi?id=12184action=edit Screenshot on my local wiki of patch set 32, before purge I just wanted to post a screenshot of what I got pre-purge on patch set 32, to make sure it's a known issue (may be acceptable). It includes the appearance and the DOM. The HTML is kind of in an in-between state, with mw-section (new class name), but still before the headline. It corrects on purge. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 --- Comment #19 from Bartosz Dziewoński matma@gmail.com --- Argh, this is probably a parser cache issue; I commented more extensively on the bug. The parser sucks, damn. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 --- Comment #20 from Matthew Flaschen mflasc...@wikimedia.org --- I believe all the complexity is an attempt to cache content while being able to sub in UI language-specific stuff (namely the word 'edit'). It can still be annoying, though. I've updated the Gerrit with a proposed CSS hack. To test: 1. Go to master 2. Purge a page. 3. Go back to this Gerrit. 4. Hard-refresh (e.g. Ctrl-Shift-R in Firefox), but don't purge. Look at the DOM in Firebug. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Blocks||45051 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 --- Comment #17 from Waldir wal...@email.com --- (In reply to comment #16) The patch (I6a6c12a9) is ready for reviewing, by the way. Link, for convenience: I6a6c12a9 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Depends on||45803 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Bug 41729 depends on bug 45803, which changed state. Bug 45803 Summary: Whitespace between == == headers should be insignificant https://bugzilla.wikimedia.org/show_bug.cgi?id=45803 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Depends on|43940 | --- Comment #16 from Bartosz Dziewoński matma@gmail.com --- This doesn't depend on bug 43940, since my solution won't involve JavaScript (or at least not the same one). The patch (I6a6c12a9) is ready for reviewing, by the way. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com changed: What|Removed |Added CC||martinezn...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 --- Comment #15 from Steven Walling swall...@wikimedia.org --- (In reply to comment #14) (In reply to comment #13) Out of curiosity, have there been any tests with either no icons or simply a more skin-friendly version? I thought this is what Steven meant? (In reply to comment #11) FWIW, regardless of personal preference, the version with the icon and no brackets was what was A/B tested by Trevor and co. back in the day, and which proved to work better for users. Or are you saying that the solution you're suggesting wasn't among the tested ones? I mean precisely this: * The version with icon etc. -- http://www.mediawiki.org/wiki/File:Screenshot-SectionEditLinks-Vector.png -- was what was tested. Sticking with the successful version from your A/B test is generally a good idea. * As an interim solution, it totally works for Vector (and probably other skins too) to keep the same appearance but move the position of the link, as Bartosz suggested. We probably won't see the same usability gains measured in the test, but it's a lot better than doing nothing. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Isarra zhoris...@gmail.com changed: What|Removed |Added CC||zhoris...@gmail.com --- Comment #13 from Isarra zhoris...@gmail.com --- Out of curiosity, have there been any tests with either no icons or simply a more skin-friendly version? Having more applicable successful results on hand would probably help considerably for convincingly selling this change to other projects, as while those such as plwp have had no trouble from it, that doesn't exactly make a compelling reason for folks to accept the change (and not, as for instance enwp folks are sometimes wont to do, just override it in common.css). -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 --- Comment #14 from Nemo federicol...@tiscali.it --- (In reply to comment #13) Out of curiosity, have there been any tests with either no icons or simply a more skin-friendly version? I thought this is what Steven meant? (In reply to comment #11) FWIW, regardless of personal preference, the version with the icon and no brackets was what was A/B tested by Trevor and co. back in the day, and which proved to work better for users. Or are you saying that the solution you're suggesting wasn't among the tested ones? -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Depends on||43940 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added CC||matma@gmail.com --- Comment #8 from Bartosz Dziewoński matma@gmail.com --- Do we actually want to use that look? It looks very out of place for me even on Vector, and more so on other skins. May I propose an alternative design? Such has feature been implemented and enabled by default on pl.wikipedia for years. I've never heard any complaints. Example page: https://pl.wikipedia.org/wiki/Zręczyce It keeps the links inside square brackets, but makes them slightly smaller and places them next to the heading itself, like the experimental implementation does. This will not be such a large design change as the experiment, while keeping the discoverability improvements. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Ori Livneh o...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #9 from Ori Livneh o...@wikimedia.org --- I keep intending to work on this but other things get in the way, so I'll unassign it for now so as to not discourage anyone else from working on it. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|o...@wikimedia.org |matma@gmail.com --- Comment #10 from Bartosz Dziewoński matma@gmail.com --- Okay, so I'm going to work on this, then. Let's see if it works out. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 --- Comment #11 from Steven Walling swall...@wikimedia.org --- (In reply to comment #10) Okay, so I'm going to work on this, then. Let's see if it works out. Glad to see you're interested. :) FWIW, regardless of personal preference, the version with the icon and no brackets was what was A/B tested by Trevor and co. back in the day, and which proved to work better for users. I do think that an acceptable interim solution is to simply move the current appearance of the edit links, ala what's used in pl, fr, and other wikis. But light of the previous testing results, and the fact icons + text are generally more memorable by users in regardless of language, we should still consider that approach. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Keywords||patch-in-gerrit --- Comment #12 from Bartosz Dziewoński matma@gmail.com --- I submitted a draft at I6a6c12a9, noting the steps to make this work properly in the commit message. I'm hoping to get this done by the end of the weekend. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added CC||mflasc...@wikimedia.org -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Blocks||156 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Waldir wal...@email.com changed: What|Removed |Added CC||wal...@email.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41729] Tidy up and deploy Vector's sectionEditLinks (move section edit links next to headers)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41729 Nemo federicol...@tiscali.it changed: What|Removed |Added Summary|Tidy up and deploy Vector's |Tidy up and deploy Vector's |sectionEditLinks|sectionEditLinks (move ||section edit links next to ||headers) -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l