[Bug 42211] Group membership log messages sometimes miss new membership status on meta.wikimedia.org

2012-11-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42211

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

Summary|Broken log messages |Group membership log
   ||messages sometimes miss new
   ||membership status on
   ||meta.wikimedia.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42211] Group membership log messages sometimes miss new membership status on meta.wikimedia.org

2012-11-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42211

Krenair kren...@gmail.com changed:

   What|Removed |Added

 CC||kren...@gmail.com
  Component|General/Unknown |Logging
Product|Wikimedia   |MediaWiki

--- Comment #1 from Krenair kren...@gmail.com 2012-11-17 15:31:06 UTC ---
Appears to be to do with RightsLogFormatter::getMessageParameters,
Language::listToText, and $newGroups array keys not starting at 0 on some
entries. Moving to MediaWiki product.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42211] Group membership log messages sometimes miss new membership status on meta.wikimedia.org

2012-11-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42211

--- Comment #2 from Krenair kren...@gmail.com 2012-11-17 15:35:01 UTC ---
This hack fixes it for me:
diff --git a/includes/logging/LogFormatter.php
b/includes/logging/LogFormatter.php
index 8c1e294..26368b4 100644
--- a/includes/logging/LogFormatter.php
+++ b/includes/logging/LogFormatter.php
@@ -1108,7 +1108,7 @@ class RightsLogFormatter extends LogFormatter {
$params[3] = $this-msg( 'rightsnone' )-text();
}
if ( count( $newGroups ) ) {
-   $params[4] = $lang-listToText( $newGroups );
+   $params[4] = $lang-listToText( array_values(
$newGroups ) );
} else {
$params[4] = $this-msg( 'rightsnone' )-text();
}

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l