[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #28 from Matthew Flaschen mflasc...@wikimedia.org --- Marked fixed. :) Do you have editbugs yet? If not, you can ask on IRC for someone to give it to you. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #27 from physikerwelt phy...@ckurs.de --- Since LaTeXML is merged and there are some users that use it actively this bug can be closed. Unfortunately I can not do that;-) To avoid confusion I deleted the LaTeXML branch and renamed it to dev. Just as information: The next step towards MathML are the deployment of the LaTeXML package. operations/debs/latexml -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #25 from physikerwelt phy...@ckurs.de --- Since mathml is not supported by manny browseres This change is also important to reach a wide audience https://gerrit.wikimedia.org/r/#/c/69298/ -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #26 from Matthew Flaschen mflasc...@wikimedia.org --- There is still an open LaTeXML branch (https://git.wikimedia.org/log/mediawiki%2Fextensions%2FMath.git/refs%2Fheads%2FLaTeXML), with recent commits However, I'm not sure if this bug is still helpful. Commits to master are being reviewed on a case-by-case basis. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #21 from physikerwelt phy...@ckurs.de --- This is now adressed by -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #22 from physikerwelt phy...@ckurs.de --- Created attachment 12290 -- https://bugzilla.wikimedia.org/attachment.cgi?id=12290action=edit mylyn/context/zip -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #23 from physikerwelt phy...@ckurs.de --- (In reply to comment #21) Sorry wrong link: This is now adressed by https://gerrit.wikimedia.org/r/#/c/61987/ -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #19 from physikerwelt phy...@ckurs.de --- It would be grate to be able to test LaTeXML in the context of the WMF. see https://wikitech.wikimedia.org/wiki/New_Project_Request/Math I think it is very important to do tests there before committing something to the main branch. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #20 from Matthew Flaschen mflasc...@wikimedia.org --- I pinged the Wikimedia Labs mailing list (https://lists.wikimedia.org/mailman/listinfo/labs-l), and Daniel Zahn created it. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 Frédéric Wang fred.w...@free.fr changed: What|Removed |Added CC||fred.w...@free.fr -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #17 from physikerwelt phy...@ckurs.de --- Thanks. I tried to figure out how to set up the database tables for testing. As far as I did understand there must be a way to clone the table structure with a prefix. However if I tied to do this, I get a warning the table _prefix_math does already exist. See https://gerrit.wikimedia.org/r/#/c/49477/1/tests/MathRendererTest.php -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #18 from physikerwelt phy...@ckurs.de --- Unfortunately there are some bugs in the master version. Is there a way to get them fixed faster than the via the normal review process. See https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/Math,n,z -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #15 from physikerwelt phy...@ckurs.de --- (In reply to comment #14) Thanks for these hints. However I was aware of the technical aspects. Maybe to be more precise. Is there a prototpe extension that comes up with good unit tests. Especially the database stuff is something that is not trival to test. Generally we have parser tests, which you've already seen, PHPUnit tests (can be used for unit or integration tests on server), QUnit (JavaScript unit tests), and Cucumber for integration tests (testing the overall user experience through the web browser). Probably, PHPUnit would be most important for your stuff, but if you want to add some QUnit or Cucumber, that would be a bonus, particularly for the MathJax stuff. See https://www.mediawiki.org/wiki/PHPUnit, https://www.mediawiki.org/wiki/QUnit and https://www.mediawiki.org/wiki/Cucumber I've done a lot of QUnit here, and some PHPUnit, so I can definitely help with those. I'm working on a Cucumber test right now, but I haven't committed anything yet. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #16 from Matthew Flaschen mflasc...@wikimedia.org --- (In reply to comment #15) (In reply to comment #14) Thanks for these hints. However I was aware of the technical aspects. Maybe to be more precise. Is there a prototpe extension that comes up with good unit tests. Especially the database stuff is something that is not trival to test. There probably are extensions with good database tests, but I can't pinpoint one offhand. However, if you go into the test directory of MediaWiki core, you can do: git grep db That will give you an indication of how databases are used for core tests. Extension tests generally subclass the same class, MediaWikiTestCase, which provides some of the database functionality you'll need. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #13 from physikerwelt phy...@ckurs.de --- Thanks a lot Matthew. I want to do some meaningful unit tests for the module. I would be quite happy if you could provide some input for that task. Is there a general stategy at the WMF to structured tests. In the end we should come up with a mutually orthogonal set of tests, some integration tests in addition and furthermore tests that check for the expected bugs. Thus I'd be happy to collect a list of required test at http://www.mediawiki.org/wiki/Extension:Math/Roadmap After that the time is ready for merge. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #14 from Matthew Flaschen mflasc...@wikimedia.org --- Generally we have parser tests, which you've already seen, PHPUnit tests (can be used for unit or integration tests on server), QUnit (JavaScript unit tests), and Cucumber for integration tests (testing the overall user experience through the web browser). Probably, PHPUnit would be most important for your stuff, but if you want to add some QUnit or Cucumber, that would be a bonus, particularly for the MathJax stuff. See https://www.mediawiki.org/wiki/PHPUnit, https://www.mediawiki.org/wiki/QUnit and https://www.mediawiki.org/wiki/Cucumber I've done a lot of QUnit here, and some PHPUnit, so I can definitely help with those. I'm working on a Cucumber test right now, but I haven't committed anything yet. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |High -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #12 from Matthew Flaschen mflasc...@wikimedia.org --- I've recommended that physikerwelt squash some of the commits on the branch, so there won't be quite so many to review. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #11 from Matthew Flaschen mflasc...@wikimedia.org --- Reopening. One commit was merged, but there's still the branch at https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Math.git;a=shortlog;h=refs/heads/LaTeXML -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #10 from MZMcBride b...@mzmcbride.com --- (In reply to comment #9) There's a thread on this on wikitech-l under NullLockManager and the math extension http://lists.wikimedia.org/pipermail/wikitech-l/2013-February/066265.html -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #5 from Ori Livneh o...@wikimedia.org --- All tests pass! With the installation of 'texlive-lang-greek' and 'texlive-fonts-recommended', I was able to get 12/13 tests to pass. The remaining test failure was due to the srset attribute getting added to img tags, so I updated the expected output. I documented the dependencies in README. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 Ori Livneh o...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #6 from Ori Livneh o...@wikimedia.org --- Merged. Thanks very much physikerwelt for your patience and fixes and thanks Matt for the reviews. This is now in the deployment queue. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #7 from Matthew Flaschen mflasc...@wikimedia.org --- What about the nullLockManager I asked about? I'm not totally comfortable with the change from nullLockManager to fsLockManager (https://gerrit.wikimedia.org/r/#/c/30177/20..24/MathTexvc.php). In theory it should be okay on the WMF cluster, since it looks like it only applies if wgMathFileBackend is not set. In mediawiki-config, there is: $wgMathFileBackend = $wmgMathFileBackend; in CommonSettings.php and: 'wmgMathFileBackend' = array( 'default' = 'global-multiwrite' ), in LocalSetting.php. However, it could affect other installations. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #8 from Matthew Flaschen mflasc...@wikimedia.org --- Created attachment 11755 -- https://bugzilla.wikimedia.org/attachment.cgi?id=11755action=edit Math parser tests on patch set 20 This is for background on the lock manager discussion. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #9 from Matthew Flaschen mflasc...@wikimedia.org --- There's a thread on this on wikitech-l under NullLockManager and the math extension -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #4 from Matthew Flaschen mflasc...@wikimedia.org --- Created attachment 11739 -- https://bugzilla.wikimedia.org/attachment.cgi?id=11739action=edit Math parser tests on patch set 21 This attachment is the result of running: php tests/parserTests.php --file=extensions/Math/mathParserTests.txt mathParserPatchSet21.txt 21 on patch set 21 of https://gerrit.wikimedia.org/r/#/c/30177/ in my Vagrant install. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 Ori Livneh o...@wikimedia.org changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |mflasc...@wikimedia.org |org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 Ori Livneh o...@wikimedia.org changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 physikerwelt phy...@ckurs.de changed: What|Removed |Added CC||phy...@ckurs.de --- Comment #3 from physikerwelt phy...@ckurs.de --- See also http://www.mediawiki.org/wiki/Extension:Math/Roadmap -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 Ori Livneh o...@wikimedia.org changed: What|Removed |Added CC||b...@mzmcbride.com, ||o...@wikimedia.org --- Comment #1 from Ori Livneh o...@wikimedia.org --- Part of the change is already under review: https://gerrit.wikimedia.org/r/#/c/30177/. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 --- Comment #2 from Ori Livneh o...@wikimedia.org --- The author wrote a paper about this change, Making Math Searchable in Wikipedia: http://wiki.physikerwelt.de/images/text_math_search.pdf -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 Legoktm legoktm.wikipe...@gmail.com changed: What|Removed |Added CC||legoktm.wikipe...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 Ori Livneh o...@wikimedia.org changed: What|Removed |Added CC||mflasc...@wikimedia.org -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43222] Review LaTeXML branch of Extension:Math for deployment
https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Blocks||31235 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
