[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #13 from Andre Klapper aklap...@wikimedia.org --- No reply to comment 12 - assuming this bug is FIXED. If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added CC||aklap...@wikimedia.org --- Comment #12 from Andre Klapper aklap...@wikimedia.org --- All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Bug 45209 depends on bug 66709, which changed state. Bug 66709 Summary: Parsoid's local interwiki link check fails on non-Wikipedia wikis https://bugzilla.wikimedia.org/show_bug.cgi?id=66709 What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155784 merged by jenkins-bot: Handle local interwiki links. https://gerrit.wikimedia.org/r/155784 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 C. Scott Ananian canan...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED CC||canan...@wikimedia.org Resolution|FIXED |--- Assignee|marc...@wikimedia.org |canan...@wikimedia.org --- Comment #9 from C. Scott Ananian canan...@wikimedia.org --- I don't think this is correct: [[en:Foo]] on english wikipedia does *not* render the same as [[Foo]]; it uses 'en:Foo' as the link text, not 'Foo'. Re-opening and fixing as part of bug 69909. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 --- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155784 had a related patch set uploaded by Cscott: WIP: handle local interwiki links. https://gerrit.wikimedia.org/r/155784 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 This, that and the other at.li...@live.com.au changed: What|Removed |Added Depends on||66709 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 108065 merged by jenkins-bot: Bug 45209: Handle interwiki links pointing to the current wiki as plain wiki links https://gerrit.wikimedia.org/r/108065 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Marc Ordinas i Llopis marc...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209
--- Comment #4 from ssas...@wikimedia.org ---
Look at parserTests.js -- it sets up a different url for meatball interwiki
wikiConf.interwikiMap.meatball = Util.clone(wikiConf.interwikiMap.meatball);
wikiConf.interwikiMap.meatball.url = 'http://www.usemod.com/cgi-bin/mb.pl?$1';
The default setup there is:
for ( i = 0; i iwmap.length; i++ ) {
key = iwmap[i];
parsoidConfig.interwikiMap[key] = 'http://localhost:7001/api.php';
}
So, either use Meatball: interwiki prefix for testing or set up other
interwikis, but make sure you make the test parsoid only in that case or you
have to make sure php parser generates similar output.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 --- Comment #5 from Marc Ordinas i Llopis marc...@wikimedia.org --- I don't think meatball can serve as the current wiki, as it doesn't have a MW API. Another option would be not setting the API to localhost for one wiki, but that would mean accessing the internet during testing (for its config) which we're trying to avoid… -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 --- Comment #6 from Marc Ordinas i Llopis marc...@wikimedia.org --- Sorry, it turns out the problem doesn't have anything to do with parserTests.js changing the url to localhost. The problem is that when testing, the configs in lib/baseconfig are used, and those are the ones that point to localhost. They also contain an interwikimap that, when loaded (in mediawiki.WikiConfig.js:145), points all language wikis to code.wikipedia.org/wiki/$1. I'll try adding an appropriate entry in each baseconfig so that the 'current' wiki points to localhost as the testing expects. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Marc Ordinas i Llopis marc...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW --- Comment #7 from Marc Ordinas i Llopis marc...@wikimedia.org --- Solved by only making the exception for language prefixes, and not for all prefixes pointing to the same wiki as the PHP parser seems to be working that way. Patch available at https://gerrit.wikimedia.org/r/108065 . -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 --- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 108065 had a related patch set uploaded by Marcoil: (WIP) Bug 45209: Handle interwiki links pointing to the current wiki as plain wiki links https://gerrit.wikimedia.org/r/108065 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Marc Ordinas i Llopis marc...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |ASSIGNED --- Comment #3 from Marc Ordinas i Llopis marc...@wikimedia.org --- I'm having problems adding a parserTest for the referenced patch ( https://gerrit.wikimedia.org/r/108065 ). The way I've found to compare if the link points to the current wiki is to compare the interwiki's url to the current wiki's baseURI (in ext.core.LinkHandler.js:99). This works on manual testing, but in the context of parserTests.js all urls are changed to http://localhost/wiki/index.php/, thus making the test fail for wt2html and html2html. Any ideas on how to proceed? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Marc Ordinas i Llopis marc...@wikimedia.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||marc...@wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Marc Ordinas i Llopis marc...@wikimedia.org changed: What|Removed |Added Assignee|gwi...@wikimedia.org|marc...@wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||roan.katt...@gmail.com See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=57019 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 --- Comment #1 from Gabriel Wicke gwi...@wikimedia.org --- A bit of background: This bug is about a link like [[en:Foo]] in the English Wikipedia (interwiki prefix 'en'). This renders the same as a wiki link ([[Foo]]) in the PHP parser. We should just hide the detail that the link had a prefix and represent it as a wiki link in the DOM. The prefix still needs to round-trip of course, but that is likely already covered by our attribute shadowing. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Keywords||easy -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45209] Handle interwiki links pointing to the current wiki as plain wiki links
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
