[Bug 45666] Deployment review of NamespaceRelations for Wikinews and Wiktionary
https://bugzilla.wikimedia.org/show_bug.cgi?id=45666 This, that and the other at.li...@live.com.au changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW CC||at.li...@live.com.au --- Comment #11 from This, that and the other at.li...@live.com.au --- What is the status here? This would be cool to have on Wiktionary. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45666] Deployment review of NamespaceRelations for Wikinews and Wiktionary
https://bugzilla.wikimedia.org/show_bug.cgi?id=45666 --- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 79050 merged by Wizardist: (Bug 45666) Add profiling calls https://gerrit.wikimedia.org/r/79050 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45666] Deployment review of NamespaceRelations for Wikinews and Wiktionary
https://bugzilla.wikimedia.org/show_bug.cgi?id=45666 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45666] Deployment review of NamespaceRelations for Wikinews and Wiktionary
https://bugzilla.wikimedia.org/show_bug.cgi?id=45666 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 79050 had a related patch set uploaded by Wizardist: (Bug 45666) Add profiling calls https://gerrit.wikimedia.org/r/79050 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45666] Deployment review of NamespaceRelations for Wikinews and Wiktionary
https://bugzilla.wikimedia.org/show_bug.cgi?id=45666 Greg Grossmeier g...@wikimedia.org changed: What|Removed |Added CC||g...@wikimedia.org Severity|normal |enhancement --- Comment #7 from Greg Grossmeier g...@wikimedia.org --- Pavel: could you see about doing some profiling, as per Reedy's suggestion in comment 6? Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45666] Deployment review of NamespaceRelations for Wikinews and Wiktionary
https://bugzilla.wikimedia.org/show_bug.cgi?id=45666 --- Comment #8 from Pavel Selitskas p.selits...@gmail.com --- (In reply to comment #7) Pavel: could you see about doing some profiling, as per Reedy's suggestion in comment 6? Thanks. Yes, sorry for such a delay! Would adding wfProfilingIn/Out calls be enough? Also, after I9fe5728 I'd suggest myself writing some tests to avoid such nasty bugs. That demands further refactoring to make the code testable at some level. There is one more use case that was not addressed: when we move a page, we suggest that talk page is moved to. Currently, any other pages bonded by means of this extension are not moved. I've already seen the code for moving pages, and it looks kind of ancient, but I'll try working it out. :) -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45666] Deployment review of NamespaceRelations for Wikinews and Wiktionary
https://bugzilla.wikimedia.org/show_bug.cgi?id=45666 --- Comment #6 from Sam Reed (reedy) s...@reedyboy.net --- Would be beneficial to add some profiling calls, even more so in injectTabs https://www.mediawiki.org/wiki/Manual:How_to_debug#Advanced_profiling -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45666] Deployment review of NamespaceRelations for Wikinews and Wiktionary
https://bugzilla.wikimedia.org/show_bug.cgi?id=45666
--- Comment #5 from Antoine hashar Musso has...@free.fr ---
The extension code is already available on the beta cluster since the extension
is registered as submodule of mediawiki/extensions.git
If one would like to enable it, that should be done in the
operations/mediawiki-config.git repository.
In wmf-config/InitialiseSettings.php create a global setting to easily
enabled/disable the extension:
$wmgUseNamespaceRelations = array(
'default' = false,
);
Actually use the setting in wmf-config/CommonSettings.php :
if( $wmgUseNamespaceRelations ) {
include $IP/extensions/NamespaceRelations/NamespaceRelations.php;
}
Finally enable the setting on labs in wmf-config/InitialiseSettings-labs.php
add in the wmfLabsSettings() array:
'-wmgUseNamespaceRelations' = array(
'default' = true,
)
The '-' in front of the name instruct to override whatever settings production
might have, since I guess we will always want the extension to be enabled.
Then submit for review, get someone to merge it and it will self deploy via the
job
https://integration.wikimedia.org/ci/view/Beta/job/beta-mediawiki-config-update/
.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45666] Deployment review of NamespaceRelations for Wikinews and Wiktionary
https://bugzilla.wikimedia.org/show_bug.cgi?id=45666 --- Comment #3 from Andre Klapper aklap...@wikimedia.org --- Pavel: Does that mean that everything has been addressed, or is there anything particular still outstanding or blocking? -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45666] Deployment review of NamespaceRelations for Wikinews and Wiktionary
https://bugzilla.wikimedia.org/show_bug.cgi?id=45666 Pavel Selitskas p.selits...@gmail.com changed: What|Removed |Added CC||has...@free.fr --- Comment #4 from Pavel Selitskas p.selits...@gmail.com --- (In reply to comment #3) Pavel: Does that mean that everything has been addressed, or is there anything particular still outstanding or blocking? Yes, hooking was simplified and call-time passing by reference deprecations were taken into account and also fixed. Antoine Musso hashar intended to deploy it on a beta cluster about a month and a half ago, but that wasn't done (I'd actually prefer that to be done at the first place, so that people can see what it is and whether it differs, or not, from the current JavaScript implementation). Addressing your question, I don't observe any blocks out there, although it doesn't mean there aren't any. :) -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45666] Deployment review of NamespaceRelations for Wikinews and Wiktionary
https://bugzilla.wikimedia.org/show_bug.cgi?id=45666 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal CC||suma...@wikimedia.org --- Comment #1 from Andre Klapper aklap...@wikimedia.org --- Assuming you refer to https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment#Review_for_deployment and that both Design review and Code review have successfully taken place already. CC'ing sumanah to find a reviewer. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45666] Deployment review of NamespaceRelations for Wikinews and Wiktionary
https://bugzilla.wikimedia.org/show_bug.cgi?id=45666 --- Comment #2 from Pavel Selitskas p.selits...@gmail.com --- (In reply to comment #1) Assuming you refer to https://www.mediawiki.org/wiki/ Writing_an_extension_for_deployment#Review_for_deployment and that both Design review and Code review have successfully taken place already. CC'ing sumanah to find a reviewer. Yes, although design review request didn't get much attention[1], code review[2] pointed out some issues which were further resolved. -- [1] http://lists.wikimedia.org/pipermail/design/2013-January/000296.html [2] http://lists.wikimedia.org/pipermail/wikitech-l/2013-February/066348.html -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45666] Deployment review of NamespaceRelations for Wikinews and Wiktionary
https://bugzilla.wikimedia.org/show_bug.cgi?id=45666 Pavel Selitskas p.selits...@gmail.com changed: What|Removed |Added Blocks||13228, 31235 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
