[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 Tomasz W. Kozlowski changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #22 from Tomasz W. Kozlowski --- (This is RESOLVED FIXED; Amir's patch should do the trick even without the config change.) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 --- Comment #21 from Gerrit Notification Bot --- Change 90935 merged by jenkins-bot: Revert site specific config change to hewikivoyage https://gerrit.wikimedia.org/r/90935 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 Gerrit Notification Bot changed: What|Removed |Added Status|RESOLVED|PATCH_TO_REVIEW Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 --- Comment #20 from Gerrit Notification Bot --- Change 90935 had a related patch set uploaded by Reedy: Revert site specific config change to hewikivoyage https://gerrit.wikimedia.org/r/90935 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 Tomasz W. Kozlowski changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 --- Comment #19 from Gerrit Notification Bot --- Change 61058 merged by jenkins-bot: Disable 'toc-floated' user option on hevoy https://gerrit.wikimedia.org/r/61058 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 --- Comment #18 from Amir E. Aharoni --- According to my testing it is sufficient and needed. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 --- Comment #17 from Sam Reed (reedy) --- (In reply to comment #16) > Css change has been merged. Perhaps reedy can decide whether or not to deploy > the configuration change. Is Amirs fix sufficient? Is it still needed/wanted? I will merge it if it is still needed/wanted. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 Niklas Laxström changed: What|Removed |Added Keywords|patch-in-gerrit |shell Assignee|amir.ahar...@mail.huji.ac.i |s...@reedyboy.net |l | --- Comment #16 from Niklas Laxström --- Css change has been merged. Perhaps reedy can decide whether or not to deploy the configuration change. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 --- Comment #15 from eikes --- (In reply to comment #14) > I disabled the user option 'toc-floated' by default on hewikivoyage in this > commit: > https://gerrit.wikimedia.org/r/61058/6 Wrong URL. It should have been the following URL: https://gerrit.wikimedia.org/r/#/c/61058/6 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 --- Comment #14 from eikes --- I disabled the user option 'toc-floated' by default on hewikivoyage in this commit: https://gerrit.wikimedia.org/r/61058/6 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 --- Comment #13 from Gerrit Notification Bot --- Related URL: https://gerrit.wikimedia.org/r/61058 (Gerrit Change I71d31ddc5be4a4b9dd47c0d0bd1404de7c8d7b77) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 Amir E. Aharoni changed: What|Removed |Added Keywords||patch-in-gerrit Status|NEW |ASSIGNED Assignee|wikibugs-l@lists.wikimedia. |amir.ahar...@mail.huji.ac.i |org |l --- Comment #12 from Amir E. Aharoni --- I removed the RTL-specific rules in this commit: https://gerrit.wikimedia.org/r/#/c/61051/ It seems like CSSJanus does the right thing without them. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 --- Comment #11 from Gerrit Notification Bot --- Related URL: https://gerrit.wikimedia.org/r/61051 (Gerrit Change Id4549ccb9c8153d0ac62563facf90149996acfb9) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 --- Comment #10 from Tomasz W. Kozlowski --- So I can see three ways out of this problem: 1) Disable the extension on he.wikivoyage; 2) Set $wgDefaultUserOptions['toc-floated'] = false on he.wikivoyage; 3) Commit a change to TocTree/modules/ext.toctree.css. Option 3 is preffered here (fix it if it's broken, not just disable it). @Roland: To fix that, you'd only need to install git & create an account on our Gerrit instance; there are some good instructions at: * https://www.mediawiki.org/wiki/Gerrit/Getting_started * https://www.mediawiki.org/wiki/Gerrit/Tutorial Or, if this is too much hassle for you, just submit a patch here and I'll commit it. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 --- Comment #9 from Nemo --- Does this extension seriously add two preferences? Please just disable it on he.voy -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 --- Comment #8 from RolandUnger --- The default properties for the Table of Contents properties can be changed to be switched off. Normally we proposed to have them switched off (This is the extension's default). // default user options [from TocTree.php] $wgDefaultUserOptions['toc-floated'] = false; $wgDefaultUserOptions['toc-expand'] = false; But the strong English community wanted to switch 'toc-floated' on. And all language branches must have the same default values (I think so). If you like to change it please discuss this problem with the English community. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864
Tomasz W. Kozlowski changed:
What|Removed |Added
CC||tom...@twkozlowski.net
--- Comment #7 from Tomasz W. Kozlowski ---
This is defined in CommonSettings.php…
if ( $wmgUseTocTree ) {
require_once( "$IP/extensions/TocTree/TocTree.php" );
$wgDefaultUserOptions['toc-floated'] = true;
}
…as well as in InitialiseSettings.php:
'wmgUseTocTree' => array(
'default' => false,
'wikivoyage' => true,
),
However, I am not exactly sure what is the purpose of this extension. Of
course, it provides the wiki with the tree option in their TOC, but do we
actually need it at all?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 eikes changed: What|Removed |Added CC||leon.liese...@wikipedia.de --- Comment #6 from eikes --- Changing the last option in [1] to false by default would fix the problem, though. [1] https://he.wikivoyage.org/wiki/%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%94%D7%A2%D7%93%D7%A4%D7%95%D7%AA#mw-prefsection-misc -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864
--- Comment #5 from RolandUnger ---
I tested today better style sheet rules at he.wikivoyage:
(see
http://he.wikivoyage.org/wiki/%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9:RolandUnger/common.css)
/* Switching body.rtl properties off by setting to defaults */
body.rtl #toc .tocUl, body.ltr #toc .tocUl {
padding-left: 2em;
}
body.rtl .toggleNode, body.ltr .toggleNode {
left: -2em;
}
body.rtl #toc.tocFloat, body.ltr #toc.tocFloat {
float: left;
margin: 0 2em 1em 0;
}
/* New rules */
body.rtl.sitedir-rtl #toc.tocFloat {
float: right;
margin: 0 0 1em 2em;
}
After this, it was working well (most of the rules starting with body.rtl
should be removed). This means only changing /toctree/modules/ext.toctree.css
is necessary. Unfortunately I do not know how to make the corrections.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 --- Comment #4 from RolandUnger --- At the old Wikivoyage we could not test the extension for RTL languages. But the TOC behavior is realized only by CSS statements. I will look for additional styles. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 Nemo changed: What|Removed |Added CC||federicol...@tiscali.it --- Comment #3 from Nemo --- (In reply to comment #2) > What about simply removing the extension, which has no aesthetic value at all > anyway? I think it makes sense. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 MF-Warburg changed: What|Removed |Added CC||mfwarb...@googlemail.com --- Comment #2 from MF-Warburg --- What about simply removing the extension, which has no aesthetic value at all anyway? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 --- Comment #1 from Amir E. Aharoni --- It's because of the TocTree extension, which adds floating to table of contents. It has special clauses for body.rtl, which can probably removed to let CSSJanus handle them automatically. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 Amir E. Aharoni changed: What|Removed |Added CC||amir.ahar...@mail.huji.ac.i ||l Component|Internationalization|TocTree Version|1.22-git|master Product|MediaWiki |MediaWiki extensions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 Andre Klapper changed: What|Removed |Added Version|unspecified |1.22-git -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 Siebrand changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 Siebrand changed: What|Removed |Added Keywords||i18n Blocks||745 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46864] on he.wikivoyage TOC are on the left instead of right as you would expect in RTL wiki
https://bugzilla.wikimedia.org/show_bug.cgi?id=46864 Alex Monk (Krenair) changed: What|Removed |Added CC||asha...@wikimedia.org, ||kren...@gmail.com, ||niklas.laxst...@gmail.com, ||run...@gmail.com, ||s.mazel...@xs4all.nl Component|General/Unknown |Internationalization Version|wmf-deployment |unspecified Product|Wikimedia |MediaWiki -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
