[Bug 48137] EditEntity (API) refactoring
https://bugzilla.wikimedia.org/show_bug.cgi?id=48137 Daniel Kinzler daniel.kinz...@wikimedia.de changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48137] EditEntity (API) refactoring
https://bugzilla.wikimedia.org/show_bug.cgi?id=48137 abraham.taheriv...@wikimedia.de changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #5 from abraham.taheriv...@wikimedia.de --- Verified in Wikidata demo time July 17th -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48137] EditEntity (API) refactoring
https://bugzilla.wikimedia.org/show_bug.cgi?id=48137 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Related URL: https://gerrit.wikimedia.org/r/68378 (Gerrit Change I8666bbad10595237ae89fcaf9f0f649656951037) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48137] EditEntity (API) refactoring
https://bugzilla.wikimedia.org/show_bug.cgi?id=48137 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Related URL: https://gerrit.wikimedia.org/r/66981 (Gerrit Change Ic27774f67f8728acbb48cbf945fda063791096cf) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48137] EditEntity (API) refactoring
https://bugzilla.wikimedia.org/show_bug.cgi?id=48137 --- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org --- Related URL: https://gerrit.wikimedia.org/r/66392 (Gerrit Change Id9146d20893f300a66b377f96bf85dc709e3d022) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48137] EditEntity (API) refactoring
https://bugzilla.wikimedia.org/show_bug.cgi?id=48137 abraham.taheriv...@wikimedia.de changed: What|Removed |Added Summary|EditEntity (API)|EditEntity (API) |refactroing |refactoring -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48137] EditEntity (API) refactoring
https://bugzilla.wikimedia.org/show_bug.cgi?id=48137 abraham.taheriv...@wikimedia.de changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48137] EditEntity (API) refactoring
https://bugzilla.wikimedia.org/show_bug.cgi?id=48137 abraham.taheriv...@wikimedia.de changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48137] EditEntity (API) refactoring
https://bugzilla.wikimedia.org/show_bug.cgi?id=48137 Daniel Kinzler daniel.kinz...@wikimedia.de changed: What|Removed |Added CC||daniel.kinz...@wikimedia.de --- Comment #1 from Daniel Kinzler daniel.kinz...@wikimedia.de --- The EditEntity API module needs refactoring. Two steps are suggested: 1) Factor individual modifications (like set lable, remove alias) into ChangeOp classes (similar to, maybe even compatible to DiffOp). besides modifying the entity, they should faciliate the creation of summaries and permission checks. 2) Move the module's logic into a handler/controller. That controller may be aware of the API, especially of the Request and Result objects. Isolation from that knowledge would be nice, but is not essential at the moment. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
