[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 bs...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #18 from bs...@wikimedia.org --- I will mark this bug as resolved for now. Feel free to re-open this if bug pops up again and I will do further investigation. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 --- Comment #17 from Gerrit Notification Bot --- Change 76038 merged by jenkins-bot: (bug 48568) Bust IE browser ajax cache + some API clenaup https://gerrit.wikimedia.org/r/76038 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 --- Comment #16 from Gerrit Notification Bot --- Change 76038 had a related patch set uploaded by Bsitu: (bug 48568) Bust IE browser ajax cache + some API clenaup https://gerrit.wikimedia.org/r/76038 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 --- Comment #15 from bs...@wikimedia.org --- (In reply to comment #14) > (In reply to comment #13) > > The fix is already in 1.22wmf11 which will be deployed to enwiki on Thursday > > Actually, it looks like it just missed making it into 1.22wmf11. But it'll be > in 1.22wmf12. Thanks for the note! In that case, we will try to cherry-pick and deploy this change to enwiki in the lightning window on Thursday -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 --- Comment #14 from Brad Jorsch --- (In reply to comment #13) > The fix is already in 1.22wmf11 which will be deployed to enwiki on Thursday Actually, it looks like it just missed making it into 1.22wmf11. But it'll be in 1.22wmf12. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 --- Comment #13 from bs...@wikimedia.org --- The fix is already in 1.22wmf11 which will be deployed to enwiki on Thursday -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 --- Comment #12 from Quiddity --- Update today, that SandyGeorgia is experiencing the problem again. Sandy is using Internet Explorer 10. Describes the problem as: "Old notifications showing, red bar won't go away, can't get links to new posts." http://en.wikipedia.org/wiki/Wikipedia_talk:Notifications#Almost_two_weeks_later.2C_again -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 --- Comment #11 from Gerrit Notification Bot --- Change 73531 merged by jenkins-bot: (bug 48568) Bust IE browser ajax cache + some API clenaup https://gerrit.wikimedia.org/r/73531 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 --- Comment #10 from Gerrit Notification Bot --- Change 73531 had a related patch set uploaded by Bsitu: (bug 48568) Bust IE browser ajax cache + some API clenaup https://gerrit.wikimedia.org/r/73531 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 bs...@wikimedia.org changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |bs...@wikimedia.org |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 --- Comment #9 from bs...@wikimedia.org --- Yes, this does seem like the famous IE Ajax cache problem -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 Brad Jorsch changed: What|Removed |Added CC||bjor...@wikimedia.org --- Comment #8 from Brad Jorsch --- (In reply to comment #6) > There's no API request involved. That's not entirely true. The number itself is served with the page, yes, but the "flyout" is done with an API request to fetch the actual messages. And then a second API request is performed to mark the messages as read, based on what was returned by the first request. And I note that both of these are sent as GET requests and don't seem to set any additional caching-related headers on the request, and the responses don't seem to do anything special cache-wise either, meaning it is very likely that some browsers will cache them in at least some configurations. I'm not familiar with IE configuration, but I imagine that adjusting the caching settings to their most aggressive values would allow you to reproduce the bug. If the browser or proxy responds to the first request from cache, that would certainly cause what SandyGeorgia reports. And the cached data would also cause the "mark read" query to not include the ids that are actually unread, so they wouldn't get marked as read and the number would remain for later pageviews as is reported here. Off the top of my head, one way around that would be to include some data attribute on the notification badge with the id or timestamp of the most recent notification, and use that value as a cache buster on the API request. Further, once the first request is served from cache, the second will probably be served from cache too since it will have the same value for 'notmarkread' as was sent the first time. While fixing the caching issue in the first would prevent this anyway, I do note that this second query should be a POST rather than a GET since it is intended to change state on the server. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 --- Comment #7 from Ryan Kaldari --- I tried reproducing in IE9, but was not able to. If anyone can reliably reproduce, please post the steps to do so. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 --- Comment #6 from Ryan Kaldari --- There's no API request involved. The data is served as part of the page (same as the old Orange Bar of Death functionality). You can turn off Javascript entirely and it will still work the same. If you're logged in, the cache headers on the page should be "s-maxage=0, max-age=0, must-revalidate". I suppose it's possible IE is caching it anyway, or there is some proxy server between the user and WMF that is caching it, but this wouldn't have been changed by Echo. They would have had the same problem with the Orange Bar of Death. The only way I can reproduce this bug myself is by using the back button, but there's not a lot we can do about that. We could in theory fire an API request on every page load (and even trigger it on using the back button), but that would be a huge increase in API requests. I would only want to do that as a last resort. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 Derk-Jan Hartman changed: What|Removed |Added CC||hartman.w...@gmail.com --- Comment #5 from Derk-Jan Hartman --- TCO sees this and he is using Internet Explorer 10 on Windows 7. Does seem like a caching issue. We should set an explicit 'fast' (or always?) expire on the the "are there new message" api request. That should return an timestamp or something. This timestamp can be used in the request of the "get my messages request", populate the flyout to avoid that one being cached out of sync, which apparently happens for SandyGeorgia: https://en.wikipedia.org/wiki/Wikipedia_talk:Notifications#Another_example_five_days_later Apparently IE (unlike Chrome/Firefox) caches all GET requests, even AJAX ones. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 --- Comment #4 from Ryan Kaldari --- Works for me. Can anyone post steps to reliably reproduce this bug? It would also be helpful to know what browser is being used in case it's some sort of JS or client-side caching bug. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 Quiddity changed: What|Removed |Added CC||pandiculat...@gmail.com --- Comment #3 from Quiddity --- Same problem mentioned at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Notification_Bug and at https://en.wikipedia.org/wiki/Wikipedia_talk:Notifications#Exasperated -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 --- Comment #2 from Andre Klapper --- Same problem mentioned here: https://en.wikipedia.org/w/index.php?title=Wikipedia:Help_desk&oldid=555485451#how_do_I_get_rid_of_the_red_blurb_at_the_top_by_my_name.3F -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 --- Comment #1 from dlerne...@gmail.com --- By clicking on "All notifications", I was able to reset the counter. But if this is the only way to reset the counter, that is going to be a problem... -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48568] red notification number not clearing
https://bugzilla.wikimedia.org/show_bug.cgi?id=48568 dlerne...@gmail.com changed: What|Removed |Added Web browser|--- |Internet Explorer -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
