[Bug 48611] QUnit tests: Missing expert destruction leads to failing tests when resourceloaderdebug is disabled
https://bugzilla.wikimedia.org/show_bug.cgi?id=48611 denny vrandecic changed: What|Removed |Added Status|RESOLVED|VERIFIED CC||denny.vrandecic@wikimedia.d ||e -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48611] QUnit tests: Missing expert destruction leads to failing tests when resourceloaderdebug is disabled
https://bugzilla.wikimedia.org/show_bug.cgi?id=48611 Henning (WMDE) changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48611] QUnit tests: Missing expert destruction leads to failing tests when resourceloaderdebug is disabled
https://bugzilla.wikimedia.org/show_bug.cgi?id=48611 --- Comment #7 from Gerrit Notification Bot --- Change 76741 merged by Jeroen De Dauw: (bug 48611) valueview expert test setups won't create instances anymore https://gerrit.wikimedia.org/r/76741 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48611] QUnit tests: Missing expert destruction leads to failing tests when resourceloaderdebug is disabled
https://bugzilla.wikimedia.org/show_bug.cgi?id=48611 Henning (WMDE) changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW --- Comment #6 from Henning (WMDE) --- Does not work properly without additionally applying https://gerrit.wikimedia.org/r/#/c/76744/ https://gerrit.wikimedia.org/r/#/c/77479/ -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48611] QUnit tests: Missing expert destruction leads to failing tests when resourceloaderdebug is disabled
https://bugzilla.wikimedia.org/show_bug.cgi?id=48611 Henning (WMDE) changed: What|Removed |Added Status|VERIFIED|REOPENED Resolution|FIXED |--- --- Comment #5 from Henning (WMDE) --- The according change set has not been merged. How come the fix for this bug got verified? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48611] QUnit tests: Missing expert destruction leads to failing tests when resourceloaderdebug is disabled
https://bugzilla.wikimedia.org/show_bug.cgi?id=48611 abraham.taheriv...@wikimedia.de changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #4 from abraham.taheriv...@wikimedia.de --- Verified in Wikidata demo July 31th. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48611] QUnit tests: Missing expert destruction leads to failing tests when resourceloaderdebug is disabled
https://bugzilla.wikimedia.org/show_bug.cgi?id=48611 abraham.taheriv...@wikimedia.de changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED CC||abraham.taherivand@wikimedi ||a.de Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48611] QUnit tests: Missing expert destruction leads to failing tests when resourceloaderdebug is disabled
https://bugzilla.wikimedia.org/show_bug.cgi?id=48611 --- Comment #3 from Daniel Werner --- Anyhow, when instantiating certain experts (e.g. time expert) they will use widgets that add some node to the html's body immediately (e.g. inputextender). In the tests of those widgets it is asserted whether the body contains any leftover DOM nodes. This assertion fails in case experts using those widgets got constructed during test setups but not destroyed. My change set will prevent the test setups from initializing experts before the actual test. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48611] QUnit tests: Missing expert destruction leads to failing tests when resourceloaderdebug is disabled
https://bugzilla.wikimedia.org/show_bug.cgi?id=48611 Daniel Werner changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment #2 from Daniel Werner --- This is actually not just about missing experts destruction primarily, it is mostly about experts being constructed outside of the actual tests (in some test definitions) which will even happen if the tests should not even be executed (e.g. because of using ?filter=xxx). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48611] QUnit tests: Missing expert destruction leads to failing tests when resourceloaderdebug is disabled
https://bugzilla.wikimedia.org/show_bug.cgi?id=48611 Daniel Werner changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48611] QUnit tests: Missing expert destruction leads to failing tests when resourceloaderdebug is disabled
https://bugzilla.wikimedia.org/show_bug.cgi?id=48611 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48611] QUnit tests: Missing expert destruction leads to failing tests when resourceloaderdebug is disabled
https://bugzilla.wikimedia.org/show_bug.cgi?id=48611 --- Comment #1 from Gerrit Notification Bot --- Change 76741 had a related patch set uploaded by Daniel Werner: (bug 48611) valueview expert test setups won't create instances anymore https://gerrit.wikimedia.org/r/76741 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
