[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 91549 merged by jenkins-bot: Add Special:Thanks as a non-JS fallback https://gerrit.wikimedia.org/r/91549 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added CC||liang...@gmail.com --- Comment #7 from Bartosz Dziewoński matma@gmail.com --- *** Bug 56049 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 91549 had a related patch set uploaded by Legoktm: Add Special:Thanks as a non-JS fallback https://gerrit.wikimedia.org/r/91549 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added CC||legoktm.wikipe...@gmail.com Assignee|wikibugs-l@lists.wikimedia. |legoktm.wikipe...@gmail.com |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 80336 abandoned by Mattflaschen: Hide thank link when there is no JavaScript Reason: This isn't really a solution due to the dangling pipe/paren issue. https://gerrit.wikimedia.org/r/80336 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Assignee|mflasc...@wikimedia.org |wikibugs-l@lists.wikimedia. ||org -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 Ricordisamoa ricordisa...@live.it changed: What|Removed |Added CC||ricordisa...@live.it --- Comment #5 from Ricordisamoa ricordisa...@live.it --- Agree with PartTimeGnome: a static non-JS link should work, as mark as patrolled and watch this page do. Change 80336 is a provisional patch and could be avoided. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 Helder mybugs.m...@gmail.com changed: What|Removed |Added Keywords||accessibility -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |mflasc...@wikimedia.org |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 --- Comment #2 from Matthew Flaschen mflasc...@wikimedia.org --- Created attachment 13147 -- https://bugzilla.wikimedia.org/attachment.cgi?id=13147action=edit Thanks link hidden with CSS but leaving dangling pipe Hiding just the link is simple, and I'll submit a patch to do that for the interim. The problem, as shown in the image, is there's also a pipe separator (with no good selector), added server-side by MW core. That can't be hidden easily with CSS. The patch (with the dangling pipe) is still probably worth merging in the interim, but the best approaches are probably either: 1. Supporting thanking without JavaScript (as suggested in the report). 2. Generate the thank link with JavaScript -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|UNCONFIRMED |PATCH_TO_REVIEW Ever confirmed|0 |1 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 80336 had a related patch set uploaded by Mattflaschen: Hide thank link when there is no JavaScript https://gerrit.wikimedia.org/r/80336 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment #4 from Matthew Flaschen mflasc...@wikimedia.org --- It shows empty parentheses instead of the pipe for the diff page. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Keywords||javascript -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 49161] (thank) is shown if JS is disabled, but it's a broken link
https://bugzilla.wikimedia.org/show_bug.cgi?id=49161 --- Comment #1 from Ryan Kaldari rkald...@wikimedia.org --- Good catch. We'll probably just want to not show the Thank link for non-JS users. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
